[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. branch cut is upon us, so it'd be great if you can land this soon (or let us know if you don't have commit access) Comment at: clang-tools-extra/clangd/refactor/tweaks/E

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added a comment. In D142092#4068792 , @VitaNuo wrote: > Added the re-generated symbol maps to this patch as per @hokein's request. Sorry for not being cleared. My suggestion was to generate the maps on the old data (2018-10-28), the reason is tha

[clang] 8f15c4c - [clang][Interp][NFC] Add Record::getDestructor()

Author: Timm Bäder Date: 2023-01-23T10:19:34+01:00 New Revision: 8f15c4c2a0fb61469060f9cf85b0b5adee8e0275 URL: https://github.com/llvm/llvm-project/commit/8f15c4c2a0fb61469060f9cf85b0b5adee8e0275 DIFF: https://github.com/llvm/llvm-project/commit/8f15c4c2a0fb61469060f9cf85b0b5adee8e0275.diff LO

[clang] 284bd95 - [clang][Interp][NFC] Remove unused using alias

Author: Timm Bäder Date: 2023-01-23T10:19:34+01:00 New Revision: 284bd95e80fc7674040f62b8c09ea06a54bd51b9 URL: https://github.com/llvm/llvm-project/commit/284bd95e80fc7674040f62b8c09ea06a54bd51b9 DIFF: https://github.com/llvm/llvm-project/commit/284bd95e80fc7674040f62b8c09ea06a54bd51b9.diff LO

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 491251. Michael137 added a comment. - `setIsDefaulted` when constructing `ClassTemplateSpecializationDecl`s - Propagate `IsDefaulted` on serialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/

[PATCH] D141827: [WIP][clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 updated this revision to Diff 491254. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141827/new/ https://reviews.llvm.org/D141827 Files: clang/lib/AST/TypePrinter.cpp Index: clang/lib/AST/TypePrin

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since `ClassTemplateSpecializationDecl`s now set the `TemplateArgument:

[clang] d54ae90 - [clang][Interp][NFC] Rename InlineDescptor::IsMutable to IsFieldMutable

Author: Timm Bäder Date: 2023-01-23T10:32:51+01:00 New Revision: d54ae905d13ed56ab8f4ce0147eb92801684f0f3 URL: https://github.com/llvm/llvm-project/commit/d54ae905d13ed56ab8f4ce0147eb92801684f0f3 DIFF: https://github.com/llvm/llvm-project/commit/d54ae905d13ed56ab8f4ce0147eb92801684f0f3.diff LO

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbee8860525ac: [clang][DebugInfo] Don't canonicalize names in template argument list for alias… (authored by Michael137). Repository: rG LLVM Githu

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. In D141826#4059088 , @erichkeane wrote: > In D141826#4059073 , @Michael137 > wrote: > >> In D141826#4058866 , @erichkeane >> wrote: >> >>> T

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta created this revision. xgupta added reviewers: aaron.ballman, usaxena95. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found by PVS-Studio - https://pvs-studio.com/en/blog/posts/cpp/1003/, N37.

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 added a comment. In D142268#4072358 , @dblaikie wrote: > So @Michael137 and I talked about this offline, and a few extra details: > > - Generally it's important that types have identical names. Templates try to > do this, but get it wrong in a

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

Michael137 updated this revision to Diff 491257. Michael137 added a comment. - Make variable `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142333/new/ https://reviews.llvm.org/D142333 Files: clang/lib/CodeGen/CGDebugInfo.cpp Index: cla

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Oh I misunderstood your comment regarding which maps need to be regenerated as part of this patch. Regenerated the 2018 ones now. As expected, there are only added symbols now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D142144: [RISCV][Driver] Add -rvv-vector-bits= option similar to -sve-vector-bits=

frasercrmck added inline comments. Comment at: clang/include/clang/Driver/Options.td:3587 + HelpText<"Specify the size in bits of an RVV vector register. Defaults to the" + " vector length agnostic value of \"scalable\". Also accepts \"zvl\"" + " to use the

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491260. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/incl

[clang] bee8860 - [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Author: Michael Buch Date: 2023-01-23T09:43:17Z New Revision: bee8860525acbfe33f5b32870ad5e13de07fa6ff URL: https://github.com/llvm/llvm-project/commit/bee8860525acbfe33f5b32870ad5e13de07fa6ff DIFF: https://github.com/llvm/llvm-project/commit/bee8860525acbfe33f5b32870ad5e13de07fa6ff.diff LOG:

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 491265. Michael137 added a comment. - Rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/PropertiesBase.td clang/includ

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

kwk added a comment. In D141581#4071617 , @thesamesam wrote: > This is currently holding back further testing on our end which is concerning > me a bit, especially as we approach the branch point. Could you revert this > please if a fix isn't imminent?

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 491267. tblah added a comment. - Rename option macro to make it clear that it doesn't do marshalling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 Files: clang/incl

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

xgupta created this revision. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the current calling convection CurCC is not equal to Target calling convection ToCC and current calling convention (CurCC)

[PATCH] D139326: [clang] Add test for CWG952

Endill added inline comments. Comment at: clang/test/CXX/drs/dr9xx.cpp:76 +namespace dr952 { // dr952: yes +struct A { + typedef int I; // #dr952-typedef-decl aaron.ballman wrote: > I wouldn't mind another test case: > ``` > struct A { > protected: > static in

[clang] ddbe140 - Add clang_CXXMethod_isExplicit to libclang

Author: Luca Di Sera Date: 2023-01-23T11:30:38+01:00 New Revision: ddbe14084da7f31d4b4b53e13d9f868d759f3673 URL: https://github.com/llvm/llvm-project/commit/ddbe14084da7f31d4b4b53e13d9f868d759f3673 DIFF: https://github.com/llvm/llvm-project/commit/ddbe14084da7f31d4b4b53e13d9f868d759f3673.diff

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddbe14084da7: Add clang_CXXMethod_isExplicit to libclang (authored by diseraluca). Changed prior to commit: https://reviews.llvm.org/D140756?vs=48

[clang] 6469281 - [clang][Interp][NFC] Remove InitFn code

Author: Timm Bäder Date: 2023-01-23T12:19:36+01:00 New Revision: 6469281100e654f690af8d5bcf0123e4105cafbe URL: https://github.com/llvm/llvm-project/commit/6469281100e654f690af8d5bcf0123e4105cafbe DIFF: https://github.com/llvm/llvm-project/commit/6469281100e654f690af8d5bcf0123e4105cafbe.diff LO

[PATCH] D142346: [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

mstorsjo created this revision. mstorsjo added reviewers: efriedma, aaron.ballman, alvinhochun, mati865. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: MaskRay. Herald added a project: All. mstorsjo requested review of this revision. Herald added a reviewer: jdoerfert. He

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

kiranchandramohan created this revision. Herald added a subscriber: sunshaoce. Herald added a project: All. kiranchandramohan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D139921: [include-cleaner] Ranking of providers based on hints

kadircet updated this revision to Diff 491286. kadircet marked 23 inline comments as done. kadircet added a comment. - Address comments & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139921/new/ https://reviews.llvm.org/D139921 Files: cl

[PATCH] D139921: [include-cleaner] Ranking of providers based on hints

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:133 + + Header(std::in_place_t, decltype(Storage) Sentinel) + : Storage(std::move(Sentinel)) {} sammccall wrote: > this is a bit confusing..

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry updated this revision to Diff 491287. v1nh1shungry added a comment. land comment's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://reviews.llvm.org/D142014 Files: clang-tools-extra/clangd/Hover.cpp cl

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry marked 2 inline comments as done. v1nh1shungry added a comment. Thanks for the review! @nridge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://reviews.llvm.org/D142014 ___

[clang] ebbeb16 - [clang] Fix the location of UsingTypeLoc.

Author: Haojian Wu Date: 2023-01-23T12:51:21+01:00 New Revision: ebbeb164c25a40cb6ba9c6b18dce5dcd06c0bb07 URL: https://github.com/llvm/llvm-project/commit/ebbeb164c25a40cb6ba9c6b18dce5dcd06c0bb07 DIFF: https://github.com/llvm/llvm-project/commit/ebbeb164c25a40cb6ba9c6b18dce5dcd06c0bb07.diff LO

[PATCH] D142125: [clang] Fix the location of UsingTypeLoc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebbeb164c25a: [clang] Fix the location of UsingTypeLoc. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 1af7164 - Revert "Add clang_CXXMethod_isExplicit to libclang"

Author: Luca Di Sera Date: 2023-01-23T12:55:34+01:00 New Revision: 1af716499d6bc29afd9ff2903200890df774859f URL: https://github.com/llvm/llvm-project/commit/1af716499d6bc29afd9ff2903200890df774859f DIFF: https://github.com/llvm/llvm-project/commit/1af716499d6bc29afd9ff2903200890df774859f.diff

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491258. VitaNuo added a comment. Update the 20181028 archive maps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSy

[PATCH] D140959: RFC: Multilib prototype

lenary added a comment. Thanks for putting together this proposal. Broadly, I think it's good, and I think it solves a lot of rough edges that I recall running into with the GCC multilib configuration files in the past. I do worry about using `-cc1` args. On the one hand, it's the best place fo

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4699a43e426: [MLIR][OpenMP] Added target data, exit data, and enter data operation… (authored by TIFitis). Changed prior to commit: https://reviews.llvm.org/D131915?vs=489881&id=491299#toc Repository:

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGMT. Comment at: clang/lib/CodeGen/TargetInfo.cpp:591 if (isa(RT->getDecl()) && - (WasArray || !FD->hasAttr())) + (WasArray || (!FD->hasAttr() && !AsI

[PATCH] D142346: [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Clang bits LGTM (so do the rest FWIW). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142346/new/ https://reviews.llvm.org/D142346

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta updated this revision to Diff 491312. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142334/new/ https://reviews.llvm.org/D142334 Files: clang/include/clang/APINotes/Types.h Index: clang/include/c

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang/include/clang/APINotes/Types.h:535 NullabilityPayload &= -~(NullabilityKindMask << (index * NullabilityKindSize)); +~(static_castNullabilityKindMask << (index * Nullabil

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke added inline comments. Comment at: flang/docs/ComplexOperations.md:37 **FIR** -```c func.func @_QPpow_self(%arg0: !fir.ref>) -> !fir.complex<4> { luke wrote: > tstellar wrote: > > Do these changes have any affected on the output html? Is there another >

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

aaron.ballman added inline comments. Comment at: clang/include/clang/APINotes/Types.h:535 NullabilityPayload &= -~(NullabilityKindMask << (index * NullabilityKindSize)); +~(static_castNullabilityKindMask << (index * NullabilityKindSize));

[clang] 6f96dad - [Clang][NFC] Remove documentation and mentions of deleted tools

Author: Joseph Huber Date: 2023-01-23T07:15:54-06:00 New Revision: 6f96dadb7a5b1593a0b6348539f66f7e945f2561 URL: https://github.com/llvm/llvm-project/commit/6f96dadb7a5b1593a0b6348539f66f7e945f2561 DIFF: https://github.com/llvm/llvm-project/commit/6f96dadb7a5b1593a0b6348539f66f7e945f2561.diff

[clang] bcc05cb - [Clang] Remove flaky test line from linker wrapper test

Author: Joseph Huber Date: 2023-01-23T07:15:53-06:00 New Revision: bcc05cbfa8088db8ddb4beeea066147c2dc334ba URL: https://github.com/llvm/llvm-project/commit/bcc05cbfa8088db8ddb4beeea066147c2dc334ba DIFF: https://github.com/llvm/llvm-project/commit/bcc05cbfa8088db8ddb4beeea066147c2dc334ba.diff

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

5chmidti updated this revision to Diff 491319. 5chmidti added a comment. Herald added a subscriber: ChuanqiXu. 1. addressed comments 2 bugfix (sorry, should've said something) Local variables inside the lambda were previously added to the ReferencedDecls vector and would block the action inside

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli updated this revision to Diff 491320. fpetrogalli added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. @mgorny, I have updated the patch according to the suggestions from @tstellar in https://reviews.llvm.

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke updated this revision to Diff 491318. luke added a comment. Don't suppress misc.highlighting_failure warning Instead just fix the flang code block that was failing to highlight Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142199/new/ https:/

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

KKoovalsky updated this revision to Diff 491324. KKoovalsky added a comment. 1. Fixed lit fail: dereferencing a null pointer when calling `ignoreImplicit()` on `CommonAncestor` being `nullptr` - fixed with sanitization of `CommonAncestor` being `nullptr`. 2. Fixed link error: missing `ASTMatcher

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

kadircet added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:174 - # std::remove<> has variant algorithm. - "std::remove": ("algorithm"), - } this is actually checking for something else (sorry for the confusing naming

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

ymandel added a comment. In D140434#4071823 , @carlosgalvezp wrote: > In D140434#4053053 , @suertreus > wrote: > >> Thanks for reviewing. >> >> I don't have commit access; can someone who does please do the thin

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

asb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11827 +def err_wasm_builtin_arg_must_be_integer_type : Error < + "%ordinal0 argument must be an integer">; } // end of sema component. aaron.ballman wrote: > I'm a bit shock

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

spaits created this revision. spaits added reviewers: Szelethus, steakhal, NoQ, gamesh411, xazax.hun. spaits added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

KKoovalsky updated this revision to Diff 491331. KKoovalsky added a comment. 1. Fixed lit fail: dereferencing a null pointer when calling `ignoreImplicit()` on `CommonAncestor` being `nullptr` - fixed with sanitization of `CommonAncestor` being `nullptr`. 2. Fixed link error: missing `ASTMatcher

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

courbet added a comment. Herald added a subscriber: ChuanqiXu. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141925/new/ https://reviews.llvm.org/D141925 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11797 +def err_typecheck_wasm_table_must_have_zero_length : Error< + "only zero-length WebAssembly tables are currently supported">; +def err_wasm_

[PATCH] D142346: [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

alvinhochun accepted this revision. alvinhochun added a comment. Thanks, LGTM for the parts I touched and also the rest of the stuff (but I didn't proofread carefully). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142346/new/ https://reviews.llvm

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added a comment. Can you add a unittest in the `StandardLibraryTest.cpp`? Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:1053 SYMBOL(remainder, std::, ) +SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) I think `std::rem

[PATCH] D139921: [include-cleaner] Ranking of providers based on hints

This revision was automatically updated to reflect the committed changes. Closed by commit rG749c6a708340: [include-cleaner] Ranking of providers based on hints (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139921/new/ https:

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

mgorny added a comment. In D141581#4072692 , @kwk wrote: > In D141581#4071617 , @thesamesam > wrote: > >> This is currently holding back further testing on our end which is >> concerning me a bit, especially as

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

aaron.ballman added a comment. You also need to add the new matcher to Registry.cpp so it's usable from the dynamic matchers, and you should add a release note for the new matcher. Are you planning to use this matcher in-tree for something? (We don't usually add new matchers until there's a nee

[clang-tools-extra] 749c6a7 - [include-cleaner] Ranking of providers based on hints

Author: Kadir Cetinkaya Date: 2023-01-23T15:22:47+01:00 New Revision: 749c6a708340f772f72e1d33594cdb51bb28e190 URL: https://github.com/llvm/llvm-project/commit/749c6a708340f772f72e1d33594cdb51bb28e190 DIFF: https://github.com/llvm/llvm-project/commit/749c6a708340f772f72e1d33594cdb51bb28e190.dif

[PATCH] D142346: [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

MaskRay accepted this revision. MaskRay added inline comments. Comment at: lld/docs/ReleaseNotes.rst:78 + if ``-static`` has been specified. This fixes conformance to what + GNU ld dpes. (`D135651 `_) + `s/dpes/does/` Reposit

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

courbet added a comment. In D141925#4073385 , @aaron.ballman wrote: > You also need to add the new matcher to Registry.cpp so it's usable from the > dynamic matchers, and you should add a release note for the new matcher. Thanks, will do. > (We don't

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

KKoovalsky updated this revision to Diff 491347. KKoovalsky added a comment. Fixed nullptr dereferencing and missing ASTMatchers lib linking 1. Fixed lit fail: dereferencing a null pointer when calling ignoreImplicit() on CommonAncestor being nullptr - fixed with sanitization of CommonAncestor

[PATCH] D142265: [AArch64] Function multi-versioning release notes added. NFC.

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. LGTM Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142265/new/ https://reviews.llvm.org/D142265

[clang] 7ac7763 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2023-01-23T14:13:09Z New Revision: 7ac776310a1e3016f6aafc7c9aac6c0c9274a513 URL: https://github.com/llvm/llvm-project/commit/7ac776310a1e3016f6aafc7c9aac6c0c9274a513 DIFF: https://github.com/llvm/llvm-project/commit/7ac776310a1e3016f6aafc7c9aac6c0c9274a513.diff LOG:

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

courbet updated this revision to Diff 491348. courbet added a comment. add matcher to registry and add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141925/new/ https://reviews.llvm.org/D141925 Files: clang/docs/LibASTMatchersRefere

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. I'm not familiar with the WinEH stuff, but the other parts (the code that adds bundles, etc.) LGTM. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:597 + as

[PATCH] D141925: [ASTMatchers] Add `isDirectInit` matcher.

aaron.ballman added a comment. In D141925#4073405 , @courbet wrote: > In D141925#4073385 , @aaron.ballman > wrote: > >> You also need to add the new matcher to Registry.cpp so it's usable from the >> dynamic mat

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142334/new/ https://reviews.llvm.org/D142334

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

sgraenitz added a comment. Thanks for working on this! It looks like this is going to be the clang-repl equivalent for Cling's `.L` command. Do you think we can get test coverage for it? So far, the only tests I found for `libclangInterpreter` are unit tests in https://github.com/llvm/llvm-pro

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn created this revision. nicolerabjohn added reviewers: hubert.reinterpretcast, cebowleratibm, daltenty, dblaikie. Herald added a project: All. nicolerabjohn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is already a GC

[PATCH] D142315: [clang] Add test for CWG1111

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:31 + } +} + Can you also add the last example (with struct A) from the issue, and find a way to confirm that it is calling the right version? Comment at: clang/www/cx

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491353. pmatos marked 7 inline comments as done. pmatos added a comment. Address more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rG68b890831615: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h (authored by xgupta). Repository:

[clang] 68b8908 - [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

Author: Shivam Gupta Date: 2023-01-23T20:18:08+05:30 New Revision: 68b890831615fc4350a47cf7ec404156128d03ac URL: https://github.com/llvm/llvm-project/commit/68b890831615fc4350a47cf7ec404156128d03ac DIFF: https://github.com/llvm/llvm-project/commit/68b890831615fc4350a47cf7ec404156128d03ac.diff

[PATCH] D142315: [clang] Add test for CWG1111

aaron.ballman added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 erichkeane wrote: > Were you able to track down which patch fixed this in clang 6? > > I also

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:34-35 + virtual ~DeclScope() override { this->emitDestruction(); } + void addExtended(const Scope::Local &Local) override { The destructor for `LocalScope` already cal

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but can you find a test case that would show we don't regress this in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:8297 << Arg->getSourceRange(); } else if (IsAArch64Builtin && Fields.size() == 1) { +// If this is a write ... tmatheson wrote: > It might be more readable to outline t

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491367. VitaNuo added a comment. Re-introduce the special std::remove handling for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/T

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:174 - # std::remove<> has variant algorithm. - "std::remove": ("algorithm"), - } kadircet wrote: > this is actually checking for something else (sorry for the

[clang] 03ef89f - [AArch64] Check 128-bit Sysreg Builtins

Author: Archibald Elliott Date: 2023-01-23T15:24:30Z New Revision: 03ef89f8d9094bf70416e19d0e909909b100a4a0 URL: https://github.com/llvm/llvm-project/commit/03ef89f8d9094bf70416e19d0e909909b100a4a0 DIFF: https://github.com/llvm/llvm-project/commit/03ef89f8d9094bf70416e19d0e909909b100a4a0.diff

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03ef89f8d909: [AArch64] Check 128-bit Sysreg Builtins (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:62 const CompilerInstance *getCompilerInstance() const; - const llvm::orc::LLJIT *getExecutionEngine() const; + llvm::Expected GetExecutionEngine(); + sgraenitz wrote:

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

daltenty added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:616-617 +// This ends the #if !defined(__MVS__) && !defined(__AIX__) block from line 12 +#endif + nit: line numbers may shift on you as other commits touch this file. Prefer a sa

[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM but others should also chime in. Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:101 + +struct s5 { struct empty e[1]; float f; }; +

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

zahiraam created this revision. zahiraam added reviewers: mdtoguchi, andrew.w.kaylor. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. This option is useful for clang and clang-cl. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn updated this revision to Diff 491375. nicolerabjohn added a comment. Updating comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/OSTargets.h clang/test/SemaCXX

[PATCH] D142315: [clang] Add test for CWG1111

shafik added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 aaron.ballman wrote: > erichkeane wrote: > > Were you able to track down which patch fixed this in cla

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491380. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments regarding data structure use and style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://revie

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491382. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clan

[PATCH] D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension

pratlucas updated this revision to Diff 491384. pratlucas added a comment. Rebasing, including minor changes due to recent target parser refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141403/new/ https://reviews.llvm.org/D141403 Files:

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:20 static llvm::StringRef *HeaderNames; -static std::pair *SymbolNames; -static unsigned *SymbolHeaderIDs; +static llvm::DenseMap> +*SymbolNames; hokein wrote:

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

pratlucas updated this revision to Diff 491385. pratlucas added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Updated to use the same approach as D141518 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

xgupta added a comment. In D142304#4073573 , @aaron.ballman wrote: > LGTM but can you find a test case that would show we don't regress this in > the future? I haven't found the test case, but I found a commit

[PATCH] D142316: [clang] Add test for CWG2396

shafik added a comment. You mention CWG2385 as na but you don't explain how it was resolved, was it superceded by p1787 . Also nitpick you mentioned `P1787` in the description but it links to a ph

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 shafik wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Were you able to track down which pat

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

tmatheson added inline comments. Comment at: clang/test/Driver/aarch64-cssc.c:11 +// RUN: %clang -S -o - -emit-llvm -target aarch64-none-none-eabi -march=armv9.4-a+cssc %s 2>&1 | FileCheck %s +// RUN: %clang -S -o - -emit-llvm -target aarch64-none-none-eabi -march=armv9.4-a+n

  1   2   3   4   >