xgupta added a comment. In D142304#4073573 <https://reviews.llvm.org/D142304#4073573>, @aaron.ballman wrote:
> LGTM but can you find a test case that would show we don't regress this in > the future? I haven't found the test case, but I found a commit <https://github.com/llvm/llvm-project/commit/f3f846162a5d6b5b84ed7d146a29dc175542c2c0#diff-587df83aecfc8556d9d21243d748ea1a97b2e13350d79d8b7566521737352040> that increases CharacteristicKind enum's values from 3 to 5. Seems they missed updating DirCharacteristic. Do you have suggestions on where/how to add a test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142304/new/ https://reviews.llvm.org/D142304 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
