luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land.
LGTM but others should also chime in. ================ Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:101 + +struct s5 { struct empty e[1]; float f; }; + ---------------- Should we also test a case with an array size 0 like `ct s { struct empty e[0]; float f; };`? I think that's a GNU extension and I don't expect the result to be different but... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142326/new/ https://reviews.llvm.org/D142326 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits