hokein added a comment.

In D142092#4068792 <https://reviews.llvm.org/D142092#4068792>, @VitaNuo wrote:

> Added the re-generated symbol maps to this patch as per @hokein's request.

Sorry for not being cleared. My suggestion was to generate the maps on the old 
data (2018-10-28), the reason is that we can see the diffs caused by the change 
of the python script, it would make the review easier. We plan to update the 
symbol mappings to latest version, I think we should do it in a followup patch.



================
Comment at: clang/tools/include-mapping/gen_std.py:17
 Caveats and FIXMEs:
-  - only symbols directly in "std" namespace are added, we should also add 
std's
-    subnamespace symbols (e.g. chrono).
-  - symbols with multiple variants or defined in multiple headers aren't added,
-    e.g. std::move, std::swap
+  - symbols with multiple variants aren't added, e.g., std::move, std::swap
 
----------------
nit: `std::swap` doesn't have variants, it is provided by multiple headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142092/new/

https://reviews.llvm.org/D142092

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to