aaron.ballman added a comment.

You also need to add the new matcher to Registry.cpp so it's usable from the 
dynamic matchers, and you should add a release note for the new matcher.

Are you planning to use this matcher in-tree for something? (We don't usually 
add new matchers until there's a need for them given how expensive AST matchers 
are on compile times.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141925/new/

https://reviews.llvm.org/D141925

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to