aaron.ballman added a comment. In D141925#4073405 <https://reviews.llvm.org/D141925#4073405>, @courbet wrote:
> In D141925#4073385 <https://reviews.llvm.org/D141925#4073385>, @aaron.ballman > wrote: > >> You also need to add the new matcher to Registry.cpp so it's usable from the >> dynamic matchers, and you should add a release note for the new matcher. > > Thanks, will do. > >> (We don't usually add new matchers until there's a need for them given how >> expensive AST matchers are on compile times.) > > Ah, that's too bad. > >> Are you planning to use this matcher in-tree for something? > > I was going to use it out-of-tree but figured it's a nice thing to have as > many matchers as possible available for common use. There's also always the > use case of people using clang-query (typically through godbolt). > > I can live with the matcher being out-of-tree though, so you decide :) I'd say let's leave it off for now -- if we find an in-tree need at some point, we can definitely add it then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141925/new/ https://reviews.llvm.org/D141925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
