[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. In D60728#1468713 , @krytarowski wrote: > In D60728#1468486 , @hans wrote: > > > What's the value in checking in th

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

mgorny updated this revision to Diff 195518. mgorny added a comment. Updated per request. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60728/new/ https://reviews.llvm.org/D60728 Files: clang/test/Sema/pr41027.c Index: clang/test/Sema/pr41027.c =

[PATCH] D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc.

sammccall updated this revision to Diff 195519. sammccall marked 3 inline comments as done. sammccall added a comment. address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60316/new/ https://reviews.llvm.org/D60316 Files: clangd/

[PATCH] D60719: Demonstrate how to fix freestanding for memcpy

courbet added a comment. As discussed offline, I think this should go through an RFC process. I guess the main reservation that people will have is that this might generate a very large number of load stores (because we don't have a good way to generate loops here). This is not an issue for X86

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan updated this revision to Diff 195520. ebevhan edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCast.cpp li

[PATCH] D60775: [libclang] Expose ext_vector_type

This revision was automatically updated to reflect the committed changes. Closed by commit rL358566: [libclang] Expose ext_vector_type (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

r358566 - [libclang] Expose ext_vector_type

Author: svenvh Date: Wed Apr 17 02:08:50 2019 New Revision: 358566 URL: http://llvm.org/viewvc/llvm-project?rev=358566&view=rev Log: [libclang] Expose ext_vector_type Differential Revision: https://reviews.llvm.org/D60775 Modified: cfe/trunk/bindings/python/clang/cindex.py cfe/trunk/incl

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall updated this revision to Diff 195522. sammccall marked an inline comment as done. sammccall added a comment. Herald added a subscriber: dexonsmith. Rebase to head and expand scope a bit: - now also setting code for clang-tidy checks - to enable this to be used from the C++ API, the stri

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall marked an inline comment as done. sammccall added a comment. In D58291#1400569 , @kadircet wrote: > LG but is this information really useful to users? According to LSP `The > diagnostic's code, which might appear in the user interface.`, I think

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

kadircet accepted this revision. kadircet added a comment. In D58291#1469880 , @sammccall wrote: > It's a good question, it depends how this is surfaced, and we may want to > tweak the behavior or suppress entirely in some cases. > I think at least some

r358570 - clang-cl: Parse /openmp:experimental

Author: hans Date: Wed Apr 17 03:05:58 2019 New Revision: 358570 URL: http://llvm.org/viewvc/llvm-project?rev=358570&view=rev Log: clang-cl: Parse /openmp:experimental It was added to the MS docs recently here: https://github.com/MicrosoftDocs/cpp-docs/commit/3951085ab722fbb488ca40864f4a0553f7b71

[PATCH] D60719: Demonstrate how to fix freestanding for memcpy

t.p.northover added a comment. I think it'd be pretty unpopular with the people I know who use freestanding. They're mostly working on microcontrollers and compiling -Oz so the extra code size would be untenable; they also have memcpy implementations anyway because they use it in their own code

[PATCH] D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358571: [clangd] Include insertion: require header guards, drop other heuristics, treat… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[clang-tools-extra] r358571 - [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc.

Author: sammccall Date: Wed Apr 17 03:36:02 2019 New Revision: 358571 URL: http://llvm.org/viewvc/llvm-project?rev=358571&view=rev Log: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc. Summary: We do have some reports of include insertion behaving b

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Typically used with umbrella headers, e.g. GTK: #if !defined (__GTK_H_INSIDE__) && !defined (GTK_COMPILA

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall updated this revision to Diff 195533. sammccall added a comment. unconfusing my git repo Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60815/new/ https://reviews.llvm.org/D60815 Files: clangd/index/SymbolCollector.cpp clangd/index/Sym

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall updated this revision to Diff 195534. sammccall marked an inline comment as done. sammccall added a comment. remove leftover debugging Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60815/new/ https://reviews.llvm.org/D60815 Files: clang

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:602 +/// Returns None if includes should not be inserted for this file. +llvm::Optional +SymbolCollector::getIncludeHeader(llvm::StringRef QName, FileID FID)

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia added a comment. In D60455#1469150 , @aaron.ballman wrote: > In D60455#1468714 , @bader wrote: > > > In D60455#1468386 , @Fznamznon > > wrote: > > > > > > Ok, my

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia added a comment. In D60455#1468386 , @Fznamznon wrote: > In D60455#1467018 , @Anastasia wrote: > > > Just to understand how this will work. I would imagine you can have a > > device function definition pr

[clang-tools-extra] r358575 - [clangd] Include textual diagnostic ID as Diagnostic.code.

Author: sammccall Date: Wed Apr 17 05:35:16 2019 New Revision: 358575 URL: http://llvm.org/viewvc/llvm-project?rev=358575&view=rev Log: [clangd] Include textual diagnostic ID as Diagnostic.code. Reviewers: kadircet Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, jdoerfert, cfe-c

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

sammccall added a comment. In D58291#1469917 , @kadircet wrote: > In D58291#1469880 , @sammccall wrote: > > > It's a good question, it depends how this is surfaced, and we may want to > > tweak the behavior or supp

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358575: [clangd] Include textual diagnostic ID as Diagnostic.code. (authored by sammccall, committed by ). Changed prio

[PATCH] D60818: [CUDA][Windows] restrict long double functions declarations to Windows

emankov created this revision. emankov added a reviewer: tra. emankov added a project: clang. Herald added a subscriber: cfe-commits. As agreed in D60220 , make `long double` declarations unobservable on non-windows platforms. Repository: rC Clang https://reviews.l

[PATCH] D60819: [clangd] Strip the ' [some-check-name]' suffix from clang-tidy diagnostics. The check name is reported in Diagnostic.code.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D60819 Files: clangd/Diagnostics.cpp

[clang-tools-extra] r358576 - [clang-tidy] Add fix descriptions to clang-tidy checks.

Author: hokein Date: Wed Apr 17 05:53:59 2019 New Revision: 358576 URL: http://llvm.org/viewvc/llvm-project?rev=358576&view=rev Log: [clang-tidy] Add fix descriptions to clang-tidy checks. Summary: Motivation/Context: in the code review system integrating with clang-tidy, clang-tidy doesn't provi

r358576 - [clang-tidy] Add fix descriptions to clang-tidy checks.

Author: hokein Date: Wed Apr 17 05:53:59 2019 New Revision: 358576 URL: http://llvm.org/viewvc/llvm-project?rev=358576&view=rev Log: [clang-tidy] Add fix descriptions to clang-tidy checks. Summary: Motivation/Context: in the code review system integrating with clang-tidy, clang-tidy doesn't provi

[PATCH] D60719: Demonstrate how to fix freestanding for memcpy

gchatelet added a comment. In D60719#1469958 , @t.p.northover wrote: > I think it'd be pretty unpopular with the people I know who use freestanding. > They're mostly working on microcontrollers and compiling -Oz so the extra > code size would be untenab

[PATCH] D59932: [clang-tidy] Add fix descriptions to clang-tidy checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358576: [clang-tidy] Add fix descriptions to clang-tidy checks. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D59932?vs=194817&id=195550#toc Repository: rC Cl

[PATCH] D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro

MyDeveloperDay added a comment. @klimek one possible solution to this might be to replace the "keyword" back to an identifier in a '#define ' scenario Maybe something like this? bool FormatTokenLexer::tryConvertKeyWordDefines() { // ensure #define keyword x = tok::hash,tok::identifier,to

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

fhahn added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60516/new/ https://reviews.llvm.org/D60516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

Anastasia added a comment. In D60778#1468825 , @lebedev.ri wrote: > > Not sure how to test this though? I guess we can trust that std::map is > > always sorted just as it says in its description. > > You could add a test that contains several entries in `

[PATCH] D60821: [clangd] Emit better error messages when rename fails.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Currently we emit an unfriendly "clang diagnostic" message when rename fails. This patch makes clangd to emit a

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno added subscribers: aaron.ballman, rsmith. riccibruno added a comment. @rsmith @aaron.ballman Do you have any opinion on whether the ADL rules from CWG 997 should be implemented ? The issue here as I understand it is that these rules expand ADL, but no one apart from GCC implement them

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

lebedev.ri added a comment. In D60778#1470152 , @Anastasia wrote: > In D60778#1468825 , @lebedev.ri > wrote: > > > > Not sure how to test this though? I guess we can trust that std::map is > > > always sorted just

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. - for warnings, use "foo" if the warning is controlled by -Wfoo - for errors, keep using the internal nam

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

riccibruno added a comment. Mmm. I hope I am not missing something obvious, but how is this actually fixing the issue ? I don't see why the order between the `Type *` and between the `Decl *` should be deterministic (I think they will be when they are part of the same slab in the allocator, but

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

lebedev.ri added a comment. In D60778#1470181 , @riccibruno wrote: > Mmm. I hope I am not missing something obvious, but how is this actually > fixing the issue ? I don't see why the order between the `Type *` and between > the `Decl *` should be determi

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/index/SymbolCollector.cpp:631 + +bool SymbolCollector::isSelfContainedHeader(FileID FID) { + // The real computation (which will be memoized). --

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

riccibruno added a comment. Maybe, but is there an equivalent to `getTypeID` for declarations ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60778/new/ https://reviews.llvm.org/D60778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall updated this revision to Diff 195562. sammccall added a comment. DontIncludeMePattern Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60815/new/ https://reviews.llvm.org/D60815 Files: clangd/index/SymbolCollector.cpp clangd/index/Symbol

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. I agree that these are more useful. What about also adding "-W" in front of warning flags to make them more explicit and stand out from "non-flag" error names? Repository: rCTE Clang T

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:631 + +bool SymbolCollector::isSelfContainedHeader(FileID FID) { + // The real computation (which will be memoized). ioeric wrote: > sammcca

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:631 + +bool SymbolCollector::isSelfContainedHeader(FileID FID) { + // The real computation (which will be memoized). sammccall wrote: > ioeric wrote: > > sammccall wrote: > > > this has b

[PATCH] D60819: [clangd] Strip the ' [some-check-name]' suffix from clang-tidy diagnostics. The check name is reported in Diagnostic.code.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, we might need to make sure clients that do not show "code" field become aware of this before LLVM9 releases Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:/

[PATCH] D58033: Add option for emitting dbg info for call sites

djtodoro marked 2 inline comments as done. djtodoro added a comment. @probinson @aprantl Thanks a lot for your comments! Let's clarify some things. I'm sorry about the confusion. Initial patch for the functionality can be restricted by this option (like we pushed here), since **LLDB** doesn't r

[PATCH] D60826: Clarify -Winfinite-recursion message

kuhnel created this revision. kuhnel added a reviewer: meikeb. Herald added a project: clang. Test review from the tutorial Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60826 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/SemaCXX/warn-infinite-recursi

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 195568. djtodoro retitled this revision from "Add option for emitting dbg info for call sites" to "Add option for emitting dbg info for call site parameters". djtodoro added a comment. -Refactor -Remove `CC1` def CHANGES SINCE LAST ACTION https://reviews

[PATCH] D58043: Add experimental options for call site related dbg info

djtodoro updated this revision to Diff 195569. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58043/new/ https://reviews.llvm.org/D58043 Files: lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp ==

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 195571. djtodoro added a comment. -Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/Options.td lib/CodeGen/CGDebugInfo.cp

[PATCH] D60827: [rename] Deduplicate symbol occurrences

hokein created this revision. hokein added reviewers: arphaman, kadircet. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. SymbolOccurrences is not guaranteed to be unique -- as some parts of the AST may get traversed twice, we may add duplicated occurrences, we should

r358582 - Explicitly say we don't define new/delete in libc++ during Apple stage1 bootstrap

Author: ldionne Date: Wed Apr 17 07:58:59 2019 New Revision: 358582 URL: http://llvm.org/viewvc/llvm-project?rev=358582&view=rev Log: Explicitly say we don't define new/delete in libc++ during Apple stage1 bootstrap This is not necessary in stage2 because we don't even build libc++.dylib there.

[PATCH] D58043: Add experimental options for call site related dbg info

djtodoro updated this revision to Diff 195572. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58043/new/ https://reviews.llvm.org/D58043 Files: lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp ==

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

keryell added a comment. It would be better to rename `clang/test/SemaSYCL/device-attrubutes.cpp` to `clang/test/SemaSYCL/device-attributes.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 __

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. In D60455#1470318 , @keryell wrote: > It would be better to rename `clang/test/SemaSYCL/device-attrubutes.cpp` to > `clang/test/SemaSYCL/device-attributes.cpp` It's already renamed in the latest patch. Repository: rG LLVM

[PATCH] D59744: Fix i386 ABI "__m64" type bug

RKSimon added a comment. One last style comment from me but we need somebody better with the different ABIs to finally approve this. Comment at: lib/CodeGen/TargetInfo.cpp:1416 + return ABIArgInfo::getDirect(llvm::Type::getX86_MMXTy(getVMContext())); +} +

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28 CheckFactories.registerCheck("llvm-include-order"); +CheckFactories.registerCheck( +"llvm-prefer-isa-or-dyn-cast-in-c

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

dnsampaio created this revision. dnsampaio added reviewers: ostannard, DavidSpickett. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. This patch adds the fp16fml feature parser as well fixes the FPU and the HW_FP flags when +fullfp16 and +dotprod

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda updated this revision to Diff 195581. hintonda added a comment. - Remove clang module check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

Anastasia added a comment. In D60778#1470188 , @riccibruno wrote: > Maybe, but is there an equivalent to `getTypeID` for declarations ? `getDeclID` is used in the first patch... although now I am thinking may be original patch is a better approach? CH

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia added a comment. > > >> I think what we are missing currently is a thorough analysis/comparison >> between SYCL device mode and OpenCL kernel language mode to understand >> what's the best implementation strategy. That would apply to many other >> features: kernel function restric

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda marked 2 inline comments as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:381 + # Don't allow 'clang' or 'llvm' namespaces + if module == 'llvm' or module == 'clang': +namespace = module + '_check'

[clang-tools-extra] r358589 - [clang-tidy] Fix invalid location in readability-misleading-indentation diagnostic

Author: alexfh Date: Wed Apr 17 09:19:47 2019 New Revision: 358589 URL: http://llvm.org/viewvc/llvm-project?rev=358589&view=rev Log: [clang-tidy] Fix invalid location in readability-misleading-indentation diagnostic Before this patch readability-misleading-indentation could issue diagnostics wit

r358590 - Remove --show-includes flag in crash reduce script

Author: akhuang Date: Wed Apr 17 09:20:56 2019 New Revision: 358590 URL: http://llvm.org/viewvc/llvm-project?rev=358590&view=rev Log: Remove --show-includes flag in crash reduce script Modified: cfe/trunk/utils/creduce-clang-crash.py Modified: cfe/trunk/utils/creduce-clang-crash.py URL: htt

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

ostannard added a reviewer: simon_tatham. ostannard added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:443 HasLegalHalfType = true; + HW_FP |= HW_FP_SP | HW_FP_DP | HW_FP_HP; + FPU |= VFP4FPU; Is it always correct to set HW_FP_DP here,

[PATCH] D60818: [CUDA][Windows] restrict long double device functions declarations to Windows

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Thank you for cleaning this up. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60818/new/ https://reviews.llvm.org/D60818 ___

r358595 - [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.

Author: abataev Date: Wed Apr 17 09:53:08 2019 New Revision: 358595 URL: http://llvm.org/viewvc/llvm-project?rev=358595&view=rev Log: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode. All target-parallel-based constructs can be run in SPMD mode from now on. Even if num_threads c

[PATCH] D58236: Make address space conversions a bit stricter.

rjmccall accepted this revision. rjmccall added a comment. Alright, this seems reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak updated this revision to Diff 195589. ahatanak marked 2 inline comments as done. ahatanak added a comment. Remove a potentially expensive check. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736 Files: include/cl

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2580 +if (const BlockDecl *BD = CurContext->getInnerMostBlockDecl()) + if (!getDiagnostics().isIgnored(diag::warn_implicitly_retains_self, Loc)) +ImplicitlyRetainedSelfLocs.push_back({

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

Anastasia added a comment. In D60778#1470176 , @lebedev.ri wrote: > In D60778#1470152 , @Anastasia wrote: > > > In D60778#1468825 , @lebedev.ri > > wrote: > > > > > > Not su

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

sbenza added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:45 + /// Evaluates this part to a string and appends it to `result`. + virtual llvm::Error eval(const ast_matchers::MatchFinder::MatchResult &Match, + std::stri

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

keryell added a comment. In D60455#1470030 , @Anastasia wrote: > > I am not sure we need to add a keyword actually, the attribute can just be > added in AST since it's not supposed to be used in the source code? The attribute is used by the SYCL head

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

ostannard edited reviewers, added: ostannard; removed: olista01. ostannard added a comment. For the auto-upgrader, these limited FPUs only exist for microcontrollers, where I doubt any users are keeping bitcode files around for a long time, so I'd be fine with not doing this. I've had a skim thr

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

hans added a comment. I don't really know about the functionality here, just adding a few comments on the code itself. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966 + QualType PointeeTy = D.getTypePtr()->getPointeeType(); + llvm::DIType *DI = getOrCreateType(PointeeTy,

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

rjmccall added inline comments. Comment at: include/clang/AST/DeclBase.h:1798 + /// innermost enclosing BlockDecl or null if there are no enclosing blocks. + const BlockDecl *getInnerMostBlockDecl() const { +const DeclContext *Ctx = this; "innermost" is one

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

dmgreen added a comment. I don't think we here care about auto-updating, not supporting bitcode/lto libraries. Comment at: llvm/lib/Target/ARM/ARMFastISel.cpp:1362 + if (Ty->isDoubleTy() && (!Subtarget->hasVFP2Base() || !Subtarget->hasFP64())) + return false; --

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

tejohnson added a comment. LGTM with a minor fix needed below. Darwin still uses the old LTO API, which is why the lto Config based handling in the new LTO API (LTO.h/LTO.cpp) are not being used on this path. Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:101 +"lto-stats-f

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

krytarowski added a comment. In D60728#1469794 , @hans wrote: > In D60728#1468713 , @krytarowski > wrote: > > > In D60728#1468486 , @hans wrote: > > > > > What's the value i

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM with one additional small comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60516/new/ https://reviews.llvm.org/D60516 __

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

steven_wu added a comment. forgot to save the inline comments. Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:601 // If statistics were requested, print them out after codegen. - if (llvm::AreStatisticsEnabled()) + if (llvm::AreStatisticsEnabled() && !StatsFile) llvm::

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak updated this revision to Diff 195601. ahatanak marked an inline comment as done. ahatanak added a comment. Rename function. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736 Files: include/clang/AST/DeclBase.h

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1469186 , @jdenny wrote: > Is there anything I can do to help this patch make progress? I think it's ready to land. I was just waiting if anyone else wants to chime in, but it doesn't seem like. I was also thinking abo

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

jordan_rose added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, aaron.ballman wrote: > stephanemoore wrote: > > aaron.ballma

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, jordan_rose wrote: > aaron.ballman wrote: > > stephanemoor

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 195602. ymandel marked 9 inline comments as done. ymandel added a comment. Responded to comments, including changing call operator to return Expected instead of string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

erik.pilkington added inline comments. Comment at: lib/Parse/ParseObjc.cpp:3696-3699 + + Actions.ActOnEndOfObjCMethodDef(); + // Clean up the remaining EOF token. Any reason not to do this check in `ActOnFinishFunctionBody` (which is called by ParseFunctionS

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:127 + // Allow Stencils to operate as std::function, for compatibility with + // Transformer's TextGenerator. Calls `eval()` and asserts on failure. + std::string operator()(const ast_

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

jordan_rose added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, aaron.ballman wrote: > jordan_rose wrote: > > aaron.ballman

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, jordan_rose wrote: > aaron.ballman wrote: > > jordan_rose

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

jordan_rose added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, aaron.ballman wrote: > jordan_rose wrote: > > aaron.ballman

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, jordan_rose wrote: > aaron.ballman wrote: > > jordan_rose

[clang-tools-extra] r358605 - [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

Author: sammccall Date: Wed Apr 17 11:33:07 2019 New Revision: 358605 URL: http://llvm.org/viewvc/llvm-project?rev=358605&view=rev Log: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion. Summary: Typically used with umbrella headers, e.g. GTK: #if !defined

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358605: [clangd] Recognize "don't include me directly" pattern, and suppress include… (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D60815?vs=195562&id=195

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 195606. ymandel added a comment. Convert template specialization to overload sets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files: clang/include/clang/Tooling/

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Tooling/Refactoring/Stencil.cpp:78 + +template <> bool isEqualData(const RawTextData &A, const RawTextData &B) { + return A.Text == B.Text; ymandel wrote: > sbenza wro

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195608. gtbercea marked an inline comment as done. gtbercea added a comment. - Add support for declare target routines. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195609. gtbercea marked an inline comment as done. gtbercea added a comment. - Update error message. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRunt

[PATCH] D60719: Demonstrate how to fix freestanding for memcpy

t.p.northover added a comment. > IIUC freestanding environment should not rely on memcpy being present so my > take on it was that by "fixing" freestanding I could have my cake and eat it > too. The formal situation is that freestanding implementations are only required to provide language sup

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8975 +CGM.Error(Clause->getBeginLoc(), + "Target region emitted before requires directive."); + HasRequiresUnifiedSharedMemory = tr

  1   2   >