ymandel marked an inline comment as done.
ymandel added inline comments.
================
Comment at: clang/lib/Tooling/Refactoring/Stencil.cpp:78
+
+template <> bool isEqualData(const RawTextData &A, const RawTextData &B) {
+ return A.Text == B.Text;
----------------
ymandel wrote:
> sbenza wrote:
> > Any particular reason to use function template specialization instead of
> > function overloading?
> > The former is rare and thus harder to reason about.
> >
> > (same for `evalData` below)
> Stylistic -- it forces you to explicitly declare the "overload set" so to
> speak. However, i'm not particularly attached -- if you think this a bad
> idea given its rarity, I'm happy to use overload sets. WDYT?
Converted to normal overload sets (as per off-thread chat).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59371/new/
https://reviews.llvm.org/D59371
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
