tejohnson added a comment.

LGTM with a minor fix needed below.

Darwin still uses the old LTO API, which is why the lto Config based handling 
in the new LTO API (LTO.h/LTO.cpp) are not being used on this path.



================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:101
+    "lto-stats-file",
+    cl::desc("With PGO, include profile count in optimization remarks"),
+    cl::Hidden);
----------------
Wrong description for this option


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60516/new/

https://reviews.llvm.org/D60516



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to