lebedev.ri added a comment.

In D60778#1470181 <https://reviews.llvm.org/D60778#1470181>, @riccibruno wrote:

> Mmm. I hope I am not missing something obvious, but how is this actually 
> fixing the issue ? I don't see why the order between the `Type *` and between 
> the `Decl *` should be deterministic (I think they will be when they are part 
> of the same slab in the allocator, but I don't see why the slab ordering 
> should be stable).


Oh. Duh.
Can a custom comparator be provided for these `std::map`, equivalent to the one 
in https://reviews.llvm.org/D60379 ?
Something like `getTypeID(LHS.first->getCanonicalTypeInternal()) < 
getTypeID(RHS.first->getCanonicalTypeInternal())` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60778/new/

https://reviews.llvm.org/D60778



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to