hintonda marked 2 inline comments as done. hintonda added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/add_new_check.py:381 + # Don't allow 'clang' or 'llvm' namespaces + if module == 'llvm' or module == 'clang': + namespace = module + '_check' ---------------- alexfh wrote: > We don't have the `clang` module. No need to check for it here. If we ever > add one (which I doubt), we can modify this script again. But for now let's > remove this to avoid confusion. No problem. Or we could outlaw it... ================ Comment at: clang-tools-extra/clang-tidy/rename_check.py:268 + if old_module != new_module or new_module == 'llvm' or new_module == 'clang': + if new_module == 'llvm' or new_module -- 'clang': + new_namespace = new_module + '_check' ---------------- alexfh wrote: > `--`? > > Anyways, we don't have (or plan to have) a module named `clang`. Thanks for catching that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
