hintonda marked an inline comment as done. hintonda added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28 CheckFactories.registerCheck<IncludeOrderCheck>("llvm-include-order"); + CheckFactories.registerCheck<PreferIsaOrDynCastInConditionalsCheck>( + "llvm-prefer-isa-or-dyn-cast-in-conditionals"); CheckFactories.registerCheck<readability::NamespaceCommentCheck>( ---------------- hintonda wrote: > aaron.ballman wrote: > > hintonda wrote: > > > aaron.ballman wrote: > > > > Please keep this list sorted alphabetically. > > > I think this is where add_new_check.py put it, but I'll alphabetize. > > Huh, I thought that script kept everything alphabetized? That may be worth > > investigating (don't feel obligated though). > I'm sure it's something I did inadvertently, but can't really remember the > details. Looks like rename_check.py definitely does not alphabetize. I'll try to address than in another patch. Thanks for pointing this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits