hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
In D60728#1468713 <https://reviews.llvm.org/D60728#1468713>, @krytarowski wrote: > In D60728#1468486 <https://reviews.llvm.org/D60728#1468486>, @hans wrote: > > > What's the value in checking in this xfail'ed test without an actual fix > > for the problem? > > > Raise awareness about the problem. I don't think that works. No one is reading through the test files of the repository. In D60728#1468868 <https://reviews.llvm.org/D60728#1468868>, @mgorny wrote: > 1. It may help whoever tries to address it in the future, to have a > known-good reproducer. The usual way to do this is to post it on the bug tracker, which was already done. > 2. If someone addresses this independently and doesn't notice the bug, it > will help us get informed that the issue was fixed. Fair enough, that seems somewhat useful :-) ================ Comment at: clang/test/Sema/pr41027.c:1 +// XFAIL: * +// RUN: %clang_cc1 -triple x86_64 -fsyntax-only %s ---------------- nit: the XFAIL usually comes after the RUN line, and there's usually an empty line between these lines and the other contents of the file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60728/new/ https://reviews.llvm.org/D60728 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
