On Mon, 14 Apr 2025 06:26:10 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minors
>
> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 149:
>
&g
On Fri, 11 Apr 2025 04:07:45 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> enable more test
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2173:
>
>&g
0.57 | 118.639 | 119.373 | 0.451 | ns/op |
> 1.002
> o.o.b.vm.compiler.IfMinMax.testVectorInt | avgt | 40 | 60130.165 | 60062.303
> | 61839.776 | 61895.194 | 15887.398 | 15924.502 | 15874.835 | 15667.936 |
> 101.94 | ns/op | 3.785
> o.o.b.vm.compiler.IfMinMax.testV
0.57 | 118.639 | 119.373 | 0.451 | ns/op |
> 1.002
> o.o.b.vm.compiler.IfMinMax.testVectorInt | avgt | 40 | 60130.165 | 60062.303
> | 61839.776 | 61895.194 | 15887.398 | 15924.502 | 15874.835 | 15667.936 |
> 101.94 | ns/op | 3.785
> o.o.b.vm.compiler.IfMinMax.testV
0.57 | 118.639 | 119.373 | 0.451 | ns/op |
> 1.002
> o.o.b.vm.compiler.IfMinMax.testVectorInt | avgt | 40 | 60130.165 | 60062.303
> | 61839.776 | 61895.194 | 15887.398 | 15924.502 | 15874.835 | 15667.936 |
> 101.94 | ns/op | 3.785
> o.o.b.vm.compiler.IfMinMax.testVectorLong
0.57 | 118.639 | 119.373 | 0.451 | ns/op |
> 1.002
> o.o.b.vm.compiler.IfMinMax.testVectorInt | avgt | 40 | 60130.165 | 60062.303
> | 61839.776 | 61895.194 | 15887.398 | 15924.502 | 15874.835 | 15667.936 |
> 101.94 | ns/op | 3.785
> o.o.b.vm.compiler.IfMinMax.testVectorLong | av
0.57 | 118.639 | 119.373 | 0.451 | ns/op |
> 1.002
> o.o.b.vm.compiler.IfMinMax.testVectorInt | avgt | 40 | 60130.165 | 60062.303
> | 61839.776 | 61895.194 | 15887.398 | 15924.502 | 15874.835 | 15667.936 |
> 101.94 | ns/op | 3.785
> o.o.b.vm.compiler.IfMinMax.testVectorLong | avgt |
On Wed, 9 Apr 2025 06:52:26 GMT, Fei Yang wrote:
>> This is to not enable Zicond automatically, but user can still turn it on
>> manually if they want to try or make sure it bring benefit on the specific
>> hardware.
>> Currently it's based on bananapi result, so maybe in the future we should
0.57 | 118.639 | 119.373 | 0.451 | ns/op |
> 1.002
> o.o.b.vm.compiler.IfMinMax.testVectorInt | avgt | 40 | 60130.165 | 60062.303
> | 61839.776 | 61895.194 | 15887.398 | 15924.502 | 15874.835 | 15667.936 |
> 101.94 | ns/op | 3.785
> o.o.b.vm.compiler.IfMinMax.testVectorLong | avgt |
On Wed, 9 Apr 2025 06:41:51 GMT, Fei Yang wrote:
> Sorry for not being clear enough. I am suggesting this:
if (UseZicond) {
FLAG_SET_DEFAULT(ConditionalMoveLimit, 3);
}
I think this depends on whether we should enable ConditionalMoveLimit based on
`UseZicond`? So, I'll leave it until
0.57 | 118.639 | 119.373 | 0.451 | ns/op |
> 1.002
> o.o.b.vm.compiler.IfMinMax.testVectorInt | avgt | 40 | 60130.165 | 60062.303
> | 61839.776 | 61895.194 | 15887.398 | 15924.502 | 15874.835 | 15667.936 |
> 101.94 | ns/op | 3.785
> o.o.b.vm.compiler.IfMinMax.testVectorLong |
On Tue, 8 Apr 2025 15:02:27 GMT, Feilong Jiang wrote:
>> Hamlin Li has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2.
On Tue, 8 Apr 2025 07:07:12 GMT, Fei Yang wrote:
> Maybe we should check UseZicond and only enable UseCMoveUnconditionally &
> ConditionalMoveLimit conditionally?
Not sure what do you mean here.
> I don't see how enabling CMove will bring us any performance benefit without
> Zicond. It's done
Hi,
Can you help to review this patch?
On riscv, CMoveI/L already were implemented, but there are some gap:
1. CMoveI/L does not support comparison with float/double, corresponding tests
are not turn on either.
2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`.
3. lack of
On Thu, 27 Mar 2025 14:32:18 GMT, Robbin Ehn wrote:
>> Hi, for you to consider.
>>
>> These tests constantly fails in qemu-user.
>> Either the require host to be same arch or they are very very slow in
>> emulation.
>> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not
>> implemen
On Thu, 27 Mar 2025 14:32:18 GMT, Robbin Ehn wrote:
>> Hi, for you to consider.
>>
>> These tests constantly fails in qemu-user.
>> Either the require host to be same arch or they are very very slow in
>> emulation.
>> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not
>> implemen
>const_oop() == nullptr) {
>>
>> Hi, this is not a review comment.
>> Just curious, to continue the following code path why does `box_type` must
>> have a valid `const_oop`?
>
> @Hamlin-Li , Class types are passed as constant oop, this check is added for
> argum
On Fri, 17 Jan 2025 16:02:55 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Fri, 17 Jan 2025 16:02:55 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Tue, 7 Jan 2025 13:07:03 GMT, Robbin Ehn wrote:
>> Hi please consider.
>>
>> This adds below to hs_err:
>>
>> Floating point state:
>> fcsr=1
>> Floating point registers:
>> f0=0x44a72000 | 1.84467e+19
>> f1=0x44a72000 | 1.84467e+19
>>
>> f31=0x44a72000 | 1.84467
On Fri, 20 Dec 2024 11:17:54 GMT, Robbin Ehn wrote:
> Hi please consider.
>
> This adds below to hs_err:
>
> Floating point state:
> fcsr=1
> Floating point registers:
> f0=0x44a72000 | 1.84467e+19
> f1=0x44a72000 | 1.84467e+19
>
> f31=0x44a72000 | 1.84467e+19
>
>
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 21:02:03 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 21:02:03 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 21:02:03 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 14 Oct 2024 14:57:46 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review the patch? Previously it's
> https://github.com/openjdk/jdk/pull/18605.
> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>
> Thanks!
>
> ## Test
> ### tests:
&
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>&
On Fri, 1 Nov 2024 11:01:24 GMT, Andrew Haley wrote:
> Here are my results, Apple M1. Pretty similar to what we've seen, but no SVE.
>
> Looks good.
Thank you so much for testing!
-
PR Comment: https://git.openjdk.org/jdk/pull/21502#issuecomment-2454181484
On Thu, 24 Oct 2024 14:05:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 24 Oct 2024 14:05:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote:
>> The old core reflection implementation generates dynamic classes that are
>> special cases in the VM to bypass bytecode verification to workaround
>> various issues [1] [2] [3].
>>
>> The old core reflection implementation was [removed in
P_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions
> -XX:+EnableVectorSupport -XX:+UseVectorStubs'
> * -intrinsic:
> 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions
> -XX:+EnableVectorSupport -XX:-UseVectorStubs'
>
> ### Performan
On Mon, 21 Oct 2024 09:53:16 GMT, Fei Gao wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add missing files
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8207:
>
&
On Wed, 16 Oct 2024 13:42:42 GMT, Roman Kennke wrote:
>> We're seeing failures in our nightly testing for tests
>> runtime/cds/appcds/SharedBaseAddress.java and
>> runtime/cds/SharedBaseAddress.java which I'm tracking in this bug
>> [JDK-8340212](https://bugs.openjdk.org/browse/JDK-8340212)
>>
On Wed, 16 Oct 2024 13:42:42 GMT, Roman Kennke wrote:
>> We're seeing failures in our nightly testing for tests
>> runtime/cds/appcds/SharedBaseAddress.java and
>> runtime/cds/SharedBaseAddress.java which I'm tracking in this bug
>> [JDK-8340212](https://bugs.openjdk.org/browse/JDK-8340212)
>>
P_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions
> -XX:+EnableVectorSupport -XX:+UseVectorStubs'
> * -intrinsic:
> 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions
> -XX:+EnableVectorSupport -XX:-UseVectorStubs'
>
> ### Performan
On Wed, 16 Oct 2024 12:15:51 GMT, Ludovic Henry wrote:
>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8218:
>>
>>> 8216:
>>> 8217: snprintf(ebuf, sizeof(ebuf), "%sdx_%ssve",
>>> VectorSupport::mathname[op], ulf);
>>> 8218:
>>> StubRoutines::_vector_d_math[VectorSupp
On Tue, 15 Oct 2024 11:04:40 GMT, Magnus Ihse Bursie wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make/autoconf/flags-cflags.m4
>>
>> Co-authored-by: Magnus
P_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions
> -XX:+EnableVectorSupport -XX:+UseVectorStubs'
> * -intrinsic:
> 'FORK=1;ITER=10;WARMUP_ITER=10;JAVA_OPTIONS=-XX:+UnlockExperimentalVMOptions
> -XX:+EnableVectorSupport -XX:-UseVectorStubs'
>
> ### Performan
On Thu, 19 Sep 2024 15:01:26 GMT, Hamlin Li wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'lilliput/JEP-450-temporary-fix-branch-2'
>> i
On Thu, 19 Sep 2024 15:01:26 GMT, Hamlin Li wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'lilliput/JEP-450-temporary-fix-branch-2'
>> i
Hi,
Can you help to review the patch? Previously it's
https://github.com/openjdk/jdk/pull/18605.
This pr is based on https://github.com/openjdk/jdk/pull/20781.
Thanks!
## Test
### tests:
* test/jdk/jdk/incubator/vector/
* test/hotspot/jtreg/compiler/vectorapi/
### options:
* -XX:UseSVE=1 -XX:+E
On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
> * NOTE: This p
On Fri, 11 Oct 2024 07:57:48 GMT, SendaoYan wrote:
>> Hi all,
>> The file
>> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c`
>> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880)
>> native build fails by fedora OS shipped gcc13.
>> Gcc13 doesn't hav
On Fri, 11 Oct 2024 04:02:53 GMT, SendaoYan wrote:
>> Hi all,
>> The file
>> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c`
>> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880)
>> native build fails by fedora OS shipped gcc13.
>> Gcc13 doesn't hav
On Thu, 10 Oct 2024 14:02:08 GMT, Fei Yang wrote:
> FYI: I see they claim LLVM 17+ from the page:
That's great, then it should be fine to just check the compiler version and
enable `-march=rv64gcv` conditaionally.
-
PR Comment: https://git.openjdk.org/jdk/pull/21442#issuecomment-2
On Thu, 10 Oct 2024 13:15:42 GMT, Fei Yang wrote:
> FYI: I witnessed some different kinds of compile errors about libsleef while
> building with GCC version 13.2.0 (Ubuntu 13.2.0-23ubuntu4) shipped with
> Ubuntu 24.04.1 LTS riscv64. Seems that GCC-13 doesn't have a good support for
> these RVV
On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan wrote:
> Hi all,
> The file
> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c`
> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880)
> native build fails by fedora OS shipped gcc13.
> Gcc13 doesn't have `__r
On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan wrote:
> Hi all,
> The file
> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c`
> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880)
> native build fails by fedora OS shipped gcc13.
> Gcc13 doesn't have `__r
On Tue, 8 Oct 2024 14:56:56 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers
On Tue, 8 Oct 2024 14:56:56 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers
On Thu, 19 Sep 2024 08:32:38 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef
On Tue, 8 Oct 2024 14:46:02 GMT, Magnus Ihse Bursie wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make minor
>
> make/modules/jdk.incubator.vector/Lib.gmk line 53:
>
>> 51
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1
On Mon, 7 Oct 2024 09:50:16 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers
On Tue, 8 Oct 2024 13:40:53 GMT, Hamlin Li wrote:
>> So is the `LIBS` line as well. And the CFLAGS line should be just:
>>
>>CFLAGS := -march=rv64gcv, \
>
> No worries, it's not late. Take care!
Do you suggest something like below?
EX
On Tue, 8 Oct 2024 13:25:17 GMT, Magnus Ihse Bursie wrote:
>> make/modules/jdk.incubator.vector/Lib.gmk line 50:
>>
>>> 48: DISABLED_WARNINGS_clang := unused-function sign-compare
>>> tautological-compare ignored-qualifiers, \
>>> 49: CFLAGS := $(CFLAGS_JDKLIB) -march=rv64gcv, \
>>>
On Mon, 7 Oct 2024 09:16:42 GMT, Ludovic Henry wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> bits > 512
>
> Marked as reviewed by luhenry (Committer).
@luhenry I merged this pr wi
On Mon, 23 Sep 2024 13:12:16 GMT, Erik Joelsson wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> modify cflags style
>
> Build changes look ok.
@erikj79 @RealFYang Hi, can you help to
On Mon, 7 Oct 2024 09:50:16 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1.743
On Tue, 1 Oct 2024 07:01:17 GMT, Ramkumar Sunderbabu
wrote:
>> Cleaning up nsk.share.Log code after the verbose mode was set always true.
>>
>> Tested all the vmTestbase/ tests.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revis
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1
On Mon, 30 Sep 2024 09:01:24 GMT, Ludovic Henry wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test macro
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 2044:
>
>>
On Mon, 30 Sep 2024 08:15:51 GMT, Axel Boldt-Christmas
wrote:
>> [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed
>> the the concept of ICStubs, InlineCache buffers and related safepoints.
>>
>> There are a handfull of references and auxiliary constructs still in the
On Fri, 27 Sep 2024 08:10:35 GMT, Fei Yang wrote:
>> `NDEBUG` is only used in sleefdp.c which is the original sleef code, and we
>> don't use that file in jdk directly, in java.base module of jdk it uses
>> `DEBUG` but not use `NDEBUG`.
>> Based on above information, I think `DEBUG` is better.
On Fri, 27 Sep 2024 02:22:58 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test macro
>
> src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c lin
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1.743
On Thu, 26 Sep 2024 07:54:32 GMT, Hamlin Li wrote:
>> Just a bit worried about the fact that manipunating CSR could be very costly
>> on RISC-V. Another choice would be adding an assertion about FP rounding
>> mode expecting RNE when returning back from the SLEEF routine.
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1.743
On Thu, 26 Sep 2024 02:15:34 GMT, Fei Yang wrote:
>> I see sleef code only set frm to RNE, but I'm not quite sure.
>> Even if we can make sure current sleef only set frm to RNE, seems to me we
>> can not depends on current implement, it could change. Although good news is
>> we don't update sle
On Wed, 25 Sep 2024 14:04:35 GMT, Hamlin Li wrote:
>> src/hotspot/cpu/riscv/riscv.ad line 10079:
>>
>>> 10077: match(CallLeafVector);
>>> 10078:
>>> 10079: effect(USE meth, KILL cr);
>>
>> I haven't checked the details of `CallLe
On Wed, 25 Sep 2024 02:29:11 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use all arg v regs
>
> src/hotspot/cpu/riscv/riscv.ad line 10079:
>
>> 10077: mat
On Tue, 24 Sep 2024 15:12:29 GMT, Fei Yang wrote:
>> Yes, sorry what I meant, updated.
>
> Then why would we put a constraint on the number of supported argument vector
> registers here (v8-v15 instead of v8-v23)? Could we just support all of them,
> i.e., v8-v23 to comply with the RISC-V psABI
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1.743
>
On Tue, 24 Sep 2024 03:47:41 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine comment
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 6063
On Tue, 24 Sep 2024 05:57:08 GMT, Robbin Ehn wrote:
>> src/hotspot/cpu/riscv/riscv.ad line 10078:
>>
>>> 10076: match(CallLeafVector);
>>> 10077:
>>> 10078: effect(USE meth);
>>
>> It's possible for the runtime call to clobber rFlagsReg `cr` (aka `t1`). So
>> safer to add `KILL cr` to the
On Tue, 24 Sep 2024 06:59:58 GMT, Fei Yang wrote:
>> Note in the RISC-V ELF psABI there is a convention variant for v-regs.
>> If you add function attribute riscv_vector_cc it should be used for C/C++.
>> (I never tested it)
>> v0 = first vector mask argument
>> v8-v23 = args/rets
>> v1-v7/v24-v
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/
On Mon, 23 Sep 2024 16:40:55 GMT, Ludovic Henry wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment
>
> src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c line 31:
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1.743
On Mon, 23 Sep 2024 09:09:46 GMT, Ludovic Henry wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> modify cflags style
>
> src/jdk.incubator.vector/linux/native/libsleef/lib/vecto
On Mon, 23 Sep 2024 07:30:59 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inli
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op
On Fri, 20 Sep 2024 12:34:38 GMT, Erik Joelsson wrote:
>> Thanks. I'm sorry too, I'm not familiar with the build system.
>> What you expected could be something like below?
>>
>> diff --git a/make/modules/jdk.incubator.vector/Lib.gmk
>> b/make/modules/jdk.incubator.vector/Lib.gmk
>> index 5e522
| avgt | 10 | 116708.105 | 167.095 | 285764.405
> | 2489.08 | ns/op | 2.449
> Double128Vector.LOG1P | 1024 | avgt | 10 | 115633.302 | 567.7 | 317235.967 |
> 1062.848 | ns/op | 2.743
> Double128Vector.POW | 1024 | avgt | 10 | 321655.14 | 36.55 | 560765.066 |
> 2669.33 | ns/op | 1.743
>
On Thu, 19 Sep 2024 16:02:36 GMT, Erik Joelsson wrote:
>> Thanks, do you mean something like below? I'll fix it.
>>
>> CFLAGS := $(CFLAGS_JDKLIB) $(C_O_FLAG_HI) -march=rv64gcv, \
>
> Sorry, I had to remind myself of how this works. We actually set this as a
> separate parameter on the Setup mac
On Thu, 19 Sep 2024 12:08:46 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 19 Sep 2024 12:08:46 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 19 Sep 2024 12:52:59 GMT, Erik Joelsson wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers). We use
>> sleef api to vecto
On Wed, 18 Sep 2024 13:23:44 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 19 Sep 2024 08:32:38 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef
On Wed, 18 Sep 2024 13:23:44 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
1 - 100 of 548 matches
Mail list logo
