On Wed, 9 Apr 2025 06:52:26 GMT, Fei Yang <fy...@openjdk.org> wrote: >> This is to not enable Zicond automatically, but user can still turn it on >> manually if they want to try or make sure it bring benefit on the specific >> hardware. >> Currently it's based on bananapi result, so maybe in the future we should >> adjust the default value of UseZicond. >> I'm fine with either default value. > > I just witnessed a couple of warnings (`UseZicond is turned off > automatically. Turn it on with -XX:+UseZicond explicitly.`) when doing a > native build on my P550 SBC which is not equipped with `Zicond` extension. I > don't think that is expected? And I agree that it might be better to keep > this option disabled by default and let users decide whether to enable it > based on their cases. But what I see is that `UseZicond` will be auto-enabled > through hwprobe [1] on my BPI-F3. So I am suggesting to not to do that in my > previous comment. Make sense? > > [1] > https://github.com/openjdk/jdk/blob/master/src/hotspot/os_cpu/linux_riscv/riscv_hwprobe.cpp#L228
Fixed. Also adjust the way enable Zicond as we just discussed. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24490#discussion_r2037051448
