On Mon, 23 Sep 2024 16:40:55 GMT, Ludovic Henry <luhe...@openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comment > > src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c line 31: > >> 29: // bridge functions built in the library, otherwise no such fuctions in >> the library. >> 30: // At runtime, if the library is found and bridge fuctions are found in >> the library, >> 31: // then the java vector API will call into bridge functions and sleef, >> otherwise not. > > Suggestion: > > // At compile-time, if the current compiler does support vector intrinsics, > bridge > // functions will be built in the library. In case the current compiler > doesn't support > // vector intrinsics (gcc < 14), then the bridge functions won't be compiled. > // At run-time, if the library is found and the bridge functions are > available in the > // library, then the java vector API will call into the bridge functions and > sleef. Thanks for the suggestion, it's much better! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1771970020
