On Tue, 8 Oct 2024 14:46:02 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> make minor > > make/modules/jdk.incubator.vector/Lib.gmk line 53: > >> 51: DISABLED_WARNINGS_gcc := unused-function sign-compare >> tautological-compare ignored-qualifiers, \ >> 52: DISABLED_WARNINGS_clang := unused-function sign-compare >> tautological-compare ignored-qualifiers, \ >> 53: CFLAGS := -march=rv64gcv \ > > Suggestion: > > CFLAGS := -march=rv64gcv, \ > > > This is strictly not needed here (that was why it worked for you) but we > always include the trailing comma so adding a new line does not need to > modify the one above. I see, thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1792035366
