On Fri, 11 Apr 2025 04:07:45 GMT, Fei Yang <fy...@openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> enable more test > > src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2173: > >> 2171: break; >> 2172: case BoolTest::ge: >> 2173: cmov_cmp_fp_ge(op1, op2, dst, src, is_single); > > This calls `cmov_cmp_fp_ge` and `cmov_cmp_fp_gt` assembler routines for > `BoolTest::ge` and `BoolTest::gt` respectively, but these two assembler > routines are NOT implemented in file macroAssembler_riscv.cpp. That seems a > bit confusing to me. How about making these two cases unreachable in this > function? Or simply implement these two assembler routines? Make sense, I'll remove the unimplemented code and mvoe the check to `enc_cmove_cmp_fp`. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24490#discussion_r2039291255
