On Fri, 11 Oct 2024 07:57:48 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all, >> The file >> `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` >> introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) >> native build fails by fedora OS shipped gcc13. >> Gcc13 doesn't have `__riscv_v_intrinsic` macro by default, and do have >> `__riscv_v_intrinsic` macro with option: `-march=rv64gcv`. libsleef only >> supported from llvm version 17 and gcc version 14 onwards, so we need to >> check the compiler version before use the `__riscv_v_intrinsic`. >> >>  >> >> >> gcc version infomation: >> >> /usr/bin/gcc -v >> Using built-in specs. >> COLLECT_GCC=/usr/bin/gcc >> COLLECT_LTO_WRAPPER=/usr/libexec/gcc/riscv64-redhat-linux/13/lto-wrapper >> Target: riscv64-redhat-linux >> Configured with: ../configure --enable-bootstrap >> --enable-languages=c,c++,fortran,objc,obj-c++,ada,go,d,m2,lto --prefix=/usr >> --mandir=/usr/share/man --infodir=/usr/share/info >> --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared >> --enable-threads=posix --enable-checking=release --enable-multilib >> --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions >> --enable-gnu-unique-object --enable-linker-build-id >> --with-gcc-major-version-only --enable-libstdcxx-backtrace >> --with-libstdcxx-zoneinfo=/usr/share/zoneinfo --with-linker-hash-style=gnu >> --enable-plugin --enable-initfini-array >> --with-isl=/builddir/build/BUILD/gcc-13.2.1-20230728/obj-riscv64-redhat-linux/isl-install >> --enable-gnu-indirect-function --with-arch=rv64gc --with-abi=lp64d >> --with-multilib-list=lp64d --build=riscv64-redhat-linux >> --with-build-config=bootstrap-lto --enable-link-serialization=1 >> Thread model: posix >> Supported LTO compression algorithms: zlib zstd >> gcc version 13.2.1 20230728 (Red Hat 13.2.1-1) (GCC) >> >> >> Additonal testing: >> >> - [x] riscv64 native release debug-level build with gcc13 >> - [x] riscv64 native fastdebug debug-level build with gcc13 >> - [x] riscv64 native release debug-level build with gcc14 >> - [ ] riscv64 native fastdebug debug-level build with gcc14 > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add the tailing blank line and add a commnet for #endif Thanks! ------------- Marked as reviewed by mli (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21442#pullrequestreview-2362199499
