On Tue, 8 Oct 2024 13:40:53 GMT, Hamlin Li <m...@openjdk.org> wrote:
>> So is the `LIBS` line as well. And the CFLAGS line should be just:
>>
>> CFLAGS := -march=rv64gcv, \
>
> No worries, it's not late. Take care!
Do you suggest something like below?
EXTRA_SRC := libsleef/generated, \
DISABLED_WARNINGS_gcc := unused-function sign-compare
tautological-compare ignored-qualifiers, \
DISABLED_WARNINGS_clang := unused-function sign-compare
tautological-compare ignored-qualifiers, \
- CFLAGS := $(CFLAGS_JDKLIB) -march=rv64gcv, \
- LDFLAGS := $(LDFLAGS_JDKLIB) \
- $(call SET_SHARED_LIBRARY_ORIGIN), \
- LIBS := $(JDKLIB_LIBS) \
+ CFLAGS := -march=rv64gcv \
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1791903343
