On Mon, 21 Oct 2024 09:53:16 GMT, Fei Gao <f...@openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add missing files
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8207:
>
>> 8205: for (int op = 0; op < VectorSupport::NUM_VECTOR_OP_MATH; op++) {
>> 8206: int vop = VectorSupport::VECTOR_OP_MATH_START + op;
>> 8207: if (vop == VectorSupport::VECTOR_OP_TANH) {
>
> Could you please add a comment that mentions the reason, for example
> `// Skip "tanh" because there is performance regression`
Sure, will fix it. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21502#discussion_r1810337900
