On Thu, 10 Oct 2024 07:37:43 GMT, SendaoYan <s...@openjdk.org> wrote:
> Hi all, > The file > `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c` > introduced by [JDK-8341880](https://bugs.openjdk.org/browse/JDK-8341880) > native build fails by fedora OS shipped gcc13. > Gcc13 doesn't have `__riscv_v_intrinsic` macro by default, and do have > `__riscv_v_intrinsic` macro with option: `-march=rv64gcv`. So I think the > CFLAGS should not set `-march=rv64gcv`, because gcc13 doesn't have > `riscv_vector.h`. > >  > > > gcc version infomation: > > /usr/bin/gcc -v > Using built-in specs. > COLLECT_GCC=/usr/bin/gcc > COLLECT_LTO_WRAPPER=/usr/libexec/gcc/riscv64-redhat-linux/13/lto-wrapper > Target: riscv64-redhat-linux > Configured with: ../configure --enable-bootstrap > --enable-languages=c,c++,fortran,objc,obj-c++,ada,go,d,m2,lto --prefix=/usr > --mandir=/usr/share/man --infodir=/usr/share/info > --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared > --enable-threads=posix --enable-checking=release --enable-multilib > --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions > --enable-gnu-unique-object --enable-linker-build-id > --with-gcc-major-version-only --enable-libstdcxx-backtrace > --with-libstdcxx-zoneinfo=/usr/share/zoneinfo --with-linker-hash-style=gnu > --enable-plugin --enable-initfini-array > --with-isl=/builddir/build/BUILD/gcc-13.2.1-20230728/obj-riscv64-redhat-linux/isl-install > --enable-gnu-indirect-function --with-arch=rv64gc --with-abi=lp64d > --with-multilib-list=lp64d --build=riscv64-redhat-linux > --with-build-config=bootstrap-lto --enable-link-serialization=1 > Thread model: posix > Supported LTO compression algorithms: zlib zstd > gcc version 13.2.1 20230728 (Red Hat 13.2.1-1) (GCC) > > > Additonal testing: > > - [x] riscv64 native release debug-level build with gcc13 > - [ ] riscv64 native fastdebug debug-level build with gcc13 > - [ ] riscv64 native release debug-level build with gcc14 > - [ ] riscv64 native fastdebug debug-level build with gcc14 Hi, Thanks for catching. Simply remove this line fixes the build issue, but I think it will also disable the optimization introduced by 8320500. What we can do is to test if rvv intrinsic is really supported as we expect, e.g. if "#include <riscv_vector.h>" is right, if it's true then we can still add `-march=rv64gcv` flag, otherwise do not add the flag. Do you mind to construct such a patch? please kindly let me know. Otherwise I can fix the issue. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21442#issuecomment-2404516826
