Re: [U-Boot] Adding support to Technexion TAM3517 SOM
On 24/11/2011 07:57, Tapani Utriainen wrote: > On Wed, 23 Nov 2011 10:26:54 +0100 > Stefano Babic wrote: > > Stefano, > Hi Tapani, > Some comments regarding your u-boot patch for TAM3517/Twister. Thanks - please add always the mailing list as CC, we are currently review the patches, and your review has a big importance. > > First, I like the separation between the module and the baseboard. Adding > new baseboards seems easier this way. Of course, this might add complexity > in a different way, but is preferrable over the alternative. Good. Thanks. > > Second, instead of pointing out "problems" with comments,tabs and spaces in > your patch source code -- I tested it. Nice - this means you have also tested the patches. If you agree, I will add a "Tested-by" signature with your name to the patches. > Using your u-boot.bin on Twister, USB devices do not work in linux. Using > the u-boot.bin I submitted this issue disappears. The setup is otherwise the > same (same x-loader, u-boot settings, kernel and userland). > > This might be due to Ilya's EHCI patch (required to compile your u-boot), > or something not properly setup in the kernel. What do you think? > (Issue is reproducible for instance using the 2.6.32 kernel we have on > our homepage). There are several things here. First, USB is not working at all in the u-boot.bin you submit, due to a lot of different reasons (wrong controller, wrong MUX setup) - this means that your u-boot makes nothing with USB, in any case it does not set up correctly the HW. When Linux starts, it finds the USB controller as after reset, and this is a big difference. The kernel you have relies maybe on some reset values, and this does not happen with my patches because the EHCI controller was already set. The issue you reports means that the kernel does not configure completely the controller when it starts, and some registers maintain the values set by U-Boot, maybe not correct for the kernel driver. I will exclude an error in the setup of the MUX in U-boot, because the USB is working, meaning that the pins are correctly routed. By the way, you are running a very old kernel, are you sure there are not patches for the EHCI OMAP driver in the current kernel tree ? > > The third point is your default settings: they do not allow booting via local > media (SD card or NAND flash). TechNexion's opinion is that the default is > to boot via NAND or SD-card, since very few use network boot. Of course, this behavior can be changed. Please post a proposal, if you have any. In the default settings I put a basic environment, using the same variables that are already used on several boards - I know there is neither standard nor rules for a standard environment in U-Boot, but I find nice if different boards maintain the same behavior, using some quite standard commands to boot from network or from storage. I like to have a "net_nfs" (not important which is the chosen name) on all boards I work with, as well as the same commands to boot from internal storage. Apart of that, I considered that twister is an evaluation board, and the customers like to change the way the system boots. And how the storage (I mean NAND here) is partitioned. We could use partition names as "kernel", "rootfs" to split the NAND. In this way, the boot command still works if the customer rearrange the size of partitions with the mtdparts variable. Of course, this wiorks only if in the kernel the mtdparts variable is parsed (CONFIG_MTD_CMDLINE_PARTS must be set). Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] MXS: Add static annotations to dma driver
On 23/11/2011 21:59, Marek Vasut wrote: > Some functions were internal to the apbh dma driver, so annotate them static. > Some of the functions weren't used at all so drop them. This makes the U-Boot > binary smaller by about 1500 bytes. > > Signed-off-by: Marek Vasut > Cc: Stefano Babic > Cc: Wolfgang Denk > --- You only dropped unused functions and add static to internal functions - this is a cleanup patch and it is ok for me. Acked-by: Stefano Babic Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] M28: GPIO pin validity check added
Sorry guys; I'm bailing.
Out.
On Nov 24, 2011, at 1:15, Marek Vasut wrote:
>> This patch adds a validity check for GPIO pins to prevent clobbering
>> reserved bit or even registers, per suggestion of Marek Vasut.
>>
>> Please note:
>> 1. gpio_request no longer checks validity. Pin validity must be checked
>> explicitly use gpio_invalid prior to request and hence use. Previous
>> validity check in gpio_request was incomplete anyway. 2. MX233 is not
>> supported yet. Until it is, macros defining the number of pins for each
>> bank reside in arch/arm/include/asm/arch-mx28/iomux.h
>>
>> Signed-off-by: Robert Deliën http://delien.nl/>>
>
> AARGH! Please add the following lines to the commit message:
>
> Cc: Marek Vasut
> Cc: Stefano Babic
>
>
>
> That way, you won't have to care for the Cc, which you forgot again!
>>
>> diff --git a/arch/arm/include/asm/arch-mx28/gpio.h
>> b/arch/arm/include/asm/arch-mx28/gpio.h index be1c944..5abd7b1 100644
>> --- a/arch/arm/include/asm/arch-mx28/gpio.h
>> +++ b/arch/arm/include/asm/arch-mx28/gpio.h
>> @@ -25,6 +25,10 @@
>>
>> #ifdef CONFIG_MXS_GPIO
>> void mxs_gpio_init(void);
>> +
>> +extern int gpio_invalid(int gp);
>> +#define gpio_invalid(gpio) gpio_invalid(gpio)
>> +
>
> Please, gpio_is_valid() and invert the logic.
>
>> #else
>> inline void mxs_gpio_init(void) {}
>> #endif
>> diff --git a/arch/arm/include/asm/arch-mx28/iomux.h
>> b/arch/arm/include/asm/arch-mx28/iomux.h index 7abdf58..2326fdb 100644
>> --- a/arch/arm/include/asm/arch-mx28/iomux.h
>> +++ b/arch/arm/include/asm/arch-mx28/iomux.h
>> @@ -56,6 +56,16 @@ typedef u32 iomux_cfg_t;
>> #define MXS_PAD_PULL_VALID_SHIFT 16
>> #define MXS_PAD_PULL_VALID_MASK ((iomux_cfg_t)0x1 <<
>> MXS_PAD_PULL_VALID_SHIFT)
>>
>> +#define MX28_BANK0_PINS 29
>> +#define MX28_BANK1_PINS 32
>> +#define MX28_BANK2_PINS 28
>> +#define MX28_BANK3_PINS 31
>> +#define MX28_BANK4_PINS 21
>> +
>> +#define MX23_BANK0_PINS 32
>> +#define MX23_BANK1_PINS 31
>> +#define MX23_BANK2_PINS 32
>> +
>
> It's not used anywhere else than mxs_gpio.c, so define it there to reduce the
> scope. Also, I'd be just for using array of numbers with explanation comment
> to
> avoid making the code unnecessarily bigger.
>
>> #define PAD_MUXSEL_0 0
>> #define PAD_MUXSEL_1 1
>> #define PAD_MUXSEL_2 2
>> diff --git a/common/cmd_gpio.c b/common/cmd_gpio.c
>> index 9cc790a..51e11e7 100644
>> --- a/common/cmd_gpio.c
>> +++ b/common/cmd_gpio.c
>> @@ -15,6 +15,10 @@
>> #define name_to_gpio(name) simple_strtoul(name, NULL, 10)
>> #endif
>>
>> +#ifndef gpio_invalid
>> +#define gpio_invalid(gpio) (0)
>> +#endif
>> +
>> enum gpio_cmd {
>> GPIO_INPUT,
>> GPIO_SET,
>> @@ -56,6 +60,12 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc,
>> char * const argv[]) if (gpio < 0)
>> goto show_usage;
>>
>> + /* check bank and pin number for validity */
>> + if (gpio_invalid(gpio)) {
>> + printf("gpio: invalid pin %u\n", gpio);
>> + return -1;
>> + }
>> +
>
> Please separate this cmd_gpio() part out! Are you ignoring my previous
> comments
> completely ?
>
>> /* grab the pin before we tweak it */
>> if (gpio_request(gpio, "cmd_gpio")) {
>> printf("gpio: requesting pin %u failed\n", gpio);
>> diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c
>> index b7e9591..dabee90 100644
>> --- a/drivers/gpio/mxs_gpio.c
>> +++ b/drivers/gpio/mxs_gpio.c
>> @@ -31,7 +31,6 @@
>> #include
>>
>> #if defined(CONFIG_MX23)
>> -#define PINCTRL_BANKS 3
>> #define PINCTRL_DOUT(n) (0x0500 + ((n) * 0x10))
>> #define PINCTRL_DIN(n) (0x0600 + ((n) * 0x10))
>> #define PINCTRL_DOE(n) (0x0700 + ((n) * 0x10))
>> @@ -39,7 +38,6 @@
>> #define PINCTRL_IRQEN(n) (0x0900 + ((n) * 0x10))
>> #define PINCTRL_IRQSTAT(n) (0x0c00 + ((n) * 0x10))
>> #elif defined(CONFIG_MX28)
>> -#define PINCTRL_BANKS 5
>> #define PINCTRL_DOUT(n) (0x0700 + ((n) * 0x10))
>> #define PINCTRL_DIN(n) (0x0900 + ((n) * 0x10))
>> #define PINCTRL_DOE(n) (0x0b00 + ((n) * 0x10))
>> @@ -57,11 +55,25 @@
>> #define GPIO_INT_LEV_MASK (1 << 0)
>> #define GPIO_INT_POL_MASK (1 << 1)
>>
>> +static const int mxs_bank_pins[] = {
>> +#if defined(CONFIG_MX23)
>> + MX23_BANK0_PINS,
>> + MX23_BANK1_PINS,
>> + MX23_BANK2_PINS
>> +#elif defined(CONFIG_MX28)
>> + MX28_BANK0_PINS,
>> + MX28_BANK1_PINS,
>> + MX28_BANK2_PINS,
>> + MX28_BANK3_PINS,
>> + MX28_BANK4_PINS
>> +#endif
>
> Ignoring? I asked you to define it above and don't duplicate the ifdefs.
>
>> +};
>> +
>> void mxs_gpio_init(void)
>> {
>> int i;
>>
>> - for (i = 0; i < PINCTRL_BANKS; i++) {
>> + for (i = 0; i < ARRAY_SIZE(mxs_bank_pins); i++) {
>> writel(0, MXS_PINCTRL_BASE + PINCTRL_PIN2IRQ(i));
>> writel(0, MXS_PINCTRL_BASE + PINCTRL_IRQEN(i));
>> /* Use SCT address here to clear the IRQSTAT bits */
>> @@ -69,6 +81,16 @@ void mxs_gpio_init(void)
>> }
>> }
>>
>> +int gpio_invalid(int gp)
>> +{
>> + if ( (gp & ~(MXS_PAD_BANK_MASK | MXS_PAD_PIN_MASK)) ||
>> + (PAD_BANK(gp) >= ARRAY_SIZE(mxs_bank_pins)) ||
>> + (PAD_PIN(gp) >= mxs_bank_pins
Re: [U-Boot] [PATCH 1/2] ARM: omap3: added common configuration for Technexion TAM3517
On 23/11/2011 17:21, Wolfgang Denk wrote: >> +#define CONFIG_CMD_I2C /* I2C serial bus support */ >> +#define CONFIG_CMD_MMC /* MMC support */ >> +#define CONFIG_CMD_FAT /* FAT support */ >> +#define CONFIG_CMD_NAND /* NAND support */ >> +#define CONFIG_CMD_USB >> +#define CONFIG_CMD_DHCP >> +#define CONFIG_CMD_PING >> +#define CONFIG_CMD_CACHE >> +#define CONFIG_CMD_GPIO > > Maybe you want to sort this list. And eventually remove entries that > are defined by default? I will do it > >> +#undef CONFIG_CMD_FLASH /* flinfo, erase, protect */ >> +#undef CONFIG_CMD_IMI /* iminfo */ >> +#undef CONFIG_CMD_IMLS /* List all found images*/ > > Is there any good reason to disable the "iminfo" command? Yes - the command relies on NOR flash. In fact, in cmd_bootm.c do_imls() needs CONFIG_SYS_MAX_FLASH_BANKS, that has no sense on this SOM, because I have not CFI flash. Also defining CONFIG_SYS_MAX_FLASH_BANKS does not work, because cfi.h is still included. I prefer disabling IMLS as adding fake CFI values. > >> +#define CONFIG_SYS_NAND_ADDRNAND_BASE /* physical >> address */ >> +/* to access nand */ >> +#define CONFIG_SYS_NAND_BASENAND_BASE /* physical >> address */ > > Do we really need this double definitions? Please get rid of > NAND_BASE. NAND_BASE is the address of the controller defined in cpu.h. That iis correct. CONFIG_SYS_NAND_ADDR seems to me obsolete and not used anymore - a lot of boards define it, I think it should be globally removed - I start dropping from here. > > ... >> +/* memtest works on */ >> +#define CONFIG_SYS_MEMTEST_START(OMAP34XX_SDRC_CS0) >> +#define CONFIG_SYS_MEMTEST_END (OMAP34XX_SDRC_CS0 + \ >> +0x01F0) /* 31MB */ > > Has this been tested? Yes - the only issue here is that only 31 MB (the SOM has 256 MB RAM) are tested as default. Personally I do not like to set as default value the whole RAM (subtracting the size of the bootloader code, of course !), because the test takes too much time for a fast run. The user can always provide parameters for the mtest command if he wants to test the whole RAM. >> +/*--- >> + * Stack sizes >> + * >> + * The stack sizes are set up in start.S using the settings below >> + */ > > Incorrect multiline comment style. Please fix globally. Thanks, I will fix it. >> +#define CONFIG_ENV_IS_IN_NAND >> +#define SMNAND_ENV_OFFSET 0x18 /* environment starts here */ >> + >> +#define CONFIG_SYS_ENV_SECT_SIZE(128 << 10) /* 128 KiB */ >> +#define CONFIG_ENV_OFFSET SMNAND_ENV_OFFSET >> +#define CONFIG_ENV_ADDR SMNAND_ENV_OFFSET > > Please extend to support redundant environment, plus one or two > reserve sectors in case a sector goes bad. Good point, I will do it. > >> +/*--- >> + * CFI FLASH driver setup >> + */ >> +/* timeout values are in ticks */ >> +#define CONFIG_SYS_FLASH_ERASE_TOUT (100 * CONFIG_SYS_HZ) >> +#define CONFIG_SYS_FLASH_WRITE_TOUT (100 * CONFIG_SYS_HZ) > > This seems bogus, as there is no NOR flash on these devices. This is completely wrong, bad cut&paste ;-(. I will fix it. > >> +/* Flash banks JFFS2 should use */ >> +#define CONFIG_SYS_MAX_MTD_BANKS(CONFIG_SYS_MAX_FLASH_BANKS + \ >> +CONFIG_SYS_MAX_NAND_DEVICE) >> +#define CONFIG_SYS_JFFS2_MEM_NAND >> +/* use flash_info[2] */ >> +#define CONFIG_SYS_JFFS2_FIRST_BANK CONFIG_SYS_MAX_FLASH_BANKS >> +#define CONFIG_SYS_JFFS2_NUM_BANKS 1 > > All this probably does not work. Confirmed, it does not work and I will clean up. >> +#define CONFIG_SPL_MAX_SIZE 0xB400 /* 45 K */ > > (45 << 10) would be way easier to read... ok Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] S5PC2XX: Rename S5pc2XX to exynos4
As per new conventions Samsung SoC's are named as Exynos.
Cortex-A9 based Soc's are named as exynos4. s5pc2xx is cortex-A9
based, hence renamed to exynos4. This is done as per kernel
naming convetions.
Similerly s5pc210 is now exynos4210. Hence S5PC210/s5pc210
suffix/prefix has been renamed to EXYNOS4210/exynos4210.
Signed-off-by: Chander Kashyap
---
Changes for v2:
- Removed renaming of s5p-common to exynos4-common
- Renamed s5pc210 prefixes to exynos4210
MAINTAINERS|6 +-
Makefile |2 +-
arch/arm/cpu/armv7/{s5pc2xx => exynos4}/Makefile |0
arch/arm/cpu/armv7/{s5pc2xx => exynos4}/clock.c| 50
arch/arm/cpu/armv7/{s5pc2xx => exynos4}/soc.c |0
.../asm/{arch-s5pc2xx => arch-exynos4}/adc.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/clk.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/clock.h |2 +-
.../asm/{arch-s5pc2xx => arch-exynos4}/cpu.h | 62 ++--
.../asm/{arch-s5pc2xx => arch-exynos4}/gpio.h | 28 +-
.../asm/{arch-s5pc2xx => arch-exynos4}/mmc.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/pwm.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/sromc.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/sys_proto.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/uart.h |0
board/samsung/origen/lowlevel_init.S | 26
board/samsung/origen/mem_setup.S | 12 ++--
board/samsung/origen/origen.c |8 +-
board/samsung/origen/origen_setup.h|8 +-
board/samsung/smdkv310/lowlevel_init.S | 22
board/samsung/smdkv310/mem_setup.S |8 +-
board/samsung/smdkv310/smdkv310.c |8 +-
board/samsung/universal_c210/lowlevel_init.S | 24
board/samsung/universal_c210/universal.c |8 +-
boards.cfg |6 +-
include/configs/origen.h |6 +-
include/configs/s5pc210_universal.h| 10 ++--
include/configs/smdkv310.h |6 +-
28 files changed, 151 insertions(+), 151 deletions(-)
rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/Makefile (100%)
rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/clock.c (80%)
rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/soc.c (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/adc.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/clk.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/clock.h (99%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/cpu.h (64%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/gpio.h (83%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/mmc.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/pwm.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/sromc.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/sys_proto.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/uart.h (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 030fe4a..36f8400 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -690,12 +690,12 @@ Minkyu Kang
SMDKC100ARM ARMV7 (S5PC100 SoC)
s5p_goniARM ARMV7 (S5PC110 SoC)
- s5pc210_universal ARM ARMV7 (S5PC210 SoC)
+ s5pc210_universal ARM ARMV7 (EXYNOS4210 SoC)
Chander Kashyap
- origen ARM ARMV7 (S5PC210 SoC)
- SMDKV310ARM ARMV7 (S5PC210 SoC)
+ origen ARM ARMV7 (EXYNOS4210 SoC)
+ SMDKV310ARM ARMV7 (EXYNOS4210 SoC)
Torsten Koschorrek
scb9328 ARM920T (i.MXL)
diff --git a/Makefile b/Makefile
index 294c762..641b644 100644
--- a/Makefile
+++ b/Makefile
@@ -303,7 +303,7 @@ endif
ifeq ($(SOC),s5pc1xx)
LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
endif
-ifeq ($(SOC),s5pc2xx)
+ifeq ($(SOC),exynos4)
LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
endif
diff --git a/arch/arm/cpu/armv7/s5pc2xx/Makefile
b/arch/arm/cpu/armv7/exynos4/Makefile
similarity index 100%
rename from arch/arm/cpu/armv7/s5pc2xx/Makefile
rename to arch/arm/cpu/armv7/exynos4/Makefile
diff --git a/arch/arm/cpu/armv7/s5pc2xx/clock.c
b/arch/arm/cpu/armv7/exynos4/clock.c
similarity index 80%
rename from arch/arm/cpu/armv7/s5pc2xx/clock.c
rename to arch/arm/cpu/armv7/exynos4/clock.c
index 5ecd475..668166a 100644
--- a/arch/arm/cpu/armv7/s5pc2xx/clock.c
+++ b/arch/arm/cpu/armv7/exynos4/clock.c
@@ -30,11 +30,11 @@
#define CONFIG_SYS_CLK_FREQ_C210 2400
#endif
-/* s5pc210: return pll clock frequency */
-static unsigned long s5pc210_get_pll_clk(int pllreg)
+/* exynos4210: return pll clock frequency */
+static unsigned long exynos4210_get_pll_clk(int
Re: [U-Boot] [PATCH v8 4/4] Add USB support for Efika
2011/11/24 Marek Vasut > > On 11/12/2011 06:45 PM, Jana Rapava wrote: > > > This commit adds USB support for EfikaMX and EfikaSB. > > > > > > Signed-off-by: Jana Rapava > > > Signed-off-by: Marek Vasut > > > Cc: Remy Bohmer > > > Cc: Stefano Babic > > > Cc: Igor Grinberg > > > Cc: Wolfgang Grandegger > > > > > > Acked-by: Marek Vasut > > Ok, I think I've had just about enough of this damn shit going on here. I > see no > updates, no progress, nothing. Basically, I dropped these patches from my > tree > and applied the old ones from my reflog. I think there was about enough > time to > get the patches into shape (3 months, maybe more). > Ok, I'm really stuck with this stuff (I haven't any idea how to split this patch into general and board-specific code how was demanded), so your suggestion is probably a better way how to do it. I finally have something which I consider a usable version of ULPI support patch, so I'll post it today and you can use it if you want. Regards, Jana Rapava ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef
Dear Marek Vasut, In message <20240344.15295.marek.va...@gmail.com> you wrote: > > Someone should step up and make it consistent then ;-) There is no inconsistency, only misunderstanding. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Nothing in progression can rest on its original plan. We may as well think of rocking a grown man in the cradle of an infant. - Edmund Burke ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] MPC8536 problems
Dear "David Lynch Jr.", In message <1322109868.27713.59.camel@hp-dv9500> you wrote: > I am bringing u-boot-2009.03-rc1 up on an MPC8536 target, and I am > having some problems reading DDR, suggestions would be greatly > appreciated. This code is more than 2.5 years old. Consider it obsolete and unsupported. > I am using this particular u-boot, because the client succeeded in > getting that working on an MPC8536DS (that I do not have access to). I > can not even get the serial port working on the target with newer > versions of u-boot. Please switch to recent code (top of tree from git repository). The address the problems one by one, as you run into them. Thinking problems will go away if you ignore them or if you use ancient code is but a misconception. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A memorandum is written not to inform the reader, but to protect the writer. -- Dean Acheson ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef
Dear Jason Hui, In message you wrote: > > Then what's the rule that we must need use CONFIG_SYS_ other than > CONFIG_option? You yourself quoted the relevant part of the README before in this thread. Just re-read your own posting and/or the README: 11/23 Jason Hui Re: [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef http://article.gmane.org/gmane.comp.boot-loaders.u-boot/117887 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In the beginning, there was nothing, which exploded. - Terry Pratchett, _Lords and Ladies_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request: u-boot-staging
Dear Igor Grinberg, In message <4ecde8c3.2050...@compulab.co.il> you wrote: > > > By that logic _all_ commits in the Linux kernel must have the SoB of > > Linus Torvalds. Do they? > > No they should not. > As for my understanding, the delivery path ends with the repository > from which the pull process starts. That makes no sense either. What about the case where the author provides (say, for convenience) a git repository where we can pull from, instead of applying the posting from the ML or PW? > That is, the repository that has the *commit id* first set > and then it is not changed, because pull requests keep the > history intact. This is the reason, why Linus Torvalds do not > sign each patch pulled from others with git pull. Hm... what's the difference then between pulling from a tree or cherry picking from it? What about rebasing a tree? Sorry, but all this makes not much sense to me. No matter how you handle it, it seems a pretty arbitrary decision to me. And in all these cases the code is not touched any more. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Experience is what causes a person to make new mistakes instead of old ones. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef
On Thu, Nov 24, 2011 at 7:41 PM, Wolfgang Denk wrote: > Dear Jason Hui, > > In message > you > wrote: >> >> Then what's the rule that we must need use CONFIG_SYS_ other than >> CONFIG_option? > > You yourself quoted the relevant part of the README before in this > thread. Just re-read your own posting and/or the README: > > 11/23 Jason Hui Re: [PATCH] MX: serial_mxc: cleanup removing nasty > #ifdef > http://article.gmane.org/gmane.comp.boot-loaders.u-boot/117887 I'm just get confused. It seems from you that we can both use: CONFIG_option and CONFIG_SYS_ in this patch? right? > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > In the beginning, there was nothing, which exploded. > - Terry Pratchett, _Lords and Ladies_ > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request: u-boot-staging
Dear Igor Grinberg, In message <4ecdeae4.5030...@compulab.co.il> you wrote: > > For my understanding, the delivery ends with *unique commit id* > in some repository, which then can get pulled, but has history intact. But depending on the process, the initial commit id may or may not be the final one. Think for example about rebases that happen every now and then, even in custodian trees. And a commit ID in "some tree" is worth nothing if you cannot guarantee that this tree is publicly accessable guaranteed to exist forever. > Nevertheless, it is a meter of choice, that should be made. > I'm fine with any choice we will make. Me too. But it has to make sense. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How many QA engineers does it take to screw in a lightbulb? 3: 1 to screw it in and 2 to say "I told you so" when it doesn't work. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request: u-boot-staging
Dear Graeme, In message you wrote: > > > That is, the repository that has the *commit id* first set > > and then it is not changed, because pull requests keep the > > history intact. This is the reason, why Linus Torvalds do not > > sign each patch pulled from others with git pull. > > > > Isn't the committer field enough? > > And what difference does it really make anyway? d'accord Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Houston, Tranquillity Base here. The Eagle has landed. -- Neil Armstrong ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Adding support to Technexion TAM3517 SOM
Dear Stefano Babic, In message <4ecdfab9.70...@denx.de> you wrote: > > In the default settings I put a basic environment, using the same > variables that are already used on several boards - I know there is > neither standard nor rules for a standard environment in U-Boot, but I > find nice if different boards maintain the same behavior, using some > quite standard commands to boot from network or from storage. I like to > have a "net_nfs" (not important which is the chosen name) on all boards > I work with, as well as the same commands to boot from internal storage. There are at least a few attempts to define such standard settings. Unfortunately they did not get really far yet, not has this been documented yet (only a few variables like u-boot, u-boot_addr_r, u-boot_addr, bootfile, kernel_addr_r, kernel_addr, fdtfile, fdt_addr_r, fdt_addr, ... have been documented in the README). More such patches are welcome. But I agree that your settings make much more sense as they fit into a pretty common "look and feel". > We could use partition names as "kernel", "rootfs" to split the NAND. In > this way, the boot command still works if the customer rearrange the > size of partitions with the mtdparts variable. Of course, this wiorks > only if in the kernel the mtdparts variable is parsed > (CONFIG_MTD_CMDLINE_PARTS must be set). This should be done indeed. It will also be needed to support UBI / UBIFS which I consider mandatory on NAND based devices. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The sooner our happiness together begins, the longer it will last. -- Miramanee, "The Paradise Syndrome", stardate 4842.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] ARM: omap3: added common configuration for Technexion TAM3517
Dear Stefano Babic, In message <4ece095d.4040...@denx.de> you wrote: > > >> +#undef CONFIG_CMD_FLASH /* flinfo, erase, protect */ > >> +#undef CONFIG_CMD_IMI /* iminfo */ > >> +#undef CONFIG_CMD_IMLS/* List all found images*/ > > > > Is there any good reason to disable the "iminfo" command? > > Yes - the command relies on NOR flash. In fact, in cmd_bootm.c do_imls() > needs CONFIG_SYS_MAX_FLASH_BANKS, that has no sense on this SOM, because > I have not CFI flash. I was referring to "iminfo", not to "imls". > NAND_BASE is the address of the controller defined in cpu.h. That iis > correct. Arrgh.. I see. > CONFIG_SYS_NAND_ADDR seems to me obsolete and not used anymore - a lot > of boards define it, I think it should be globally removed - I start > dropping from here. Thanks. I think after doing this, we should then rename NAND_BASE into CONFIG_SYS_NAND_ADDR. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are bugs and then there are bugs. And then there are bugs. - Karl Lehenbauer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef
Dear Jason Hui, In message you wrote: > > I'm just get confused. It seems from you that we can both use: > CONFIG_option and CONFIG_SYS_ in this patch? right? It's one of those boarder cases. But given that we don't actually set hardware related values (say, initial data for registers) here, but select from a set of pre-defined options (UART1_BASE etc.) it seems OK to me to handle this as Stefano suggested, i. e. as CONFIG_MXC_UART_BASE . Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You Don't Have To Be 'Damned' To Work Here, But It Helps!!! - Terry Pratchett, _Eric_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request: u-boot-staging
On 11/24/11 13:51, Wolfgang Denk wrote: > Dear Igor Grinberg, > > In message <4ecdeae4.5030...@compulab.co.il> you wrote: >> >> For my understanding, the delivery ends with *unique commit id* >> in some repository, which then can get pulled, but has history intact. > > But depending on the process, the initial commit id may or may not be > the final one. Think for example about rebases that happen every now > and then, even in custodian trees. And a commit ID in "some tree" > is worth nothing if you cannot guarantee that this tree is publicly > accessable guaranteed to exist forever. That's why in Linux rebasing branches that are intended for pulling is discouraged. Also, for that meter, some maintainers predefine and guarantee that some of their branches will never be rebased (e.g. Russell King - stable branches [1]) > >> Nevertheless, it is a meter of choice, that should be made. >> I'm fine with any choice we will make. > > Me too. But it has to make sense. I think both variants do. [1] http://www.arm.linux.org.uk/developer/git-arm.php -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3]ulpi: add generic ULPI functionality
Add generic functions for ULPI init and setting bits in
ULPI registers.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
---
Changes for v2:
- make code EHCI-independent
- use udelay() in waiting loop
- mark static functions as static
- naming changes
Changes for v3:
- merge with patch ulpi: add generic ULPI support header file
- rewrite ULPI interface in more functionality-oriented way
Makefile |1 +
drivers/usb/ulpi/Makefile| 45
drivers/usb/ulpi/ulpi-viewport.c | 88 +++
drivers/usb/ulpi/ulpi.c | 199 ++
include/usb/ulpi.h | 222 ++
5 files changed, 555 insertions(+), 0 deletions(-)
create mode 100644 drivers/usb/ulpi/Makefile
create mode 100644 drivers/usb/ulpi/ulpi-viewport.c
create mode 100644 drivers/usb/ulpi/ulpi.c
create mode 100644 include/usb/ulpi.h
diff --git a/Makefile b/Makefile
index dfe939f..70a1e1e 100644
--- a/Makefile
+++ b/Makefile
@@ -272,6 +272,7 @@ LIBS += drivers/usb/gadget/libusb_gadget.o
LIBS += drivers/usb/host/libusb_host.o
LIBS += drivers/usb/musb/libusb_musb.o
LIBS += drivers/usb/phy/libusb_phy.o
+LIBS += drivers/usb/ulpi/libusb_ulpi.o
LIBS += drivers/video/libvideo.o
LIBS += drivers/watchdog/libwatchdog.o
LIBS += common/libcommon.o
diff --git a/drivers/usb/ulpi/Makefile b/drivers/usb/ulpi/Makefile
new file mode 100644
index 000..a1a2244
--- /dev/null
+++ b/drivers/usb/ulpi/Makefile
@@ -0,0 +1,45 @@
+#
+# Copyright (C) 2011 Jana Rapava
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB:= $(obj)libusb_ulpi.o
+
+COBJS-$(CONFIG_USB_ULPI) += ulpi.o
+COBJS-$(CONFIG_USB_ULPI_VIEWPORT) += ulpi-viewport.o
+
+COBJS := $(COBJS-y)
+SRCS := $(COBJS:.o=.c)
+OBJS := $(addprefix $(obj),$(COBJS))
+
+all: $(LIB)
+
+$(LIB):$(obj).depend $(OBJS)
+ $(call cmd_link_o_target, $(OBJS))
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/drivers/usb/ulpi/ulpi-viewport.c b/drivers/usb/ulpi/ulpi-viewport.c
new file mode 100644
index 000..9a1f59f
--- /dev/null
+++ b/drivers/usb/ulpi/ulpi-viewport.c
@@ -0,0 +1,88 @@
+/*
+ * Copyright (C) 2011 Jana Rapava
+ * Based on:
+ * linux/drivers/usb/otg/ulpi_viewport.c
+ *
+ * Original Copyright follow:
+ * Copyright (C) 2011 Google, Inc.
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ */
+
+#include
+#include
+#include
+
+/* ULPI viewport control bits */
+#define ULPI_WU(1 << 31)
+#define ULPI_SS(1 << 27)
+#define ULPI_RWRUN (1 << 30)
+#define ULPI_RWCTRL(1 << 29)
+
+#define ULPI_ADDR_SHIFT16
+#define ulpi_write_mask(value) ((value) & 0xff)
+#define ulpi_read_mask(value) (((value) >> 8) & 0xff)
+
+static int ulpi_wait(u32 ulpi_viewport, u32 ulpi_value, u32 ulpi_mask)
+{
+ int timeout = CONFIG_USB_ULPI_TIMEOUT;
+ u32 tmp;
+
+ writel(ulpi_value, ulpi_viewport);
+
+ /* Wait for the bits in ulpi_mask to become zero. */
+ while (--timeout) {
+ tmp = readl(ulpi_viewport);
+ if (!(tmp & ulpi_mask))
+ break;
+ udelay(1);
+ }
+
+ return !timeout;
+}
+
+static int ulpi_wakeup(u32 ulpi_viewport)
+{
+ if (readl(ulpi_viewport) & ULPI_SS)
+ return 0; /* already awake */
+
+ return ulpi_wait(ulpi_viewport, ULPI_WU, ULPI_WU);
+}
+
+void ulpi_write(u32 ulpi_viewport, u32 re
Re: [U-Boot] Adding support to Technexion TAM3517 SOM
On 24/11/2011 13:04, Wolfgang Denk wrote: > There are at least a few attempts to define such standard settings. > Unfortunately they did not get really far yet, not has this been > documented yet (only a few variables like u-boot, u-boot_addr_r, > u-boot_addr, bootfile, kernel_addr_r, kernel_addr, fdtfile, > fdt_addr_r, fdt_addr, ... have been documented in the README). > More such patches are welcome. > > But I agree that your settings make much more sense as they fit into a > pretty common "look and feel". Ok - I will then move at least part of the CONFIG_EXTRA_ENV_SETTINGS in the common file, letting the possibility to the board to replace or add further variables. >> We could use partition names as "kernel", "rootfs" to split the NAND. In >> this way, the boot command still works if the customer rearrange the >> size of partitions with the mtdparts variable. Of course, this wiorks >> only if in the kernel the mtdparts variable is parsed >> (CONFIG_MTD_CMDLINE_PARTS must be set). > > This should be done indeed. It will also be needed to support UBI / > UBIFS which I consider mandatory on NAND based devices. I have not set UBI for the twister - I will add it, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [GIT PULL] Pull request: u-boot-staging
Hi Wolfgang, On 11/24/11 13:46, Wolfgang Denk wrote: > Dear Igor Grinberg, > > In message <4ecde8c3.2050...@compulab.co.il> you wrote: >> >>> By that logic _all_ commits in the Linux kernel must have the SoB of >>> Linus Torvalds. Do they? >> >> No they should not. >> As for my understanding, the delivery path ends with the repository >> from which the pull process starts. > > That makes no sense either. What about the case where the author > provides (say, for convenience) a git repository where we can pull > from, instead of applying the posting from the ML or PW? Well, I don't see how this is different from the custodian case, except that contributor is not a custodian. > >> That is, the repository that has the *commit id* first set >> and then it is not changed, because pull requests keep the >> history intact. This is the reason, why Linus Torvalds do not >> sign each patch pulled from others with git pull. > > Hm... what's the difference then between pulling from a tree or > cherry picking from it? What about rebasing a tree? Cherry picking changes the commit id even if there are no conflicts and can be done only on one commit at a time. Pulling does not change the commit id, unless there are conflicts. Rebasing does not change the history of the rebased branch, unless there are conflicts and it is discouraged among Linux maintainers on branches intended for pulling. > > Sorry, but all this makes not much sense to me. No matter how you > handle it, it seems a pretty arbitrary decision to me. Probably, it is arbitrary. Let me make it clear, I'm not arguing that one way is better then another. I just thought that we are following the Linux model, as there is no document describing, how this thing should be done. > > And in all these cases the code is not touched any more. I think this is not just about the code, but the patch(es) (including the commit message and id) as the whole and the maintainer (custodian) work. Again, no rule - is kind of rule, but it would be nice to have a document describing this decision, so less questions will arise. -- Regards, Igor. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] U-BOOT IMX53 - USB ?
Hi List, Just wondering, anyone who is working on (or has) USB-mass-storage support for the IMX53x in u-boot ? For example, imx53-loco-board / imx53-qsb. Regards, Noel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-BOOT IMX53 - USB ?
On 24/11/2011 13:33, Vellemans, Noel wrote: > > Hi List, > > > Just wondering, anyone who is working on (or has) USB-mass-storage > support for the IMX53x in u-boot ? > > For example, imx53-loco-board / imx53-qsb. Check in the archive - patches were sent, they are still under review and new version will be post soon. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] SEO Proposal for High Ranking
Hello, Greetings for the day! I am Robert and I am contacting you after looking at your website- . We are a Leading Indian Based SEO & Web Development Company and one of the very few company which offer organic SEO services with a full range of supporting services such as one way themed text links, blog submissions, directory submissions, article writing and postings, etc. We are a team of 50+ professionals which includes 18 full time SEO experts. We are proud to inform you that our team handled 100+ SEO projects and obtained 4+ manually built links in the past 1 year. We will be glad to assist you with offering our services. Please let me know your interest. Thanks Robert Julia Online Marketing Consultant Note: - Though this is not an automated email, we keep on sending out these emails to all those people whom we find eligible of using our services. To unsubscribe from future mails (i.e., to ensure that we do not contact you again for this matter), please send a blank mail to robertjulia...@gmail.com email with NO as Subject. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] post: fix compile issue for post tests on kirkwood
commit f31a911fe (arm, post: add missing post_time_ms for arm)
enables get_ticks and get_tbclk for all arm based boards,
but kirkwood has currently no implementation for this. So
undefine this for kirkwood boards.
Signed-off-by: Holger Brunck
cc: Heiko Schocher
cc: Prafulla Wadaskar
cc: Valentin Longchamp
---
post/post.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/post/post.c b/post/post.c
index 0e67ad7..422a819 100644
--- a/post/post.c
+++ b/post/post.c
@@ -494,7 +494,7 @@ void post_reloc(void)
*/
unsigned long post_time_ms(unsigned long base)
{
-#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM) && !defined(CONFIG_KIRKWOOD)
return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
- base;
#else
--
1.7.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3]ulpi: add generic ULPI functionality
Hi Jana,
Good job!
IMO, this version looks much better
(although Marek is not happy with its schedule).
Some final neats below and we're done.
On 11/24/11 14:22, Jana Rapava wrote:
> Add generic functions for ULPI init and setting bits in
> ULPI registers.
>
> Signed-off-by: Jana Rapava
> Cc: Marek Vasut
> Cc: Remy Bohmer
> Cc: Stefano Babic
> Cc: Igor Grinberg
> Cc: Wolfgang Grandegger
> ---
> Changes for v2:
>- make code EHCI-independent
>- use udelay() in waiting loop
>- mark static functions as static
>- naming changes
> Changes for v3:
> - merge with patch ulpi: add generic ULPI support header file
> - rewrite ULPI interface in more functionality-oriented way
>
> Makefile |1 +
> drivers/usb/ulpi/Makefile| 45
> drivers/usb/ulpi/ulpi-viewport.c | 88 +++
> drivers/usb/ulpi/ulpi.c | 199 ++
> include/usb/ulpi.h | 222
> ++
> 5 files changed, 555 insertions(+), 0 deletions(-)
> create mode 100644 drivers/usb/ulpi/Makefile
> create mode 100644 drivers/usb/ulpi/ulpi-viewport.c
> create mode 100644 drivers/usb/ulpi/ulpi.c
> create mode 100644 include/usb/ulpi.h
>
> diff --git a/Makefile b/Makefile
> index dfe939f..70a1e1e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -272,6 +272,7 @@ LIBS += drivers/usb/gadget/libusb_gadget.o
> LIBS += drivers/usb/host/libusb_host.o
> LIBS += drivers/usb/musb/libusb_musb.o
> LIBS += drivers/usb/phy/libusb_phy.o
> +LIBS += drivers/usb/ulpi/libusb_ulpi.o
> LIBS += drivers/video/libvideo.o
> LIBS += drivers/watchdog/libwatchdog.o
> LIBS += common/libcommon.o
> diff --git a/drivers/usb/ulpi/Makefile b/drivers/usb/ulpi/Makefile
> new file mode 100644
> index 000..a1a2244
> --- /dev/null
> +++ b/drivers/usb/ulpi/Makefile
> @@ -0,0 +1,45 @@
> +#
> +# Copyright (C) 2011 Jana Rapava
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB := $(obj)libusb_ulpi.o
> +
> +COBJS-$(CONFIG_USB_ULPI) += ulpi.o
> +COBJS-$(CONFIG_USB_ULPI_VIEWPORT)+= ulpi-viewport.o
> +
> +COBJS:= $(COBJS-y)
> +SRCS := $(COBJS:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS))
> +
> +all: $(LIB)
> +
> +$(LIB): $(obj).depend $(OBJS)
> + $(call cmd_link_o_target, $(OBJS))
> +
> +#
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#
> diff --git a/drivers/usb/ulpi/ulpi-viewport.c
> b/drivers/usb/ulpi/ulpi-viewport.c
> new file mode 100644
> index 000..9a1f59f
> --- /dev/null
> +++ b/drivers/usb/ulpi/ulpi-viewport.c
> @@ -0,0 +1,88 @@
> +/*
> + * Copyright (C) 2011 Jana Rapava
> + * Based on:
> + * linux/drivers/usb/otg/ulpi_viewport.c
> + *
> + * Original Copyright follow:
> + * Copyright (C) 2011 Google, Inc.
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
> +
> +#include
> +#include
> +#include
> +
> +/* ULPI viewport control bits */
> +#define ULPI_WU (1 << 31)
> +#define ULPI_SS (1 << 27)
> +#define ULPI_RWRUN (1 << 30)
> +#define ULPI_RWCTRL (1 << 29)
> +
> +#define ULPI_ADDR_SHIFT 16
> +#define ulpi_write_mask(value) ((value) & 0xff)
> +#define ulpi_read_mask(value)(((value) >> 8) & 0xff)
> +
> +static int ulpi_wait(u32 ulpi_viewport, u32 ulpi_value, u32 ulpi_mask)
> +{
> + int timeout = CONFIG_USB_ULPI_TIMEOUT;
> + u32 tmp;
> +
> + writel(ulpi_value, ulpi_viewport);
> +
> + /* Wait for the bits in ulpi_mask to become zero. */
> +
[U-Boot] what to do when the uboot can not mark the phisical bad block of nand flash?
Hi, guysI got a problem. I move a part of source code of
linux/driver/mtd/nand to the u-boot. But I found that the u-boot can not mark
the phsical bad block .
when I run nand_erase() or nand_scrub(), it return error num as
below:
linux/driver/mtd/nand/nand_base.c
2589chip->erase_cmd(mtd, page & chip->pagemask); 2590
status = chip->waitfunc(mtd, chip);
2592 /*
2593 * See if operation failed and additional status checks
are
2594 * available
2595 */
2596 if ((status & NAND_STATUS_FAIL) && (chip->errstat))
2597 status = chip->errstat(mtd, chip, FL_ERASING,
2598status, page);
2600 /* See if block erase succeeded */
2601 if (status & NAND_STATUS_FAIL) {
2602 DEBUG(MTD_DEBUG_LEVEL0, "%s: Failed erase, "
2603 "page 0x%08x\n", __func__,
page);
2604 instr->state = MTD_ERASE_FAILED;
2605 instr->fail_addr =
2606 ((loff_t)page << chip->page_shift);
2607 goto erase_exit;
2608 }
you can find that if block erase is failed(status==-1), it only mark
the instr(we will not use the instr later), and go to the erase_exit. So there
is no code to mark the oob of the phisical bad block, neither add it to the bad
block table.
so ,I add the code of writing oob of the phisical bad block when it is
erased failed, such as below:
chip->erase_cmd(mtd, page & chip->pagemask);2589
- Ignored:
2590 status = chip->waitfunc(mtd, chip);
2592 /*
2593 * See if operation failed and additional status checks
are
2594 * available
2595 */
2596 if ((status & NAND_STATUS_FAIL) && (chip->errstat))
2597 status = chip->errstat(mtd, chip, FL_ERASING,
2598status, page);
2600 /* See if block erase succeeded */
2601 if (status & NAND_STATUS_FAIL) {
2602 DEBUG(MTD_DEBUG_LEVEL0, "%s: Failed erase, "
2603 "page 0x%08x\n", __func__,
page);
2604 instr->state = MTD_ERASE_FAILED;
2605 instr->fail_addr =
2606 ((loff_t)page << chip->page_shift);
nand_write_oob(addr);
2607 goto erase_exit;
2608 }
Guys, what do you think of it , and what would you to if you got this
problem.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 00/11] MIPS: fixes and updates
This series contains bugfixes and coding style cleanups. Furthermore it contains some extensions for MIPS24k and MIPS34k cores as preparation for merging the support for various Lantiq SoCs. Daniel Schwierzeck (11): MIPS: board.c: make checkpatch.pl clean MIPS: board.c: fix warning if CONFIG_CMD_NET is not defined MIPS: board.c: fix init of flash data in bd_info MIPS: add register definition for EBase register MIPS: add sleep handler for slave CPUs in multi-processor systems MIPS: make cache operation mode configurable in dcache_enable() MIPS: extend cache initialization for MIPS24K and MIPS34K cores MIPS: add additional reserved vectors for MIPS24K and MIPS34K cores MIPS: add header file for generic GPIO API MIPS: add init hook for CPU specific initialization MIPS: MAKEALL: fix lists for MIPSel and MIPS boards MAKEALL | 11 +--- arch/mips/cpu/mips32/cache.S | 24 ++- arch/mips/cpu/mips32/start.S | 37 ++- arch/mips/include/asm/gpio.h | 13 arch/mips/include/asm/mipsregs.h | 20 ++ arch/mips/lib/board.c| 139 +- 6 files changed, 171 insertions(+), 73 deletions(-) create mode 100644 arch/mips/include/asm/gpio.h -- 1.7.7.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 01/11] MIPS: board.c: make checkpatch.pl clean
WARNING: line over 80 characters
WARNING: space prohibited between function name and open parenthesis '('
WARNING: braces {} are not necessary for single statement blocks
ERROR: return is not a function, parentheses are not required
ERROR: do not use assignment in if condition
ERROR: trailing statements should be on next line
ERROR: "foo * bar" should be "foo *bar"
ERROR: spaces required around that ':' (ctx:WxV)
Signed-off-by: Daniel Schwierzeck
---
arch/mips/lib/board.c | 119 +
1 files changed, 61 insertions(+), 58 deletions(-)
diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index 1274d63..9585db7 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -64,42 +64,43 @@ int __board_early_init_f(void)
*/
return 0;
}
-int board_early_init_f(void) __attribute__((weak,
alias("__board_early_init_f")));
+int board_early_init_f(void)
+ __attribute__((weak, alias("__board_early_init_f")));
-static int init_func_ram (void)
+static int init_func_ram(void)
{
#ifdef CONFIG_BOARD_TYPES
int board_type = gd->board_type;
#else
int board_type = 0; /* use dummy arg */
#endif
- puts ("DRAM: ");
+ puts("DRAM: ");
- if ((gd->ram_size = initdram (board_type)) > 0) {
- print_size (gd->ram_size, "\n");
- return (0);
+ gd->ram_size = initdram(board_type);
+ if (gd->ram_size) {
+ print_size(gd->ram_size, "\n");
+ return 0;
}
- puts (failed);
- return (1);
+ puts(failed);
+ return 1;
}
static int display_banner(void)
{
-
- printf ("\n\n%s\n\n", version_string);
- return (0);
+ printf("\n\n%s\n\n", version_string);
+ return 0;
}
#ifndef CONFIG_SYS_NO_FLASH
static void display_flash_config(ulong size)
{
- puts ("Flash: ");
- print_size (size, "\n");
+ puts("Flash: ");
+ print_size(size, "\n");
}
#endif
-static int init_baudrate (void)
+static int init_baudrate(void)
{
gd->baudrate = getenv_ulong("baudrate", 10, CONFIG_BAUDRATE);
return 0;
@@ -133,7 +134,8 @@ init_fnc_t *init_sequence[] = {
timer_init,
env_init, /* initialize environment */
#ifdef CONFIG_INCA_IP
- incaip_set_cpuclk, /* set cpu clock according to environment
variable */
+ /* set cpu clock according to environment variable */
+ incaip_set_cpuclk,
#endif
init_baudrate, /* initialze baudrate settings */
serial_init,/* serial communications setup */
@@ -153,18 +155,19 @@ void board_init_f(ulong bootflag)
ulong addr, addr_sp, len = (ulong)&uboot_end - CONFIG_SYS_MONITOR_BASE;
ulong *s;
- /* Pointer is writable since we allocated a register for it.
+ /*
+* Pointer is writable since we allocated a register for it.
*/
gd = &gd_data;
+
/* compiler optimization barrier needed for GCC >= 3.4 */
- __asm__ __volatile__("": : :"memory");
+ __asm__ __volatile__("" : : : "memory");
- memset ((void *)gd, 0, sizeof (gd_t));
+ memset((void *)gd, 0, sizeof(gd_t));
for (init_fnc_ptr = init_sequence; *init_fnc_ptr; ++init_fnc_ptr) {
- if ((*init_fnc_ptr)() != 0) {
- hang ();
- }
+ if ((*init_fnc_ptr)() != 0)
+ hang();
}
/*
@@ -179,7 +182,7 @@ void board_init_f(ulong bootflag)
/* round down to next 4 kB limit.
*/
addr &= ~(4096 - 1);
- debug ("Top of RAM usable for U-Boot at: %08lx\n", addr);
+ debug("Top of RAM usable for U-Boot at: %08lx\n", addr);
/* Reserve memory for U-Boot code, data & bss
* round down to next 16 kB limit
@@ -187,12 +190,12 @@ void board_init_f(ulong bootflag)
addr -= len;
addr &= ~(16 * 1024 - 1);
- debug ("Reserving %ldk for U-Boot at: %08lx\n", len >> 10, addr);
+ debug("Reserving %ldk for U-Boot at: %08lx\n", len >> 10, addr);
/* Reserve memory for malloc() arena.
*/
addr_sp = addr - TOTAL_MALLOC_LEN;
- debug ("Reserving %dk for malloc() at: %08lx\n",
+ debug("Reserving %dk for malloc() at: %08lx\n",
TOTAL_MALLOC_LEN >> 10, addr_sp);
/*
@@ -202,19 +205,19 @@ void board_init_f(ulong bootflag)
addr_sp -= sizeof(bd_t);
bd = (bd_t *)addr_sp;
gd->bd = bd;
- debug ("Reserving %zu Bytes for Board Info at: %08lx\n",
+ debug("Reserving %zu Bytes for Board Info at: %08lx\n",
sizeof(bd_t), addr_sp);
addr_sp -= sizeof(gd_t);
id = (gd_t *)addr_sp;
- debug ("Reserving %zu Bytes for Global Data at: %08lx\n",
- sizeof (gd_t), addr_sp);
+ debug("Reserving %zu Bytes for Global Data at: %08lx\n",
+
[U-Boot] [PATCH 02/11] MIPS: board.c: fix warning if CONFIG_CMD_NET is not defined
board.c: In function 'board_init_r':
board.c:280:8: warning: unused variable 's'
Signed-off-by: Daniel Schwierzeck
---
arch/mips/lib/board.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index 9585db7..aac7690 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -266,7 +266,6 @@ void board_init_r(gd_t *id, ulong dest_addr)
#ifndef CONFIG_ENV_IS_NOWHERE
extern char *env_name_spec;
#endif
- char *s;
bd_t *bd;
gd = id;
@@ -347,7 +346,7 @@ void board_init_r(gd_t *id, ulong dest_addr)
/* Initialize from environment */
load_addr = getenv_ulong("loadaddr", 16, load_addr);
#if defined(CONFIG_CMD_NET)
- s = getenv("bootfile");
+ const char *s = getenv("bootfile");
if (s)
copy_filename(BootFile, s, sizeof(BootFile));
#endif
--
1.7.7.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 06/11] MIPS: make cache operation mode configurable in dcache_enable()
Commit ab2a98b11716364bc5a8c43cdfa7fee176cda1d8 missed to use the new config option in dcache_enable(). Fix this to avoid inconsistencies if someone wants to disable and enable D-caches. Signed-off-by: Daniel Schwierzeck --- arch/mips/cpu/mips32/cache.S |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/arch/mips/cpu/mips32/cache.S b/arch/mips/cpu/mips32/cache.S index 5ce0ec4..e683e8b 100644 --- a/arch/mips/cpu/mips32/cache.S +++ b/arch/mips/cpu/mips32/cache.S @@ -30,6 +30,10 @@ #include #include +#ifndef CONFIG_SYS_MIPS_CACHE_MODE +#define CONFIG_SYS_MIPS_CACHE_MODE CONF_CM_CACHABLE_NONCOHERENT +#endif + #define RA t8 /* @@ -224,7 +228,7 @@ LEAF(dcache_enable) mfc0t0, CP0_CONFIG ori t0, CONF_CM_CMASK xorit0, CONF_CM_CMASK - ori t0, CONF_CM_CACHABLE_NONCOHERENT + ori t0, CONFIG_SYS_MIPS_CACHE_MODE mtc0t0, CP0_CONFIG jr ra END(dcache_enable) -- 1.7.7.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 04/11] MIPS: add register definition for EBase register
The CPUNum field in the Ebase register contains an unique identifier for each CPU. This helps to distinguish between CPU cores in multi-processor systems. Signed-off-by: Daniel Schwierzeck --- arch/mips/include/asm/mipsregs.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h index be7e5c6..15a9fd5 100644 --- a/arch/mips/include/asm/mipsregs.h +++ b/arch/mips/include/asm/mipsregs.h @@ -89,6 +89,13 @@ #define CP0_DWATCH $19 /* + * Additional Coprocessor 0 register names. + * These registers are listed for completeness and are intended + * for usage in assembly code. + */ +#define CP0_EBASE $15,1 + +/* * Coprocessor 0 Set 1 register names */ #define CP0_S1_DERRADDR0 $26 @@ -395,6 +402,12 @@ #define CAUSEF_BD (_ULCAST_(1) << 31) /* + * Bits in the coprocessor 0 EBase register. + */ +#define EBASEB_CPUNUM 0 +#define EBASEF_CPUNUM (_ULCAST_(1023)) + +/* * Bits in the coprocessor 0 config register. */ /* Generic bits. */ -- 1.7.7.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 05/11] MIPS: add sleep handler for slave CPUs in multi-processor systems
This handler can be activated on multi-processor systems to boot only the master CPU. All slave CPUs are halted by executing the WAIT instruction. This is also useful to reduce the power consumption at boot time. Signed-off-by: Daniel Schwierzeck --- arch/mips/cpu/mips32/start.S | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch/mips/cpu/mips32/start.S b/arch/mips/cpu/mips32/start.S index 9c1b2f7..b6cb4be 100644 --- a/arch/mips/cpu/mips32/start.S +++ b/arch/mips/cpu/mips32/start.S @@ -224,6 +224,14 @@ reset: setup_c0_status_reset + /* Set all slave CPUs in sleep mode */ +#ifdef CONFIG_SYS_MPS_SLAVE_CPU_SLEEP + mfc0k0, CP0_EBASE + and k0, EBASEF_CPUNUM + bne k0, zero, slave_cpu_sleep +nop +#endif + /* Init Timer */ mtc0zero, CP0_COUNT mtc0zero, CP0_COMPARE @@ -383,3 +391,11 @@ romReserved: romExcHandle: b romExcHandle + + /* Additional handlers */ +#ifdef CONFIG_SYS_MPS_SLAVE_CPU_SLEEP +slave_cpu_sleep: + wait + b slave_cpu_sleep +nop +#endif -- 1.7.7.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 03/11] MIPS: board.c: fix init of flash data in bd_info
Boards with CONFIG_SYS_NO_FLASH should not forced to define
CONFIG_SYS_FLASH_BASE. In this case the flash data in bd_info
should be initialized with 0 like the other archs do.
Signed-off-by: Daniel Schwierzeck
---
arch/mips/lib/board.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index aac7690..bcf12c5 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -301,15 +301,19 @@ void board_init_r(gd_t *id, ulong dest_addr)
/* configure available FLASH banks */
size = flash_init();
display_flash_config(size);
+ bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
bd->bi_flashsize = size;
-#endif
- bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
#if CONFIG_SYS_MONITOR_BASE == CONFIG_SYS_FLASH_BASE
bd->bi_flashoffset = monitor_flash_len; /* reserved area for U-Boot */
#else
bd->bi_flashoffset = 0;
#endif
+#else
+ bd->bi_flashstart = 0;
+ bd->bi_flashsize = 0;
+ bd->bi_flashoffset = 0;
+#endif
#ifdef CONFIG_CMD_NAND
puts("NAND: ");
--
1.7.7.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 07/11] MIPS: extend cache initialization for MIPS24K and MIPS34K cores
Signed-off-by: Daniel Schwierzeck --- arch/mips/cpu/mips32/cache.S | 18 ++ arch/mips/include/asm/mipsregs.h |9 - 2 files changed, 26 insertions(+), 1 deletions(-) diff --git a/arch/mips/cpu/mips32/cache.S b/arch/mips/cpu/mips32/cache.S index e683e8b..4801511 100644 --- a/arch/mips/cpu/mips32/cache.S +++ b/arch/mips/cpu/mips32/cache.S @@ -34,6 +34,14 @@ #define CONFIG_SYS_MIPS_CACHE_MODE CONF_CM_CACHABLE_NONCOHERENT #endif +#ifdef CONFIG_SYS_CPU_MIPS24K +#define CONFIG_SYS_MIPS_CACHE_EXT_INIT +#endif + +#ifdef CONFIG_SYS_CPU_MIPS34K +#define CONFIG_SYS_MIPS_CACHE_EXT_INIT +#endif + #define RA t8 /* @@ -81,7 +89,12 @@ */ LEAF(mips_init_icache) bleza1, 9f +#ifdef CONFIG_SYS_MIPS_CACHE_EXT_INIT + mtc0zero, CP0_ITAGLO + mtc0zero, CP0_IDATALO +#else mtc0zero, CP0_TAGLO +#endif /* clear tag to invalidate */ PTR_LI t0, INDEX_BASE PTR_ADDUt1, t0, a1 @@ -106,7 +119,12 @@ LEAF(mips_init_icache) */ LEAF(mips_init_dcache) bleza1, 9f +#ifdef CONFIG_SYS_MIPS_CACHE_EXT_INIT + mtc0zero, CP0_DTAGLO + mtc0zero, CP0_DDATALO +#else mtc0zero, CP0_TAGLO +#endif /* clear all tags */ PTR_LI t0, INDEX_BASE PTR_ADDUt1, t0, a1 diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h index 15a9fd5..07a3cf6 100644 --- a/arch/mips/include/asm/mipsregs.h +++ b/arch/mips/include/asm/mipsregs.h @@ -93,7 +93,14 @@ * These registers are listed for completeness and are intended * for usage in assembly code. */ -#define CP0_EBASE $15,1 +#define CP0_EBASE $15,1 +/* L1 I-Cache */ +#define CP0_ITAGLO $28 +#define CP0_IDATALO$28,1 +#define CP0_IDATAHI$29,1 +/* L1 D-Cache */ +#define CP0_DTAGLO $28,2 +#define CP0_DDATALO$28,3 /* * Coprocessor 0 Set 1 register names -- 1.7.7.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 08/11] MIPS: add additional reserved vectors for MIPS24K and MIPS34K cores
Signed-off-by: Daniel Schwierzeck --- arch/mips/cpu/mips32/start.S | 21 +++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/mips/cpu/mips32/start.S b/arch/mips/cpu/mips32/start.S index b6cb4be..03cfd5a 100644 --- a/arch/mips/cpu/mips32/start.S +++ b/arch/mips/cpu/mips32/start.S @@ -206,11 +206,28 @@ _start: RVECENT(romReserved,125) RVECENT(romReserved,126) RVECENT(romReserved,127) + XVECENT(romExcHandle,0x400); + RVECENT(romReserved,129); + RVECENT(romReserved,130); + RVECENT(romReserved,131); + RVECENT(romReserved,132); + RVECENT(romReserved,133); + RVECENT(romReserved,134); + RVECENT(romReserved,135); + RVECENT(romReserved,136); + RVECENT(romReserved,137); + RVECENT(romReserved,138); + RVECENT(romReserved,139); + RVECENT(romReserved,140); + RVECENT(romReserved,141); + RVECENT(romReserved,142); + RVECENT(romReserved,143); + XVECENT(romExcHandle,0x480);# bfc00480: EJTAG debug exception /* * We hope there are no more reserved vectors! -* 128 * 8 == 1024 == 0x400 -* so this is address R_VEC+0x400 == 0xbfc00400 +* 144 * 8 == 1152 == 0x480 +* so this is address R_VEC+0x480 == 0xbfc00480 */ .align 4 reset: -- 1.7.7.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 09/11] MIPS: add header file for generic GPIO API
Signed-off-by: Daniel Schwierzeck --- arch/mips/include/asm/gpio.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 arch/mips/include/asm/gpio.h diff --git a/arch/mips/include/asm/gpio.h b/arch/mips/include/asm/gpio.h new file mode 100644 index 000..04a98ad --- /dev/null +++ b/arch/mips/include/asm/gpio.h @@ -0,0 +1,13 @@ +/* + * This file is released under the terms of GPL v2 and any later version. + * See the file COPYING in the root directory of the source tree for details. + * + * Copyright (C) 2011 Daniel Schwierzeck, daniel.schwierz...@googlemail.com + */ + +#ifndef __ASM_MIPS_GPIO_H__ +#define __ASM_MIPS_GPIO_H__ + +#include + +#endif /* __ASM_MIPS_GPIO_H__ */ -- 1.7.7.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 10/11] MIPS: add init hook for CPU specific initialization
Signed-off-by: Daniel Schwierzeck
---
arch/mips/lib/board.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index bcf12c5..27c2cfe 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -57,6 +57,16 @@ static char *failed = "*** failed ***\n";
*/
unsigned long mips_io_port_base = -1;
+int __arch_cpu_init(void)
+{
+ /*
+* Nothing to do in this dummy implementation
+*/
+ return 0;
+}
+int arch_cpu_init(void)
+ __attribute__((weak, alias("__arch_cpu_init")));
+
int __board_early_init_f(void)
{
/*
@@ -130,6 +140,7 @@ static int init_baudrate(void)
typedef int (init_fnc_t) (void);
init_fnc_t *init_sequence[] = {
+ arch_cpu_init,
board_early_init_f,
timer_init,
env_init, /* initialize environment */
--
1.7.7.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 11/11] MIPS: MAKEALL: fix lists for MIPSel and MIPS boards
Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el.
Also remove obsolete lists for mips5kc.
Signed-off-by: Daniel Schwierzeck
Cc: Thomas Lange
---
MAKEALL | 11 ++-
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/MAKEALL b/MAKEALL
index 95b7cd3..ff761e6 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -379,14 +379,11 @@ LIST_mips4kc="\
vct_premium_onenand_small \
"
-LIST_mips5kc=""
-
LIST_au1xx0=" \
dbau1000\
dbau1100\
dbau1500\
dbau1550\
- dbau1550_el \
gth2\
"
@@ -400,20 +397,16 @@ LIST_mips=" \
## MIPS Systems(little endian)
#
-LIST_mips4kc_el=" \
+LIST_xburst_el=" \
qi_lb60 \
"
-LIST_mips5kc_el=""
-
LIST_au1xx0_el=" \
dbau1550_el \
pb1000 \
"
-
LIST_mips_el=" \
- ${LIST_mips4kc_el} \
- ${LIST_mips5kc_el} \
+ ${LIST_xburst_el} \
${LIST_au1xx0_el} \
"
--
1.7.7.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] M28: GPIO pin validity check added
> Sorry guys; I'm bailing.
>
> Out.
Well ... it can't be helped.
M
>
> On Nov 24, 2011, at 1:15, Marek Vasut wrote:
> >> This patch adds a validity check for GPIO pins to prevent clobbering
> >> reserved bit or even registers, per suggestion of Marek Vasut.
> >>
> >> Please note:
> >> 1. gpio_request no longer checks validity. Pin validity must be checked
> >> explicitly use gpio_invalid prior to request and hence use. Previous
> >> validity check in gpio_request was incomplete anyway. 2. MX233 is not
> >> supported yet. Until it is, macros defining the number of pins for each
> >> bank reside in arch/arm/include/asm/arch-mx28/iomux.h
> >>
> >> Signed-off-by: Robert Deliën http://delien.nl/>>
> >
> > AARGH! Please add the following lines to the commit message:
> >
> > Cc: Marek Vasut
> > Cc: Stefano Babic
> >
> >
> >
> > That way, you won't have to care for the Cc, which you forgot again!
> >
> >> diff --git a/arch/arm/include/asm/arch-mx28/gpio.h
> >> b/arch/arm/include/asm/arch-mx28/gpio.h index be1c944..5abd7b1 100644
> >> --- a/arch/arm/include/asm/arch-mx28/gpio.h
> >> +++ b/arch/arm/include/asm/arch-mx28/gpio.h
> >> @@ -25,6 +25,10 @@
> >>
> >> #ifdef CONFIG_MXS_GPIO
> >> void mxs_gpio_init(void);
> >> +
> >> +extern int gpio_invalid(int gp);
> >> +#define gpio_invalid(gpio) gpio_invalid(gpio)
> >> +
> >
> > Please, gpio_is_valid() and invert the logic.
> >
> >> #else
> >> inline void mxs_gpio_init(void) {}
> >> #endif
> >> diff --git a/arch/arm/include/asm/arch-mx28/iomux.h
> >> b/arch/arm/include/asm/arch-mx28/iomux.h index 7abdf58..2326fdb 100644
> >> --- a/arch/arm/include/asm/arch-mx28/iomux.h
> >> +++ b/arch/arm/include/asm/arch-mx28/iomux.h
> >> @@ -56,6 +56,16 @@ typedef u32 iomux_cfg_t;
> >> #define MXS_PAD_PULL_VALID_SHIFT 16
> >> #define MXS_PAD_PULL_VALID_MASK ((iomux_cfg_t)0x1 <<
> >> MXS_PAD_PULL_VALID_SHIFT)
> >>
> >> +#define MX28_BANK0_PINS 29
> >> +#define MX28_BANK1_PINS 32
> >> +#define MX28_BANK2_PINS 28
> >> +#define MX28_BANK3_PINS 31
> >> +#define MX28_BANK4_PINS 21
> >> +
> >> +#define MX23_BANK0_PINS 32
> >> +#define MX23_BANK1_PINS 31
> >> +#define MX23_BANK2_PINS 32
> >> +
> >
> > It's not used anywhere else than mxs_gpio.c, so define it there to reduce
> > the scope. Also, I'd be just for using array of numbers with explanation
> > comment to avoid making the code unnecessarily bigger.
> >
> >> #define PAD_MUXSEL_0 0
> >> #define PAD_MUXSEL_1 1
> >> #define PAD_MUXSEL_2 2
> >> diff --git a/common/cmd_gpio.c b/common/cmd_gpio.c
> >> index 9cc790a..51e11e7 100644
> >> --- a/common/cmd_gpio.c
> >> +++ b/common/cmd_gpio.c
> >> @@ -15,6 +15,10 @@
> >> #define name_to_gpio(name) simple_strtoul(name, NULL, 10)
> >> #endif
> >>
> >> +#ifndef gpio_invalid
> >> +#define gpio_invalid(gpio) (0)
> >> +#endif
> >> +
> >> enum gpio_cmd {
> >>
> >> GPIO_INPUT,
> >> GPIO_SET,
> >>
> >> @@ -56,6 +60,12 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int
> >> argc, char * const argv[]) if (gpio < 0)
> >>
> >> goto show_usage;
> >>
> >> + /* check bank and pin number for validity */
> >> + if (gpio_invalid(gpio)) {
> >> + printf("gpio: invalid pin %u\n", gpio);
> >> + return -1;
> >> + }
> >> +
> >
> > Please separate this cmd_gpio() part out! Are you ignoring my previous
> > comments completely ?
> >
> >> /* grab the pin before we tweak it */
> >> if (gpio_request(gpio, "cmd_gpio")) {
> >> printf("gpio: requesting pin %u failed\n", gpio);
> >>
> >> diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c
> >> index b7e9591..dabee90 100644
> >> --- a/drivers/gpio/mxs_gpio.c
> >> +++ b/drivers/gpio/mxs_gpio.c
> >> @@ -31,7 +31,6 @@
> >> #include
> >>
> >> #if defined(CONFIG_MX23)
> >> -#define PINCTRL_BANKS 3
> >> #define PINCTRL_DOUT(n) (0x0500 + ((n) * 0x10))
> >> #define PINCTRL_DIN(n) (0x0600 + ((n) * 0x10))
> >> #define PINCTRL_DOE(n) (0x0700 + ((n) * 0x10))
> >> @@ -39,7 +38,6 @@
> >> #define PINCTRL_IRQEN(n) (0x0900 + ((n) * 0x10))
> >> #define PINCTRL_IRQSTAT(n) (0x0c00 + ((n) * 0x10))
> >> #elif defined(CONFIG_MX28)
> >> -#define PINCTRL_BANKS 5
> >> #define PINCTRL_DOUT(n) (0x0700 + ((n) * 0x10))
> >> #define PINCTRL_DIN(n) (0x0900 + ((n) * 0x10))
> >> #define PINCTRL_DOE(n) (0x0b00 + ((n) * 0x10))
> >> @@ -57,11 +55,25 @@
> >> #define GPIO_INT_LEV_MASK (1 << 0)
> >> #define GPIO_INT_POL_MASK (1 << 1)
> >>
> >> +static const int mxs_bank_pins[] = {
> >> +#if defined(CONFIG_MX23)
> >> + MX23_BANK0_PINS,
> >> + MX23_BANK1_PINS,
> >> + MX23_BANK2_PINS
> >> +#elif defined(CONFIG_MX28)
> >> + MX28_BANK0_PINS,
> >> + MX28_BANK1_PINS,
> >> + MX28_BANK2_PINS,
> >> + MX28_BANK3_PINS,
> >> + MX28_BANK4_PINS
> >> +#endif
> >
> > Ignoring? I asked you to define it above and don't duplicate the ifdefs.
> >
> >> +};
> >> +
> >> void mxs_gpio_init(void)
> >> {
> >>
> >> int i;
> >>
> >> - for (i = 0; i < PINCTRL_BANKS; i++) {
> >> + for (i = 0; i < ARRAY_SIZE(mxs_bank_pins); i++) {
> >>
> >> writel(0, MXS_PINCTRL_BASE + PINCTRL_PIN2IRQ(i));
>
Re: [U-Boot] [PATCH v3]ulpi: add generic ULPI functionality
> Hi Jana, > > Good job! > IMO, this version looks much better > (although Marek is not happy with its schedule). Yes, you're not getting ACK on my side for this. Ever. I'm not reviewing this shit anymore. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Adding support to Technexion TAM3517 SOM
On 24/11/2011 07:57, Tapani Utriainen wrote: > Using your u-boot.bin on Twister, USB devices do not work in linux. Using > the u-boot.bin I submitted this issue disappears. The setup is otherwise the > same (same x-loader, u-boot settings, kernel and userland). I cannot confirm this issue - I am running the 2.6.32 kernel (compiled from sources), and USB is working: usb 2-1: New USB device found, idVendor=05e3, idProduct=0608 usb 2-1: New USB device strings: Mfr=0, Product=1, SerialNumber=0 usb 2-1: Product: USB2.0 Hub hub 2-1:1.0: USB hub found hub 2-1:1.0: 4 ports detected usb 2-1.2: new high speed USB device using ehci-omap and address 3 usb 2-1.2: New USB device found, idVendor=1307, idProduct=0165 usb 2-1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 2-1.2: Product: USB Mass Storage Device usb 2-1.2: Manufacturer: USBest Technology usb 2-1.2: SerialNumber: 000318 Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] board/esd/dasa_sim/flash.c: Fix GCC 4.6 warning
Signed-off-by: Matthias Fuchs
---
board/esd/dasa_sim/flash.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/board/esd/dasa_sim/flash.c b/board/esd/dasa_sim/flash.c
index d6a7737..e2f2aac 100644
--- a/board/esd/dasa_sim/flash.c
+++ b/board/esd/dasa_sim/flash.c
@@ -44,7 +44,6 @@ unsigned long flash_init (void)
{
unsigned long size_b0;
int i;
- unsigned long base_b0;
/* Init: no FLASHes known */
for (i=0; ihttp://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] board/esd/cpci405/cpci405.c: Fix GCC 4.6 warning
Signed-off-by: Matthias Fuchs
---
board/esd/cpci405/cpci405.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/board/esd/cpci405/cpci405.c b/board/esd/cpci405/cpci405.c
index 98a8584..41b5ba0 100644
--- a/board/esd/cpci405/cpci405.c
+++ b/board/esd/cpci405/cpci405.c
@@ -656,7 +656,6 @@ int do_onewire(cmd_tbl_t *cmdtp, int flag, int argc, char *
const argv[])
int i;
unsigned char ow_id[6];
char str[32];
- unsigned char ow_crc;
/*
* Clear 1-wire bit (open drain with pull-up)
@@ -675,11 +674,10 @@ int do_onewire(cmd_tbl_t *cmdtp, int flag, int argc, char
* const argv[])
OWReadByte(); /* skip family code ( == 0x01) */
for (i = 0; i < 6; i++)
ow_id[i] = OWReadByte();
- ow_crc = OWReadByte(); /* read crc */
+ OWReadByte(); /* read crc */
- sprintf(str, "%08X%04X",
- *(unsigned int *)&ow_id[0],
- *(unsigned short *)&ow_id[4]);
+ sprintf(str, "%02X%02X%02X%02X%02X%02X",
+ ow_id[0], ow_id[1], ow_id[2], ow_id[3], ow_id[4], ow_id[5]);
printf("Setting environment variable 'ow_id' to %s\n", str);
setenv("ow_id", str);
--
1.6.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2] ppc4xx: fix PMC440 painit command
This patch fixes the PMC440 BSP command painit. The implementation was
broken since the step to the new environment handling.
Signed-off-by: Matthias Fuchs
---
V2: rebased
board/esd/pmc440/cmd_pmc440.c | 17 +++--
1 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/board/esd/pmc440/cmd_pmc440.c b/board/esd/pmc440/cmd_pmc440.c
index 0202876..647e658 100644
--- a/board/esd/pmc440/cmd_pmc440.c
+++ b/board/esd/pmc440/cmd_pmc440.c
@@ -342,7 +342,8 @@ U_BOOT_CMD(
#if defined(CONFIG_PRAM)
#include
-extern env_t *env_ptr;
+#include
+#include
int do_painit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
@@ -351,6 +352,10 @@ int do_painit(cmd_tbl_t *cmdtp, int flag, int argc, char *
const argv[])
u32 param;
ulong *lptr;
+ env_t *envp;
+ char *res;
+ int len;
+
v = getenv("pram");
if (v)
pram = simple_strtoul(v, NULL, 10);
@@ -384,7 +389,15 @@ int do_painit(cmd_tbl_t *cmdtp, int flag, int argc, char *
const argv[])
/* env is first (4k aligned) */
nextbase -= ((CONFIG_ENV_SIZE + 4096 - 1) & ~(4096 - 1));
- memcpy((void*)nextbase, env_ptr, CONFIG_ENV_SIZE);
+ envp = (env_t *)nextbase;
+ res = (char *)envp->data;
+ len = hexport_r(&env_htab, '\0', &res, ENV_SIZE, 0, NULL);
+ if (len < 0) {
+ error("Cannot export environment: errno = %d\n", errno);
+ return 1;
+ }
+ envp->crc = crc32(0, envp->data, ENV_SIZE);
+
*(--lptr) = CONFIG_ENV_SIZE; /* size */
*(--lptr) = base - nextbase; /* offset | type=0 */
--
1.6.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2 2/2] ARM: omap3: add support to Technexion twister board
The twister board is a development board using
the TAM3517 SOM.
Support for NAND, 2 Ethernet (EMAC and SMC911),
USB (EHCI_OMAP).
Signed-off-by: Stefano Babic
CC: Tapani Utrianen
CC: Tom Rini
CC: Sandeep Paulraj
---
Changes since V1:
- drop unuseful comments (W. Denk)
- drop postal address (globally) from headers
- enable_gpmc_cs_config() to set chip select (Igor Grinberg)
- drop unneeded #ifdef (W. Denk)
MAINTAINERS|1 +
board/technexion/twister/Makefile | 38
board/technexion/twister/twister.c | 116 ++
board/technexion/twister/twister.h | 411
boards.cfg |1 +
include/configs/twister.h | 56 +
6 files changed, 623 insertions(+), 0 deletions(-)
create mode 100644 board/technexion/twister/Makefile
create mode 100644 board/technexion/twister/twister.c
create mode 100644 board/technexion/twister/twister.h
create mode 100644 include/configs/twister.h
diff --git a/MAINTAINERS b/MAINTAINERS
index fdc1a53..4e3246d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -562,6 +562,7 @@ Stefano Babic
mx51evk i.MX51
polaris xscale/pxa
trizepsiv xscale/pxa
+ twister omap3
vision2 i.MX51
Jason Liu
diff --git a/board/technexion/twister/Makefile
b/board/technexion/twister/Makefile
new file mode 100644
index 000..38b7b14
--- /dev/null
+++ b/board/technexion/twister/Makefile
@@ -0,0 +1,38 @@
+#
+# Copyright (C) 2011 Ilya Yanok, Emcraft Systems
+#
+# Based on ti/evm/Makefile
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).o
+
+COBJS := $(BOARD).o
+
+SRCS := $(COBJS:.o=.c)
+OBJS := $(addprefix $(obj),$(COBJS))
+
+$(LIB):$(obj).depend $(OBJS)
+ $(call cmd_link_o_target, $(OBJS))
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
diff --git a/board/technexion/twister/twister.c
b/board/technexion/twister/twister.c
new file mode 100644
index 000..950e76c
--- /dev/null
+++ b/board/technexion/twister/twister.c
@@ -0,0 +1,116 @@
+/*
+ * Copyright (C) 2011
+ * Stefano Babic, DENX Software Engineering, sba...@denx.de.
+ *
+ * Copyright (C) 2009 TechNexion Ltd.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "twister.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/* Timing definitions for Ethernet Controller */
+static const u32 gpmc_smc911[] = {
+ NET_GPMC_CONFIG1,
+ NET_GPMC_CONFIG2,
+ NET_GPMC_CONFIG3,
+ NET_GPMC_CONFIG4,
+ NET_GPMC_CONFIG5,
+ NET_GPMC_CONFIG6,
+};
+
+static const u32 gpmc_XR16L2751[] = {
+ XR16L2751_GPMC_CONFIG1,
+ XR16L2751_GPMC_CONFIG2,
+ XR16L2751_GPMC_CONFIG3,
+ XR16L2751_GPMC_CONFIG4,
+ XR16L2751_GPMC_CONFIG5,
+ XR16L2751_GPMC_CONFIG6,
+};
+
+int board_init(void)
+{
+ gpmc_init(); /* in SRAM or SDRAM, finish GPMC */
+
+ /* boot param addr */
+ gd->bd->bi_boot_params = (OMAP34XX_SDRC_CS0 + 0x100);
+
+ /* Chip select 1 and 3 are used for XR16L2751 UART controller */
+ enable_gpmc_cs_config(gpmc_XR16L2751, &gpmc_cfg->cs[1],
+ XR16L2751_UART1_BASE, GPMC_SIZE_16M);
+
+ enable_gpmc_cs_config(gpmc_XR16L2751, &gpmc_cfg->cs[3],
+ XR16L2751_UART2_BASE, GPMC_SIZE_16M);
[U-Boot] [PATCH V2 1/2] ARM: omap3: added common configuration for Technexion TAM3517
The TAM3517 is a SOM module that can be used on custom boards.
The patch add a common configuration file that is included
by the boards using this module.
Signed-off-by: Stefano Babic
CC: Tapani Utrianen
CC: Tom Rini
CC: Sandeep Paulraj
---
Changes since V1:
- CONFIG_OMAP_EHCI_PHY1_RESET_GPIO (Igor Grinberg)
- Used inline instead of adding unuseful defines
- rebased on latest posted patches for AM3517
- drop mixing of space an tabs (Igor Grinberg)
- move default environment into the common file
- sort lists (W. Denk)
- do not remove CONFIG_CMD_IMI (W. Denk)
- drop CONFIG_SYS_NAND_ADDR (W. Denk)
- coding styles (several comments)
- add redundant environment (W. Denk)
- drop completely CFI setup (W. Denk)
include/configs/tam3517-common.h | 358 ++
1 files changed, 358 insertions(+), 0 deletions(-)
create mode 100644 include/configs/tam3517-common.h
diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
new file mode 100644
index 000..f972592
--- /dev/null
+++ b/include/configs/tam3517-common.h
@@ -0,0 +1,358 @@
+/*
+ * Copyright (C) 2011
+ * Stefano Babic, DENX Software Engineering, sba...@denx.de.
+ *
+ * Copyright (C) 2009 TechNexion Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc.
+ */
+
+#ifndef __TAM3517_H
+#define __TAM3517_H
+
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_OMAP/* in a TI OMAP core */
+#define CONFIG_OMAP34XX/* which is a 34XX */
+
+#define CONFIG_SYS_TEXT_BASE 0x80008000
+
+#define CONFIG_SYS_CACHELINE_SIZE 64
+
+#define CONFIG_EMIF4 /* The chip has EMIF4 controller */
+
+#include /* get chip and board defs */
+#include
+
+/*
+ * Display CPU and Board information
+ */
+#define CONFIG_DISPLAY_CPUINFO
+#define CONFIG_DISPLAY_BOARDINFO
+
+/* Clock Defines */
+#define V_OSCK 2600/* Clock output from T2 */
+#define V_SCLK (V_OSCK >> 1)
+
+#undef CONFIG_USE_IRQ /* no support for IRQs */
+#define CONFIG_MISC_INIT_R
+
+#define CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
+#define CONFIG_SETUP_MEMORY_TAGS
+#define CONFIG_INITRD_TAG
+#define CONFIG_REVISION_TAG
+
+/*
+ * Size of malloc() pool
+ */
+#define CONFIG_ENV_SIZE(128 << 10) /* 128 KiB
sector */
+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (128 << 10) + \
+ 2 * 1024 * 1024)
+/*
+ * DDR related
+ */
+#define CONFIG_OMAP3_MICRON_DDR/* Micron DDR */
+#define CONFIG_SYS_CS0_SIZE(256 * 1024 * 1024)
+
+/*
+ * Hardware drivers
+ */
+
+/*
+ * NS16550 Configuration
+ */
+#define CONFIG_SYS_NS16550
+#define CONFIG_SYS_NS16550_SERIAL
+#define CONFIG_SYS_NS16550_REG_SIZE(-4)
+#define CONFIG_SYS_NS16550_CLK 4800/* 48MHz (APLL96/2) */
+
+/*
+ * select serial console configuration
+ */
+#define CONFIG_CONS_INDEX 1
+#define CONFIG_SYS_NS16550_COM1OMAP34XX_UART1
+#define CONFIG_SERIAL1 /* UART1 */
+
+/* allow to overwrite serial and ethaddr */
+#define CONFIG_ENV_OVERWRITE
+#define CONFIG_BAUDRATE115200
+#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
+ 115200}
+#define CONFIG_MMC
+#define CONFIG_OMAP_HSMMC
+#define CONFIG_GENERIC_MMC
+#define CONFIG_DOS_PARTITION
+
+/* EHCI */
+#define CONFIG_OMAP3_GPIO_5
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_OMAP
+#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 25
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
+#define CONFIG_USB_STORAGE
+
+/* #define CONFIG_EHCI_DCACHE */
+
+/* commands to include */
+#include
+
+#define CONFIG_CMD_CACHE
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_EXT2/* EXT2 Support */
+#define CONFIG_CMD_FAT /* FAT support */
+#define CONFIG_CMD_GPIO
+#define CONFIG_CMD_I2C /* I2C serial bus support */
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_MMC /* MMC support */
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_NFS
+#define CONFIG_CMD_NAND/* NAND support */
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB
+
+#undef CONFIG_CMD_FLASH/* onl
[U-Boot] [PATCH] board/esd/common/xilinx_jtag_micro.c: Fix GCC 4.6 warning
Signed-off-by: Matthias Fuchs
---
board/esd/common/xilinx_jtag/micro.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/board/esd/common/xilinx_jtag/micro.c
b/board/esd/common/xilinx_jtag/micro.c
index 9823e5e..cba33b8 100644
--- a/board/esd/common/xilinx_jtag/micro.c
+++ b/board/esd/common/xilinx_jtag/micro.c
@@ -1831,7 +1831,6 @@ int xsvfExecute(void)
int do_cpld(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
int iErrorCode;
- char* pzXsvfFileName;
unsigned long duration;
unsigned long long startClock, endClock;
@@ -1847,7 +1846,6 @@ int do_cpld(cmd_tbl_t *cmdtp, int flag, int argc, char *
const argv[])
}
iErrorCode = XSVF_ERRORCODE( XSVF_ERROR_NONE );
- pzXsvfFileName = 0;
xsvf_iDebugLevel= 0;
printf("XSVF Player v%s, Xilinx, Inc.\n", XSVF_VERSION);
--
1.6.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] M28EVK SD Card Info
Marek, Can you please show me your 'fdisk -l' output on a SD card that you use for booting M28EVK board? Mine is as following: $ sudo fdisk -l /dev/mmcblk0 Disk /dev/mmcblk0: 3965 MB, 3965190144 bytes 3 heads, 32 sectors/track, 80672 cylinders Units = cylinders of 96 * 512 = 49152 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes Disk identifier: 0x24efc022 Device Boot Start End Blocks Id System /dev/mmcblk0p1204820691056 53 OnTrack DM6 Aux3 I am working on adding support for MX28EVK, but no U-boot prompt yet. Followed your README.m28 document for flashing u-boot.sd into the SD card. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 5/6] i.mx: fsl_esdhc: add the i.mx6q support
On 18/11/2011 08:11, Jason Liu wrote:
> The mmc host controller on the i.mx6q is called usdhc which
> is redesigned based on the freescale esdhc controller.
>
> The usdhc controller is almost compatible with esdhc except
> it adds one mix register to support debug/SD3.0 and move
> the low bit 0-6 of XFERTYP register to the mix control reg
> low bit 0-6. Thus on i.mx6q, we have the following compared
> with the previous soc: (can refer to RM of chapter 56.3.3)
>
> i.mx6q:
> mix control:
> bit 31 - bit 7: Added for debug/SD3.0 support
> bit 6 - bit 0: move in the XFERTYP register bit 6-0 on previous soc
> XFERTYP register:
> bit 31 - bit 7: the same as before,
> bit 6 - bit 0: no-use
>
> previous soc
> mix control: no
> XFERTYP register:
> bit 31 - bit 0: xfertype information
>
> Signed-off-by: Jason Liu
> CC:Stefano Babic
> Acked-by: Stefano Babic
> ---
> v2: extend the commit message by adding mix/xtertype register change
> remove one #ifdef as Marek suggested
> change the print of USDHC/ESDHC to SDHC
> ---
> drivers/mmc/fsl_esdhc.c | 12 +---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index ec953f0..ddd1b4c 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -58,7 +58,8 @@ struct fsl_esdhc {
> uintautoc12err;
> uinthostcapblt;
> uintwml;
> - charreserved1[8];
> + uintmixctrl;
> + charreserved1[4];
> uintfevt;
> charreserved2[168];
> uinthostver;
> @@ -298,8 +299,13 @@ esdhc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> struct mmc_data *data)
>
> /* Send the command */
> esdhc_write32(®s->cmdarg, cmd->cmdarg);
> +#if defined(CONFIG_FSL_USDHC)
> + esdhc_write32(®s->mixctrl,
> + (esdhc_read32(®s->mixctrl) & 0xFF80) | (xfertyp & 0x7F));
> + esdhc_write32(®s->xfertyp, xfertyp & 0x);
> +#else
> esdhc_write32(®s->xfertyp, xfertyp);
> -
> +#endif
> /* Wait for the command to complete */
> while (!(esdhc_read32(®s->irqstat) & IRQSTAT_CC))
> ;
> @@ -482,7 +488,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg
> *cfg)
>
> mmc = malloc(sizeof(struct mmc));
>
> - sprintf(mmc->name, "FSL_ESDHC");
> + sprintf(mmc->name, "FSL_SDHC");
> regs = (struct fsl_esdhc *)cfg->esdhc_base;
Jason,
I have no issues about this patch, but it was not forwarded to Andy (MMC
Maintainer).
>From my site:
Acked-by: Stefano Babic
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] M28EVK SD Card Info
On Thu, Nov 24, 2011 at 2:13 PM, Fabio Estevam wrote: > Marek, > > Can you please show me your 'fdisk -l' output on a SD card that you > use for booting M28EVK board? Nevermind, I got it booting now :-) Patches will follow soon. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] M28EVK SD Card Info
> On Thu, Nov 24, 2011 at 2:13 PM, Fabio Estevam wrote: > > Marek, > > > > Can you please show me your 'fdisk -l' output on a SD card that you > > use for booting M28EVK board? > > Nevermind, I got it booting now :-) > > Patches will follow soon. > > Regards, > > Fabio Estevam I'll be glad to review. btw. you work for freescale or why do you push so much fsl crap mainline? :) M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] M28: Document that units has to be set to sectors on SD bootcard
Signed-off-by: Marek Vasut Cc: Stefano Babic Cc: Wolfgang Denk --- doc/README.m28 |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/doc/README.m28 b/doc/README.m28 index b749ce0..242230b 100644 --- a/doc/README.m28 +++ b/doc/README.m28 @@ -116,6 +116,12 @@ must have the following parameters: For example in Linux fdisk, the sequence for a clear card is the following: * o . create a clear partition table + * p . here you need to verify that units is set to + sectors. In the output, earch for a line + containing: + Units = sectors of 1 * 512 = 512 bytes + If no such line is present, press "u" to + switch units to sectors. * n . create new partition * p . primary partition * 1 . first partition -- 1.7.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/esd/cpci405/cpci405.c: Fix GCC 4.6 warning
> Signed-off-by: Matthias Fuchs
> ---
> board/esd/cpci405/cpci405.c |8 +++-
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/board/esd/cpci405/cpci405.c b/board/esd/cpci405/cpci405.c
> index 98a8584..41b5ba0 100644
> --- a/board/esd/cpci405/cpci405.c
> +++ b/board/esd/cpci405/cpci405.c
> @@ -656,7 +656,6 @@ int do_onewire(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[]) int i;
> unsigned char ow_id[6];
> char str[32];
> - unsigned char ow_crc;
>
> /*
>* Clear 1-wire bit (open drain with pull-up)
> @@ -675,11 +674,10 @@ int do_onewire(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[]) OWReadByte(); /* skip family code ( == 0x01) */
> for (i = 0; i < 6; i++)
> ow_id[i] = OWReadByte();
> - ow_crc = OWReadByte(); /* read crc */
> + OWReadByte(); /* read crc */
Are you sure this doesn't get optimized out? Did you test this patch please?
>
> - sprintf(str, "%08X%04X",
> - *(unsigned int *)&ow_id[0],
> - *(unsigned short *)&ow_id[4]);
> + sprintf(str, "%02X%02X%02X%02X%02X%02X",
> + ow_id[0], ow_id[1], ow_id[2], ow_id[3], ow_id[4], ow_id[5]);
> printf("Setting environment variable 'ow_id' to %s\n", str);
> setenv("ow_id", str);
This does indeed look eerie, the old code.
Ok, good, I'll assign this gcc4.6 thing to myself and start picking these.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/esd/dasa_sim/flash.c: Fix GCC 4.6 warning
> Signed-off-by: Matthias Fuchs
> ---
> board/esd/dasa_sim/flash.c |3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/board/esd/dasa_sim/flash.c b/board/esd/dasa_sim/flash.c
> index d6a7737..e2f2aac 100644
> --- a/board/esd/dasa_sim/flash.c
> +++ b/board/esd/dasa_sim/flash.c
> @@ -44,7 +44,6 @@ unsigned long flash_init (void)
> {
> unsigned long size_b0;
> int i;
> - unsigned long base_b0;
>
> /* Init: no FLASHes known */
> for (i=0; i @@ -63,8 +62,6 @@ unsigned long flash_init (void)
> /* Setup offsets */
> flash_get_offsets (-size_b0, &flash_info[0]);
>
> - base_b0 = -size_b0;
> -
> /* Monitor protection ON by default */
> (void)flash_protect(FLAG_PROTECT_SET,
> -monitor_flash_len,
Ok, I'll pick this one.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/esd/common/xilinx_jtag_micro.c: Fix GCC 4.6 warning
> Signed-off-by: Matthias Fuchs
> ---
> board/esd/common/xilinx_jtag/micro.c |2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/board/esd/common/xilinx_jtag/micro.c
> b/board/esd/common/xilinx_jtag/micro.c index 9823e5e..cba33b8 100644
> --- a/board/esd/common/xilinx_jtag/micro.c
> +++ b/board/esd/common/xilinx_jtag/micro.c
> @@ -1831,7 +1831,6 @@ int xsvfExecute(void)
> int do_cpld(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> {
> int iErrorCode;
> - char* pzXsvfFileName;
> unsigned long duration;
> unsigned long long startClock, endClock;
>
> @@ -1847,7 +1846,6 @@ int do_cpld(cmd_tbl_t *cmdtp, int flag, int argc,
> char * const argv[]) }
>
> iErrorCode = XSVF_ERRORCODE( XSVF_ERROR_NONE );
> - pzXsvfFileName = 0;
> xsvf_iDebugLevel= 0;
>
> printf("XSVF Player v%s, Xilinx, Inc.\n", XSVF_VERSION);
Good catch, I'll pick this one.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] drivers/bios_emulator/x86emu/ops2.c: Fix GCC 4.6 build warning
> Fix: > > x86emu/ops2.c: In function 'x86emuOp2_set_byte': > x86emu/ops2.c:171:11: warning: variable 'name' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Kumar Gala > --- > drivers/bios_emulator/x86emu/ops2.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/bios_emulator/x86emu/ops2.c > b/drivers/bios_emulator/x86emu/ops2.c index 937bf4c..59dbb42 100644 > --- a/drivers/bios_emulator/x86emu/ops2.c > +++ b/drivers/bios_emulator/x86emu/ops2.c > @@ -42,6 +42,7 @@ > ** > **/ > > #include > +#include > #include "x86emu/x86emui.h" > > /*- Implementation > */ @@ -168,7 +169,7 @@ void > x86emuOp2_set_byte(u8 op2) > int mod, rl, rh; > uint destoffset; > u8 *destreg; > -char *name = 0; > +__maybe_unused char *name = 0; I don't like this __maybe_unused stuff, it seems like you're hiding possible errors. > int cond = 0; > > START_OF_INSTR(); ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
> Fix:
>
> interactive.c: In function 'fsl_ddr_interactive':
> interactive.c:1357:15: warning: variable 'len' set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Kumar Gala
> ---
> arch/powerpc/cpu/mpc8xxx/ddr/interactive.c |3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c index d7d66ef..5b72437 100644
> --- a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> @@ -1354,7 +1354,6 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t
> *pinfo) {
> unsigned long long ddrsize;
> const char *prompt = "FSL DDR>";
> - unsigned int len;
> char buffer[CONFIG_SYS_CBSIZE];
> char *argv[CONFIG_SYS_MAXARGS + 1]; /* NULL terminated */
> int argc;
> @@ -1389,7 +1388,7 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t
> *pinfo) * No need to worry for buffer overflow here in
>* this function; readline() maxes out at CFG_CBSIZE
>*/
> - len = readline_into_buffer(prompt, buffer);
> + readline_into_buffer(prompt, buffer);
> argc = parse_line(buffer, argv);
> if (argc == 0)
> continue;
Ok, I'll pick this one.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
> > Fix:
> >
> > interactive.c: In function 'fsl_ddr_interactive':
> > interactive.c:1357:15: warning: variable 'len' set but not used
> > [-Wunused-but-set-variable]
> >
> > Signed-off-by: Kumar Gala
> > ---
> >
> > arch/powerpc/cpu/mpc8xxx/ddr/interactive.c |3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c index d7d66ef..5b72437
> > 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > @@ -1354,7 +1354,6 @@ unsigned long long
> > fsl_ddr_interactive(fsl_ddr_info_t *pinfo) {
> >
> > unsigned long long ddrsize;
> > const char *prompt = "FSL DDR>";
> >
> > - unsigned int len;
> >
> > char buffer[CONFIG_SYS_CBSIZE];
> > char *argv[CONFIG_SYS_MAXARGS + 1]; /* NULL terminated */
> > int argc;
> >
> > @@ -1389,7 +1388,7 @@ unsigned long long
> > fsl_ddr_interactive(fsl_ddr_info_t *pinfo) * No need to worry for buffer
> > overflow here in
> >
> > * this function; readline() maxes out at CFG_CBSIZE
> > */
> >
> > - len = readline_into_buffer(prompt, buffer);
> > + readline_into_buffer(prompt, buffer);
> >
> > argc = parse_line(buffer, argv);
> > if (argc == 0)
> >
> > continue;
>
> Ok, I'll pick this one.
Picked to:
u-boot-staging.git / marek.va...@gmail.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/esd/common/xilinx_jtag_micro.c: Fix GCC 4.6 warning
> > Signed-off-by: Matthias Fuchs
> > ---
> >
> > board/esd/common/xilinx_jtag/micro.c |2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/board/esd/common/xilinx_jtag/micro.c
> > b/board/esd/common/xilinx_jtag/micro.c index 9823e5e..cba33b8 100644
> > --- a/board/esd/common/xilinx_jtag/micro.c
> > +++ b/board/esd/common/xilinx_jtag/micro.c
> > @@ -1831,7 +1831,6 @@ int xsvfExecute(void)
> >
> > int do_cpld(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> > {
> >
> > int iErrorCode;
> >
> > - char* pzXsvfFileName;
> >
> > unsigned long duration;
> > unsigned long long startClock, endClock;
> >
> > @@ -1847,7 +1846,6 @@ int do_cpld(cmd_tbl_t *cmdtp, int flag, int argc,
> > char * const argv[]) }
> >
> > iErrorCode = XSVF_ERRORCODE( XSVF_ERROR_NONE );
> >
> > - pzXsvfFileName = 0;
> >
> > xsvf_iDebugLevel= 0;
> >
> > printf("XSVF Player v%s, Xilinx, Inc.\n", XSVF_VERSION);
>
> Good catch, I'll pick this one.
Picked to:
u-boot-staging.git / marek.va...@gmail.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/esd/dasa_sim/flash.c: Fix GCC 4.6 warning
> > Signed-off-by: Matthias Fuchs
> > ---
> >
> > board/esd/dasa_sim/flash.c |3 ---
> > 1 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/board/esd/dasa_sim/flash.c b/board/esd/dasa_sim/flash.c
> > index d6a7737..e2f2aac 100644
> > --- a/board/esd/dasa_sim/flash.c
> > +++ b/board/esd/dasa_sim/flash.c
> > @@ -44,7 +44,6 @@ unsigned long flash_init (void)
> >
> > {
> >
> > unsigned long size_b0;
> > int i;
> >
> > - unsigned long base_b0;
> >
> > /* Init: no FLASHes known */
> > for (i=0; i >
> > @@ -63,8 +62,6 @@ unsigned long flash_init (void)
> >
> > /* Setup offsets */
> > flash_get_offsets (-size_b0, &flash_info[0]);
> >
> > - base_b0 = -size_b0;
> > -
> >
> > /* Monitor protection ON by default */
> > (void)flash_protect(FLAG_PROTECT_SET,
> >
> > -monitor_flash_len,
>
> Ok, I'll pick this one.
Picked to:
u-boot-staging.git / marek.va...@gmail.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] M28: Added pin name support in GPIO driver
On Wednesday 23 November 2011 17:33:02 Mike Frysinger wrote: > On Wednesday 23 November 2011 16:10:49 Robert Deliën wrote: > > -#ifndef name_to_gpio > > -#define name_to_gpio(name) simple_strtoul(name, NULL, 10) > > +#ifndef gpio_name_to_pin > > +#define gpio_name_to_pin(name) simple_strtoul(name, NULL, 10) > > > > #endif > > as for the underlying reason, i don't have a problem with renaming things. > but the reason i picked "name_to_gpio" instead of "gpio_to_name" was that > this is not part of the Linux GPIO API. i didn't want to use a name > that'd end up clashing. but i guess the naming convention didn't > translate well and it just confuses people. actually, i lied. it's called "name_to_gpio" because it's converting from a name to a gpio. which is i why i guess you had "pin" in there. the framework doesn't require everything start with "gpio". the Linux API already uses "irq_to_gpio" and "gpio_to_irq". so let's keep it "name_to_gpio" as it's more straightforward imo. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] M28: Document that units has to be set to sectors on SD bootcard
> On Thu, Nov 24, 2011 at 2:57 PM, Marek Vasut wrote: > > For example in Linux fdisk, the sequence for a clear card is the > > following: > > > >* o . create a clear partition table > > + * p . here you need to verify that units is > > set to + sectors. In the output, earch > > for a line > > s/earch/search Thanks! > > > + containing: > > + Units = sectors of 1 * 512 = 512 > > bytes + If no such line is present, > > press "u" to + switch units to sectors. > > Or maybe an easier way is to call: > sudo fdisk /dev/mmcblk0 -u -u=sectors is even better. Of course, this doesn't work on *BSD. Other OSes/game-loaders/etc. I don't think we even consider ;-) > > Regards, > > Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V2] M28: Document that units has to be set to sectors on SD bootcard
Signed-off-by: Marek Vasut Cc: Stefano Babic Cc: Wolfgang Denk --- doc/README.m28 |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) V2: Make this all simpler for user to follow diff --git a/doc/README.m28 b/doc/README.m28 index b749ce0..e4929ad 100644 --- a/doc/README.m28 +++ b/doc/README.m28 @@ -113,7 +113,8 @@ must have the following parameters: * Partition size at least 1024 kb * Partition type 0x53 (sometimes "OnTrack DM6 Aux3") -For example in Linux fdisk, the sequence for a clear card is the following: +For example in Linux fdisk, the sequence for a clear card is the follows. Be +sure to run fdisk with the option "-u=sectors" to set units to sectors: * o . create a clear partition table * n . create new partition -- 1.7.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] board/esd/cpci405/cpci405.c: Fix GCC 4.6 warning
On Thursday 24 November 2011 10:39:21 Matthias Fuchs wrote: > - sprintf(str, "%08X%04X", > - *(unsigned int *)&ow_id[0], > - *(unsigned short *)&ow_id[4]); > + sprintf(str, "%02X%02X%02X%02X%02X%02X", > + ow_id[0], ow_id[1], ow_id[2], ow_id[3], ow_id[4], ow_id[5]); use __get_unaligned_le32 and __get_unaligned_le16 helpers to avoid having to decode each byte. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 11/11] MIPS: MAKEALL: fix lists for MIPSel and MIPS boards
On Thursday 24 November 2011 08:57:56 Daniel Schwierzeck wrote: > Build dbau1550_el only in LIST_au1xx0_el and LIST_mips_el. > Also remove obsolete lists for mips5kc. if possible, i'd really like to kill off all the specialized mips lists and do selection purely based on fields in boards.cfg. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2] M28: Document that units has to be set to sectors on SD bootcard
On Thu, Nov 24, 2011 at 3:39 PM, Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Stefano Babic > Cc: Wolfgang Denk > --- > doc/README.m28 | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > V2: Make this all simpler for user to follow > > diff --git a/doc/README.m28 b/doc/README.m28 > index b749ce0..e4929ad 100644 > --- a/doc/README.m28 > +++ b/doc/README.m28 > @@ -113,7 +113,8 @@ must have the following parameters: > * Partition size at least 1024 kb > * Partition type 0x53 (sometimes "OnTrack DM6 Aux3") > > -For example in Linux fdisk, the sequence for a clear card is the following: > +For example in Linux fdisk, the sequence for a clear card is the follows. Be s/follows/following Other than that: Acked-by: Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH V3] M28: Document that units has to be set to sectors on SD bootcard
Signed-off-by: Marek Vasut Cc: Stefano Babic Cc: Wolfgang Denk --- doc/README.m28 |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) V2: Make this all simpler for user to follow V3: Fix grammar diff --git a/doc/README.m28 b/doc/README.m28 index b749ce0..548982f 100644 --- a/doc/README.m28 +++ b/doc/README.m28 @@ -113,7 +113,8 @@ must have the following parameters: * Partition size at least 1024 kb * Partition type 0x53 (sometimes "OnTrack DM6 Aux3") -For example in Linux fdisk, the sequence for a clear card is the following: +For example in Linux fdisk, the sequence for a clear card follows. Be sure to +run fdisk with the option "-u=sectors" to set units to sectors: * o . create a clear partition table * n . create new partition -- 1.7.7.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] microblaze: usable uart16550 for big endian systems
Am Mittwoch, den 23.11.2011, 15:40 +0100 schrieb Michal Simek: > Hi Stephan, > > >> Stephan Linz wrote: > >>> As a result of the commit 6833260 the uart16550 driver > >>> is broken for Microblaze big endian systems, because of > >>> the missing 3 byte offset. Other than as described, the > >>> U-Boot BSP does not treat properly the 3 byte offset. > >>> > >>> However, with the new 32 bit access to ns16550 registers > >>> we can enable correct register access for Microblaze big > >>> and little endian systems in the same manner. > >> The reason why I have applied that patch is that baseaddress generation > >> was moved to u-boot BSP out of u-boot configs. > >> > >> --snip-- > > > >> Anyway you solution looks interesting and I will test it. > > > > However since commit 79df120 we can use direct 32 bit access to 8 bit > > NS16550 registers without gap generation in ns16550.h ... we need sane > > in_*/out_* implementation. > > > > I have look at it and tested on BE/LE. For 32bit accesses we need to implement > in/out_le32 functions which we don't have right now Hi Michal, Oh yes, of course. There are no *_le32 operations, not yet. > that's why please remove this macro > from your patch. > > Our BSP generates/ed +3 offset that's why I prefer to mask it in the same > patch > to be sure that baseaddr is correct and compatible with old versions. > > Here is patch I have used. Please add that changes to v2 patch. I'll do it this way. Give me a little time to change and test it. Currently I am sill working on refactoring of the LL TEMAC driver. I hope, the refactored driver than can merge in mainline ... Thanks, Stephan > diff --git a/include/configs/microblaze-generic.h > b/include/configs/microblaze-generic.h > index b740a28..8085130 100644 > --- a/include/configs/microblaze-generic.h > +++ b/include/configs/microblaze-generic.h > @@ -55,10 +55,16 @@ > #elif XILINX_UART16550_BASEADDR > # define CONFIG_SYS_NS165501 > # define CONFIG_SYS_NS16550_SERIAL > + > +#if defined(__MICROBLAZEEL__) > # define CONFIG_SYS_NS16550_REG_SIZE -4 > +#else > +# define CONFIG_SYS_NS16550_REG_SIZE 4 > +#endif > + > # define CONFIG_CONS_INDEX 1 > # define CONFIG_SYS_NS16550_COM1 \ > - (XILINX_UART16550_BASEADDR + 0x1000) > + ((XILINX_UART16550_BASEADDR & ~0xF) + 0x1000) > # define CONFIG_SYS_NS16550_CLKXILINX_UART16550_CLOCK_HZ > # define CONFIG_BAUDRATE 115200 > > > -- Viele Grüße, Stephan Linz __ MB-Ref: http://www.li-pro.de/xilinx_mb:mbref:start OpenDCC: http://www.li-pro.net/opendcc.phtml PC/M: http://www.li-pro.net/pcm.phtml Sourceforge: http://sourceforge.net/users/slz Gitorious: https://gitorious.org/~slz ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] drivers/bios_emulator/x86emu/ops2.c: Fix GCC 4.6 build warning
On Nov 24, 2011, at 11:14 AM, Marek Vasut wrote: >> Fix: >> >> x86emu/ops2.c: In function 'x86emuOp2_set_byte': >> x86emu/ops2.c:171:11: warning: variable 'name' set but not used >> [-Wunused-but-set-variable] >> >> Signed-off-by: Kumar Gala >> --- >> drivers/bios_emulator/x86emu/ops2.c |3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/bios_emulator/x86emu/ops2.c >> b/drivers/bios_emulator/x86emu/ops2.c index 937bf4c..59dbb42 100644 >> --- a/drivers/bios_emulator/x86emu/ops2.c >> +++ b/drivers/bios_emulator/x86emu/ops2.c >> @@ -42,6 +42,7 @@ >> ** >> **/ >> >> #include >> +#include >> #include "x86emu/x86emui.h" >> >> /*- Implementation >> */ @@ -168,7 +169,7 @@ void >> x86emuOp2_set_byte(u8 op2) >> int mod, rl, rh; >> uint destoffset; >> u8 *destreg; >> -char *name = 0; >> +__maybe_unused char *name = 0; > > I don't like this __maybe_unused stuff, it seems like you're hiding possible > errors. welcome for ideas on a better fix. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] microblaze: usable uart16550 for big endian systems
Stephan Linz wrote:
Am Mittwoch, den 23.11.2011, 15:40 +0100 schrieb Michal Simek:
Hi Stephan,
Stephan Linz wrote:
As a result of the commit 6833260 the uart16550 driver
is broken for Microblaze big endian systems, because of
the missing 3 byte offset. Other than as described, the
U-Boot BSP does not treat properly the 3 byte offset.
However, with the new 32 bit access to ns16550 registers
we can enable correct register access for Microblaze big
and little endian systems in the same manner.
The reason why I have applied that patch is that baseaddress generation
was moved to u-boot BSP out of u-boot configs.
--snip--
Anyway you solution looks interesting and I will test it.
However since commit 79df120 we can use direct 32 bit access to 8 bit
NS16550 registers without gap generation in ns16550.h ... we need sane
in_*/out_* implementation.
I have look at it and tested on BE/LE. For 32bit accesses we need to implement
in/out_le32 functions which we don't have right now
Hi Michal,
Oh yes, of course. There are no *_le32 operations, not yet.
that's why please remove this macro
from your patch.
Our BSP generates/ed +3 offset that's why I prefer to mask it in the same patch
to be sure that baseaddr is correct and compatible with old versions.
Here is patch I have used. Please add that changes to v2 patch.
I'll do it this way. Give me a little time to change and test it.
Currently I am sill working on refactoring of the LL TEMAC driver. I
hope, the refactored driver than can merge in mainline ...
I have done it some time ago and look at "[PATCH v3] net: ll_temac: Add LL TEMAC
driver to u-boot thread".
I have attached the latest version I have and I am not going to change it to
follow
"new" u-boot network driver style because I would like to keep ppc dcr support.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
/*
* Xilinx xps_ll_temac ethernet driver for u-boot
*
* Copyright (C) 2008 - 2011 Michal Simek
* Copyright (C) 2008 - 2011 PetaLogix
*
* Based on Yoshio Kashiwagi kashiw...@co-nss.co.jp driver
* Copyright (C) 2008 Nissin Systems Co.,Ltd.
* March 2008 created
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
*/
#include
#include
#include
#include
#include
#include
#include
#include
#undef ETH_HALTING
#if !defined(CONFIG_PHYLIB)
# error LL_TEMAC requires PHYLIB
#endif
#define XTE_EMMC_LINKSPEED_MASK 0xC000 /* Link speed */
/* XTE_EMCFG_LINKSPD_MASK */
#define XTE_EMMC_LINKSPD_10 0x /* for 10 Mbit */
#define XTE_EMMC_LINKSPD_100 0x4000 /* for 100 Mbit */
#define XTE_EMMC_LINKSPD_1000 0x8000 /* forr 1000 Mbit */
#define XTE_RSE_MIIM_RR_MASK 0x0002
#define XTE_RSE_MIIM_WR_MASK 0x0004
#define XTE_RSE_CFG_RR_MASK 0x0020
#define XTE_RSE_CFG_WR_MASK 0x0040
/* XPS_LL_TEMAC indirect registers offset definition */
#define RCW1 0x240
#define TC 0x280
#define EMMC 0x300
#define MC 0x340
#define UAW0 0x380
#define UAW1 0x384
#define AFM 0x390
#define MIIMWD 0x3b0
#define MIIMAI 0x3b4
#define CNTLREG_WRITE_ENABLE_MASK 0x8000
#define MDIO_ENABLE_MASK 0x40
#define MDIO_CLOCK_DIV_100MHz 0x28
/* XPS_LL_TEMAC SDMA registers definition */
#define TX_CURDESC_PTR 0x03
#define TX_TAILDESC_PTR 0x04
#define TX_CHNL_CTRL 0x05
#define TX_IRQ_REG 0x06
#define TX_CHNL_STS 0x07
#define RX_NXTDESC_PTR 0x08
#define RX_CURDESC_PTR 0x0b
#define RX_TAILDESC_PTR 0x0c
#define RX_CHNL_CTRL 0x0d
#define RX_IRQ_REG 0x0e
#define RX_CHNL_STS 0x0f
#define DMA_CONTROL_REG 0x10
/* DMA control bit */
#define DMA_CONTROL_RESET 0x1
/* CDMAC descriptor status bit definitions */
# define BDSTAT_STOP_ON_END_MASK 0x20
# define BDSTAT_COMPLETED_MASK 0x10
# define BDSTAT_SOP_MASK 0x08
# define BDSTAT_EOP_MASK 0x04
# define CHNL_STS_ERROR_MASK 0x80
/* All interrupt enable bits */
#define XLLDMA_CR_IRQ_ALL_EN_MASK 0x0087
/* All interrupt bits */
#define XLLDMA_IRQ_ALL_MASK 0x001F
/* Disable error when 2 or 4 bit coalesce counter overflows */
#define XLLDMA_DMACR_RX_OVERFLOW_ERR_DIS_MASK 0x0010
/* Disable error when 2 or 4 bit coalesce counter overflows */
#define XLLDMA_DMACR_TX_OVERFLOW_ERR_DIS_MASK 0x0008
/* Enable use of tail pointer register */
#define XLLDMA_DMACR_TAIL_PTR_EN_MASK 0x0004
#define LL_FIFO_ISR_RC_COMPLETE 0x0400
#define SDMA_BIT 1
#define DCR_BIT 2
#define DMAALIGN 32
/* SDMA Buffer Descriptor */
struct cdmac_bd_t {
struct cdmac_bd_t *next_p;
unsigned char *phys_buf_p;
unsigned long buf_len;
unsigned char stat;
unsigned char app1_1;
unsigned short app1_2;
unsigned long app2;
unsigned long app3;
unsigned long app4;
unsigned long app5;
};
static struct cdmac_bd_t tx_bd __attribute(
Re: [U-Boot] [PATCH 6/6] tegra: Fix build error in plutux, medcom
* Simon Glass wrote:
> We need to define CONFIG_ENV_IS_NOWHERE to avoid this error:
>
> cmd_nvedit.c:69:3: error: #error Define one of
> CONFIG_ENV_IS_IN_{EEPROM|FLASH|DATAFLASH|ONENAND|SPI_FLASH|MG_DISK|NVRAM|MMC}
> or CONFIG_ENV_IS_NOWHERE
Odd. I haven't seen this before when building both boards. Perhaps this was
introduced by some other patch I don't have applied. Anyway, thanks for
fixing this.
Thierry
pgp2qek60tuOK.pgp
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] microblaze: usable uart16550 for big endian systems
Am Donnerstag, den 24.11.2011, 20:13 +0100 schrieb Michal Simek: > Stephan Linz wrote: > >--snip-- > >> > >> Here is patch I have used. Please add that changes to v2 patch. > > > > I'll do it this way. Give me a little time to change and test it. > > Currently I am sill working on refactoring of the LL TEMAC driver. I > > hope, the refactored driver than can merge in mainline ... > > I have done it some time ago and look at "[PATCH v3] net: ll_temac: > Add LL TEMAC driver to u-boot thread". Hi Michal, yes, I've read the whole thread. > I have attached the latest version I have and I am not going to change > it to follow "new" u-boot network driver style Hm, but it is possible ... > because I would like to keep ppc dcr support. Even this was the main work I've done last week. I've split the driver code into differnt sub modules (xilinx_ll_temac_fifo and xilinx_ll_temac_sdram), introduce some call back functions into the sub modules to harmonize the main driver code and divide the sdma code into the two different bus access methodes: direct 32 bit memory access (Microblaze) and indirect access via DCR (Xilinx PPC4xx). Please, give me some time to finish the refactoring. I'll release all results as fast as possible her in U-Boot list. But, one issue was uncleare to me. Some functions, for example xps_ll_temac_hostif_set(), were prepared to set bit 10 of CTL register. But CTL bit 10 is not defined by any LL TEMAC documentation. Why did you done this? Thanks, Stephan > > Thanks, > Michal > > -- > Michal Simek, Ing. (M.Eng) > w: www.monstr.eu p: +42-0-721842854 > Maintainer of Linux kernel 2.6 Microblaze Linux - > http://www.monstr.eu/fdt/ > Microblaze U-BOOT custodian -- Viele Grüße, Stephan Linz __ MB-Ref: http://www.li-pro.de/xilinx_mb:mbref:start OpenDCC: http://www.li-pro.net/opendcc.phtml PC/M: http://www.li-pro.net/pcm.phtml Sourceforge: http://sourceforge.net/users/slz Gitorious: https://gitorious.org/~slz ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 2/2] ARM: omap3: add support to Technexion twister board
Dear Stefano Babic, In message <1322149442-16555-2-git-send-email-sba...@denx.de> you wrote: > The twister board is a development board using > the TAM3517 SOM. > > Support for NAND, 2 Ethernet (EMAC and SMC911), > USB (EHCI_OMAP). ... Nitpick: > +#define xstr(s) str(s) > +#define str(s) #s It appears neither of these is actuallyused any more in this header file? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "All my life I wanted to be someone; I guess I should have been more specific." - Jane Wagner ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 1/2] ARM: omap3: added common configuration for Technexion TAM3517
Dear Stefano Babic, In message <1322149442-16555-1-git-send-email-sba...@denx.de> you wrote: > The TAM3517 is a SOM module that can be used on custom boards. > The patch add a common configuration file that is included > by the boards using this module. ... > diff --git a/include/configs/tam3517-common.h > b/include/configs/tam3517-common.h > new file mode 100644 > index 000..f972592 ... > + "hostname=" xstr(CONFIG_HOSTNAME) "\0" \ > + "bootfile=" xstr(CONFIG_HOSTNAME) "/uImage\0" \ Here you rely on xstr() being defined in some higher level header file. That's not a good idea. Please mode the definitions into this common header, and drop it in the other file(s). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Premature optimization is the root of all evil. -- D.E. Knuth ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] M28: Document that units has to be set to sectors on SD bootcard
Dear Marek Vasut, In message <1322153845-19369-1-git-send-email-marek.va...@gmail.com> you wrote: > Signed-off-by: Marek Vasut > Cc: Stefano Babic > Cc: Wolfgang Denk > --- > doc/README.m28 |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/doc/README.m28 b/doc/README.m28 > index b749ce0..242230b 100644 > --- a/doc/README.m28 > +++ b/doc/README.m28 > @@ -116,6 +116,12 @@ must have the following parameters: > For example in Linux fdisk, the sequence for a clear card is the following: > > * o . create a clear partition table > + * p . here you need to verify that units is set to > + sectors. In the output, earch for a line > + containing: > + Units = sectors of 1 * 512 = 512 bytes > + If no such line is present, press "u" to > + switch units to sectors. > * n . create new partition > * p . primary partition > * 1 . first partition Would it not make sense to actually make sure this is the case, like by passing the "-u" option to fdisk ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A person with one watch knows what time it is; a person with two watches is never sure. Proverb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] drivers/bios_emulator/x86emu/ops2.c: Fix GCC 4.6 build warning
Dear Marek Vasut, In message <20241814.34611.marek.va...@gmail.com> you wrote: > > > -char *name = 0; > > +__maybe_unused char *name = 0; > > I don't like this __maybe_unused stuff, it seems like you're hiding possible > errors. I don't like it either, but there are cases where this is the cheapest way to get the code clean again, and still working. If you have a better proposal to make this file compile clean, without using __maybe_unused, then please post your patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How come everyone's going so slow if it's called rush hour? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: a320evb: define mach-type in board config file
On Tue, 8 Nov 2011 13:40:25 +0800 Andrew Chen wrote: > From: Yan-Pai Chen > > MACH_TYPE_FARADAY was dropped from mach-types.h. Add it back to > board config file. > > Signed-off-by: Yan-Pai Chen > --- > board/faraday/a320evb/a320evb.c |1 - > include/configs/a320evb.h |6 ++ > 2 files changed, 6 insertions(+), 1 deletions(-) Applied to u-boot-staging ag...@denx.de. Thanks! Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] davinci_sonata: define CONFIG_MACH_TYPE for davinci_sonata board
On Sat, 19 Nov 2011 11:45:43 +0100 Christian Riesch wrote: > This patch fixes the build breakage for the davinci_sonata board. > > Signed-off-by: Christian Riesch > Cc: Sergey Kubushyn > Cc: Sandeep Paulraj > --- > board/davinci/sonata/sonata.c|3 --- > include/configs/davinci_sonata.h |2 ++ > 2 files changed, 2 insertions(+), 3 deletions(-) Applied to u-boot-staging ag...@denx.de. Thanks! Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] davinci_schmoogie: define CONFIG_MACH_TYPE for davinci_schmoogie board
On Sat, 19 Nov 2011 11:45:42 +0100 Christian Riesch wrote: > This patch fixes the build breakage for the davinci_schmoogie board. > > Signed-off-by: Christian Riesch > Cc: Sergey Kubushyn > Cc: Sandeep Paulraj > --- > board/davinci/schmoogie/schmoogie.c |3 --- > include/configs/davinci_schmoogie.h |3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-staging ag...@denx.de. Thanks! Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] tools/os_support: add OS X Lion support
OS X Lion's c-library implements getline(), therefore prevent including the old helper implementation for __DARWIN_C_LEVEL < 200809L. Without this patch following error occours: ---8<--- In file included from os_support.h:32, from img2srec.c:55: getline.h:1: error: conflicting types for ‘getline’ /usr/include/stdio.h:449: error: previous declaration of ‘getline’ was here --->8--- Signed-off-by: Andreas Bießmann --- total: 0 errors, 0 warnings, 15 lines checked NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE 0001-tools-os_support-add-OS-X-Lion-support.patch has no obvious style problems and is ready for submission. tools/os_support.c |2 +- tools/os_support.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/os_support.c b/tools/os_support.c index 1ed89e6..319c0fe 100644 --- a/tools/os_support.c +++ b/tools/os_support.c @@ -23,6 +23,6 @@ #ifdef __MINGW32__ #include "mingw_support.c" #endif -#ifdef __APPLE__ +#if defined(__APPLE__) && __DARWIN_C_LEVEL < 200809L #include "getline.c" #endif diff --git a/tools/os_support.h b/tools/os_support.h index 7dcbee4..5bf7add 100644 --- a/tools/os_support.h +++ b/tools/os_support.h @@ -28,7 +28,7 @@ #include "mingw_support.h" #endif -#ifdef __APPLE__ +#if defined(__APPLE__) && __DARWIN_C_LEVEL < 200809L #include "getline.h" #endif -- 1.7.7.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] hawkboard: Replace HAWKBOARD_KICK{0, 1}_UNLOCK defines
On Sat, 19 Nov 2011 11:45:44 +0100
Christian Riesch wrote:
> This patch replaces the HAWKBOARD_KICK{0,1}_UNLOCK defines by
> DV_SYSCFG_KICK{0,1}_UNLOCK.
>
> The kick register values are not hawkboard specific but may be used
> for all davinci boards. In commit f3c149d6c6e5ba8dd72baa86fe527837e4fb0e9a
> new defines for these values wer introduced.
>
> Signed-off-by: Christian Riesch
> Cc: Syed Mohammed Khasim
> Cc: Sughosh Ganu
> Cc: Sandeep Paulraj
> ---
> arch/arm/include/asm/arch-davinci/davinci_misc.h |3 ---
> board/davinci/da8xxevm/hawkboard.c |4 ++--
> board/davinci/da8xxevm/hawkboard_nand_spl.c |4 ++--
> 3 files changed, 4 insertions(+), 7 deletions(-)
Applied to u-boot-staging ag...@denx.de. Thanks!
Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] CFB: Fix font rendering on mx5 framebuffer
On Thu, 24 Nov 2011 03:32:16 +0100 Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Anatolij Gustschin > Cc: Stefano Babic > --- > drivers/video/cfb_console.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied to u-boot-video/master. Thanks! Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] DIU: 1080P and 720P support
On Wed, 2 Nov 2011 09:16:43 +0800 wrote: > From: Jerry Huang > > Add the 1920x1080 and 1280x720 resolution support. > > Acked-by: Timur Tabi > > Signed-off-by: Jerry Huang > CC: Anatolij Gustschin > --- > drivers/video/fsl_diu_fb.c | 38 ++ > 1 files changed, 38 insertions(+), 0 deletions(-) Applied to u-boot-video/master. Thanks! Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] yet another arm mach-types.h thread
Hi, As there was no real conclusion on my previous "arm mach-types.h" thread, i have to reemphasize that the current mach types handling is broken. 1. u-boot follows linux mach-types.h 2. linux only includes ids a, they have (non DT!) board support for or b, id which are not older than 12 months. Now there are the following cases with problems: - boards which have no linux support but uboot support - boards which have only dt support within linux. uboot won't be able to boot these board with older kernels, which do not have dt support, but instead still using the old-fashioned setup code. - boards which have only dt support in mainline kernel but have been backported to older kernels and old-fashioned setup code. - there will always be regressions when pulling the newest mach-types.h from linux The proposed solution was to add the ID to the board config. Why not put all ids into the board configs then and remove the mach-types.h? Maybe you want to have database with all ids? But with tracking the linux mach-types.h you always have the database with boards _linux mainline_ supports and not the boards uboot supports. Something seems to be broken there :) IMHO either you say - you have a database, that way you have to include the ids _you_ support or - you don't have such a file and have the ids scattered all across the board configs. -- Michael ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] drivers/bios_emulator/x86emu/ops2.c: Fix GCC 4.6 build warning
Hi, > Dear Marek Vasut, > > In message <20241814.34611.marek.va...@gmail.com> you wrote: > > > -char *name = 0; > > > +__maybe_unused char *name = 0; > > > > I don't like this __maybe_unused stuff, it seems like you're hiding > > possible errors. > > I don't like it either, but there are cases where this is the cheapest > way to get the code clean again, and still working. > > If you have a better proposal to make this file compile clean, without > using __maybe_unused, then please post your patch. > Honestly, not right now. I'd prefer to work on other stuff that's slightly more important (mx51usb, bootz ... pile of other stuff). This patch is of moderate importance to me (which means I'll think about it when I'm idle). Anyway, from now on, I'd like to try picking up gcc4.6 fixes (as I started whole this machinery with the debug() macro changes) and start pushing it through - staging. Are you against it? M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] M28: Document that units has to be set to sectors on SD bootcard
> Dear Marek Vasut, > > In message <1322153845-19369-1-git-send-email-marek.va...@gmail.com> you wrote: > > Signed-off-by: Marek Vasut > > Cc: Stefano Babic > > Cc: Wolfgang Denk > > --- > > > > doc/README.m28 |6 ++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/doc/README.m28 b/doc/README.m28 > > index b749ce0..242230b 100644 > > --- a/doc/README.m28 > > +++ b/doc/README.m28 > > > > @@ -116,6 +116,12 @@ must have the following parameters: > > For example in Linux fdisk, the sequence for a clear card is the following: > > * o . create a clear partition table > > > > + * p . here you need to verify that units is set to > > + sectors. In the output, earch for a line > > + containing: > > + Units = sectors of 1 * 512 = 512 bytes > > + If no such line is present, press "u" to > > + switch units to sectors. > > > > * n . create new partition > > > > * p . primary partition > > * 1 . first partition > > Would it not make sense to actually make sure this is the case, like > by passing the "-u" option to fdisk ? Definitelly, please check v3 of the patch. Fabio was so kind to check my grammar issues etc ;-) M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] microblaze: usable uart16550 for big endian systems
As a result of the commit 6833260 the uart16550 driver is broken for Microblaze big endian systems, because of the missing 3 byte offset. Other than as described, not all U-Boot BSP will treat properly the 3 byte offset. This why prefer to mask out the 3 byte offset in general and setup correct _REG_SIZE value depending on edianess. Signed-off-by: Stephan Linz --- v2: Mask out 3 byte offset Set correct _REG_SIZE values for big/little endianess --- include/configs/microblaze-generic.h |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h index 6b3fd76..03a6f5a 100644 --- a/include/configs/microblaze-generic.h +++ b/include/configs/microblaze-generic.h @@ -41,10 +41,14 @@ #elif XILINX_UART16550_BASEADDR # define CONFIG_SYS_NS165501 # define CONFIG_SYS_NS16550_SERIAL -# define CONFIG_SYS_NS16550_REG_SIZE -4 +# if defined(__MICROBLAZEEL__) +# define CONFIG_SYS_NS16550_REG_SIZE -4 +# else +# define CONFIG_SYS_NS16550_REG_SIZE 4 +# endif # define CONFIG_CONS_INDEX 1 # define CONFIG_SYS_NS16550_COM1 \ - (XILINX_UART16550_BASEADDR + 0x1000) + ((XILINX_UART16550_BASEADDR & ~0xF) + 0x1000) # define CONFIG_SYS_NS16550_CLKXILINX_UART16550_CLOCK_HZ # define CONFIG_BAUDRATE 115200 -- 1.7.0.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V2 1/2] ARM: omap3: added common configuration for Technexion TAM3517
Am 24/11/2011 21:43, schrieb Wolfgang Denk: >> +"hostname=" xstr(CONFIG_HOSTNAME) "\0" \ >> +"bootfile=" xstr(CONFIG_HOSTNAME) "/uImage\0" \ > > Here you rely on xstr() being defined in some higher level header > file. This was not thought, I miss to move it, thanks for pointing out > That's not a good idea. ..it's a very bad idea > Please mode the definitions into this > common header, and drop it in the other file(s). I do it Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] M5282EVB undefined reference to `environment'
On 24/11/11 17:36, Igor Grinberg wrote: On 11/24/11 01:58, James Steward wrote: Hi Igor, On 23/11/11 23:19, Igor Grinberg wrote: Hi James, On 11/22/11 07:22, James Steward wrote: On 22/11/11 15:51, Marek Vasut wrote: Hi, I'm trying to build U-Boot for the above mentioned board. Basically, I've done the following on a Ubuntu 10.04: wget https://sourcery.mentor.com/public/gnu_toolchain/m68k-elf/freescale-coldfir e-4.4-215-m68k-elf-i686-pc-linux-gnu.tar.bz2 sudo tar xvfj freescale-coldfire-4.4-215-m68k-elf-i686-pc-linux-gnu.tar.bz2 -C /opt export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/free scale-coldfire-4.4/bin |sudo apt-get install git-core mkdir /home/james/u-boot-git&&cd ||/home/james/u-boot-git git clone ||git://git.denx.de/u-boot-coldfire.git ||cd u-boot-coldfire || ||make clean make M5282EVB_config try ./MAKEALL M5282EVB ... I suspect you don't have CROSS_COMPILE=your-crosscc- prefix variable set, and maybe ARCH=m68k variable too. I didn't have those env vars set, however now with them set, and the latest codesourcery compiler I get the same error; export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/freescale-coldfire-2011.09/bin export CROSS_COMPILE=m68k-elf- export ARCH=m68k ./MAKEALL M5282EVB Configuring for M5282EVB board... cmd_nvedit.c: In function 'do_env_export': cmd_nvedit.c:748:3: warning: format '%zX' expects argument of type 'size_t', but argument 3 has type 'unsigned int' [-Wformat] cmd_nvedit.c:774:2: warning: format '%zX' expects argument of type 'size_t', but argument 3 has type 'unsigned int' [-Wformat] cmd_nvedit.c: In function 'do_env_import': cmd_nvedit.c:865:3: warning: format '%zd' expects argument of type 'signed size_t', but argument 2 has type 'size_t' [-Wformat] cmd_nvedit.c:865:3: warning: format '%zX' expects argument of type 'size_t', but argument 3 has type 'unsigned int' [-Wformat] mcfmii.c: In function 'mcffec_miiphy_write': mcfmii.c:318:8: warning: variable 'rdreg' set but not used [-Wunused-but-set-variable] common/libcommon.o:(.data.rel.env_ptr+0x0): undefined reference to `environment' make: *** [u-boot] Error 1 m68k-elf-size: './u-boot': No such file - SUMMARY Boards compiled: 1 Boards with warnings or errors: 1 ( M5282EVB ) -- Any other thoughts? Do I need to define something to configure the environment to flash or something? Do you have CONFIG_ENV_IS_EMBEDDED set? A search with grep CONFIG_ENV_IS_EMBEDDED `find . -name "*.h"` indicates the answer is no. Should it be set? AFAIK, environment variable is used only when you have ENV_IS_EMBEDDED set. Also, there is some logic in the include/environment.h files (in current master line 64), that decides whether to set this automatically or not. With grep CONFIG_ENV_IS_ `find . -name "*.h"` in include/configs/M5282EVB.h, I see #define CONFIG_ENV_IS_IN_FLASH1 So looking in that file I see: /* Configuration for environment * Environment is embedded in u-boot in the second sector of the flash */ #define CONFIG_ENV_ADDR 0xffe04000 #define CONFIG_ENV_SIZE 0x2000 #define CONFIG_ENV_IS_IN_FLASH 1 Look at the logic in environment.h to check if ENV_IS_EMBEDDED gets set in your case. Indeed... # if (CONFIG_ENV_ADDR >= CONFIG_SYS_MONITOR_BASE) && \ (CONFIG_ENV_ADDR+CONFIG_ENV_SIZE) <= (CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN) # define ENV_IS_EMBEDDED 1 #error "Defining ENV_IS_EMBEDDED" # endif produces include/environment.h:66:2: error: #error "Defining ENV_IS_EMBEDDED" So this is saying that if the environment exists within the flash space allocated to u-boot, make it so embedded. Ok, fine, so in common/env_flash.c I see; #ifdef ENV_IS_EMBEDDED env_t *env_ptr = &environment; static env_t *flash_addr = (env_t *)CONFIG_ENV_ADDR; #else /* ! ENV_IS_EMBEDDED */ I guess the variable environment is not defined, but where should it be defined? There are a lot of hits when I search. This is pure unadulterated coldfire git source that will not build out of the box. I assumed I was doing something wrong. But it seems there is really a bug in the default configuration for this board? Could be... It is extremely hard to understand what's going on when the source code is a kind of divergence from upstream. Also, there is a possibility that ENV_IS_EMBEDDED is broken for some time already. Ok, I just grabbed u-boot.git instead and ... common/libcommon.o:(.data.rel.env_ptr+0x0): undefined reference to `environment' Where do I look next? General remark and question: After building a multitude of open source projects for x86 and cross compiling for ARM, including cross compiling the Linux kernel and writing some simple kernel drivers, and writing bare metal code for the likes of the STM32 and including CanFestival, for example, U-boot has been
[U-Boot] x86 patches - status update
Hi Gabe, I tried to submit those patches today, but I somehow managed to make a complete mess of the x86 repo - It now have a bunch of duplicate patches Please do not rebase anything against u-boot-x86 until the mess has been sorted out Sorry for the inconvenience If anyone wants to have a look at just how badly you can mess up git when you don't know what your doing: http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-x86.git;a=commitdiff;h=b884e5f1546781b95a10bcaa1062b1bb6dda2fe7 http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-x86.git;a=commitdiff;h=11e88e35419104c76fa6ea9ef289f1c5c842e2b7 Regards, Graeme ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] S5PC2XX: Rename S5pc2XX to exynos4
Dear Chander Kashyap,
On 24 November 2011 19:48, Chander Kashyap wrote:
> As per new conventions Samsung SoC's are named as Exynos.
> Cortex-A9 based Soc's are named as exynos4. s5pc2xx is cortex-A9
> based, hence renamed to exynos4. This is done as per kernel
> naming convetions.
>
> Similerly s5pc210 is now exynos4210. Hence S5PC210/s5pc210
> suffix/prefix has been renamed to EXYNOS4210/exynos4210.
>
> Signed-off-by: Chander Kashyap
> ---
> Changes for v2:
> - Removed renaming of s5p-common to exynos4-common
> - Renamed s5pc210 prefixes to exynos4210
>
> MAINTAINERS | 6 +-
> Makefile | 2 +-
> arch/arm/cpu/armv7/{s5pc2xx => exynos4}/Makefile | 0
> arch/arm/cpu/armv7/{s5pc2xx => exynos4}/clock.c | 50
> arch/arm/cpu/armv7/{s5pc2xx => exynos4}/soc.c | 0
> .../asm/{arch-s5pc2xx => arch-exynos4}/adc.h | 0
> .../asm/{arch-s5pc2xx => arch-exynos4}/clk.h | 0
> .../asm/{arch-s5pc2xx => arch-exynos4}/clock.h | 2 +-
> .../asm/{arch-s5pc2xx => arch-exynos4}/cpu.h | 62
> ++--
> .../asm/{arch-s5pc2xx => arch-exynos4}/gpio.h | 28 +-
> .../asm/{arch-s5pc2xx => arch-exynos4}/mmc.h | 0
> .../asm/{arch-s5pc2xx => arch-exynos4}/pwm.h | 0
> .../asm/{arch-s5pc2xx => arch-exynos4}/sromc.h | 0
> .../asm/{arch-s5pc2xx => arch-exynos4}/sys_proto.h | 0
> .../asm/{arch-s5pc2xx => arch-exynos4}/uart.h | 0
> board/samsung/origen/lowlevel_init.S | 26
> board/samsung/origen/mem_setup.S | 12 ++--
> board/samsung/origen/origen.c | 8 +-
> board/samsung/origen/origen_setup.h | 8 +-
> board/samsung/smdkv310/lowlevel_init.S | 22
> board/samsung/smdkv310/mem_setup.S | 8 +-
> board/samsung/smdkv310/smdkv310.c | 8 +-
> board/samsung/universal_c210/lowlevel_init.S | 24
> board/samsung/universal_c210/universal.c | 8 +-
> boards.cfg | 6 +-
> include/configs/origen.h | 6 +-
> include/configs/s5pc210_universal.h | 10 ++--
> include/configs/smdkv310.h | 6 +-
> 28 files changed, 151 insertions(+), 151 deletions(-)
> rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/Makefile (100%)
> rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/clock.c (80%)
> rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/soc.c (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/adc.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/clk.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/clock.h (99%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/cpu.h (64%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/gpio.h (83%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/mmc.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/pwm.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/sromc.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/sys_proto.h (100%)
> rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/uart.h (100%)
>
Applying: S5PC2XX: Rename S5pc2XX to exynos4
error: patch failed: boards.cfg:195
error: boards.cfg: patch does not apply
Patch failed at 0001 S5PC2XX: Rename S5pc2XX to exynos4
I couldn't test your patch.
Please remake the patch.
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] mx28: Saving env vars on MMC
Hi, I am trying to save environment variables on a SD card of a MX28EVK board. 'save' command reports no errors, but if I reboot the board then the board no longer boots. In order to recover the boot, I need to reformat the SD card and reflash the u-boot.sd image. I am trying the following configuration taken from FSL U-boot: /* * MMC Driver */ #define CONFIG_ENV_IS_IN_MMC #define CONFIG_ENV_OFFSET 0x400 #define CONFIG_ENV_SIZE 0x2 - 0x400 #define CONFIG_SYS_MMC_ENV_DEV 0 #ifdef CONFIG_CMD_MMC #define CONFIG_MMC #define CONFIG_GENERIC_MMC #define CONFIG_MXS_MMC #endif Not sure on the CONFIG_ENV_OFFSET and CONFIG_ENV_SIZE values. Has anyone tried saving env vars on MX28? Any suggestions? Thanks, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef
On Thu, Nov 24, 2011 at 8:11 PM, Wolfgang Denk wrote: > Dear Jason Hui, > > In message > you > wrote: >> >> I'm just get confused. It seems from you that we can both use: >> CONFIG_option and CONFIG_SYS_ in this patch? right? > > It's one of those boarder cases. But given that we don't actually set > hardware related values (say, initial data for registers) here, but > select from a set of pre-defined options (UART1_BASE etc.) it seems OK > to me to handle this as Stefano suggested, i. e. as > CONFIG_MXC_UART_BASE . OK, thanks Wolfgang. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > You Don't Have To Be 'Damned' To Work Here, But It Helps!!! > - Terry Pratchett, _Eric_ > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Hoe to configure u-boot for NIOS-2 processor
On 10/31/2011 02:13 PM, Purushothamrao wrote: Kindly guide me how to configure u-boot to generate u-boot.bin for NIOS-2 processor. Dear Purushothamrao, Please follow the wiki page, http://alterawiki.com/wiki/DasUBoot Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Adding support to Technexion TAM3517 SOM
On Thu, 24 Nov 2011 16:19:26 +0100 Stefano Babic wrote: > On 24/11/2011 07:57, Tapani Utriainen wrote: > > Using your u-boot.bin on Twister, USB devices do not work in linux. Using > > the u-boot.bin I submitted this issue disappears. The setup is otherwise > > the > > same (same x-loader, u-boot settings, kernel and userland). > > I cannot confirm this issue - I am running the 2.6.32 kernel (compiled > from sources), and USB is working: > Recompiled our kernel as well (was using someone elses pre-compiled earlier) and tried again. No difference. What steps did you take to verify that USB is working? For instance: I cannot mount/read a USB stick in linux when using your u-boot. No problems using ours. You might very well be right that this difference is due to errors in our u-boot *and* our kernel. I have not verified the MUX setup etc, just (maybe foolishly) trusted that the settings we have had working for long time (since before me starting here) are somewhat correct. Would be tragic if two so crazy errors makes it work. :-( //Tapani ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef
On Tue, Nov 22, 2011 at 11:51 PM, Stefano Babic wrote: > The serial driver for iMX SOCs is continuosly changed if a > new SOC or not yet used port is used. CONFIG_SYS__ > defines were used only to find the base address for the selected UART. > Instead of that, move the base address to the board configuration > file and drop all #ifdef from driver. > > Signed-off-by: Stefano Babic > CC: Marek Vasut > CC: Wolfgang Denk > CC: Fabio Estevam > CC: Helmut Raiger > CC: John Rigby > CC: Matthias Weisser > CC: Jason Liu > --- > arch/arm/cpu/arm1136/mx31/devices.c | 4 --- > arch/arm/include/asm/arch-mx25/imx-regs.h | 10 > arch/arm/include/asm/arch-mx27/imx-regs.h | 8 +++--- > arch/arm/include/asm/arch-mx31/imx-regs.h | 6 > arch/arm/include/asm/arch-mx35/imx-regs.h | 6 ++-- > arch/arm/include/asm/arch-mx5/imx-regs.h | 6 ++-- > drivers/serial/serial_mxc.c | 37 +++- > include/configs/efikamx.h | 2 +- > include/configs/flea3.h | 2 +- > include/configs/imx27lite-common.h | 2 +- > include/configs/imx31_litekit.h | 4 +- > include/configs/imx31_phycore.h | 2 +- > include/configs/mx25pdk.h | 2 +- > include/configs/mx31ads.h | 4 +- > include/configs/mx31pdk.h | 2 +- > include/configs/mx35pdk.h | 2 +- > include/configs/mx51evk.h | 2 +- > include/configs/mx53ard.h | 2 +- > include/configs/mx53evk.h | 2 +- > include/configs/mx53loco.h | 2 +- > include/configs/mx53smd.h | 2 +- > include/configs/qong.h | 4 +- > include/configs/tt01.h | 2 +- > include/configs/tx25.h | 2 +- > include/configs/vision2.h | 2 +- > include/configs/zmx25.h | 2 +- > 26 files changed, 47 insertions(+), 74 deletions(-) Acked-by: Jason Liu [..] ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] (no subject)
DO YOU NEED A LOAN? CONTACT US VIA APPLICATION.___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [Almost solved] M5282EVB undefined reference to `environment'
On 24/11/11 17:36, Igor Grinberg wrote: On 11/24/11 01:58, James Steward wrote: A search with grep CONFIG_ENV_IS_EMBEDDED `find . -name "*.h"` indicates the answer is no. Should it be set? AFAIK, environment variable is used only when you have ENV_IS_EMBEDDED set. Also, there is some logic in the include/environment.h files (in current master line 64), that decides whether to set this automatically or not. With grep CONFIG_ENV_IS_ `find . -name "*.h"` in include/configs/M5282EVB.h, I see #define CONFIG_ENV_IS_IN_FLASH 1 So looking in that file I see: /* Configuration for environment * Environment is embedded in u-boot in the second sector of the flash */ #define CONFIG_ENV_ADDR 0xffe04000 #define CONFIG_ENV_SIZE 0x2000 #define CONFIG_ENV_IS_IN_FLASH 1 Look at the logic in environment.h to check if ENV_IS_EMBEDDED gets set in your case. objdump -t common/env_embedded.o | grep environment 0004 g O .text 2000 environment objdump -t common/libcommon.o | grep environment ld .rodata.default_environment .rodata.default_environment *UND* environment g O .rodata.default_environment0163 default_environment So environment is undefined in libcommon.o, but is in env_embedded.o. From make all I see; m68k-elf-ld -n -r -o libcommon.o cmd_bdinfo.o cmd_boot.o cmd_bootm.o cmd_cache.o cmd_console.o cmd_echo.o cmd_flash.o cmd_help.o cmd_itest.o cmd_load.o cmd_mem.o cmd_mii.o cmd_misc.o cmd_net.o cmd_nvedit.o cmd_pcmcia.o cmd_source.o cmd_version.o cmd_ximg.o command.o console.o dlmalloc.o env_common.o env_flash.o exports.o flash.o image.o main.o memsize.o miiphyutil.o s_record.o stdio.o xyzModem.o So it compiles env_embedded.c, but doesn't include it in libcommon.o? vim common/Makefile XCOBJS-$(CONFIG_ENV_IS_IN_FLASH) += env_embedded.o becomes COBJS-$(CONFIG_ENV_IS_IN_FLASH) += env_embedded.o :q make all Hey, presto, build now completes! So how should this be corrected properly? Regards, James. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] S5PC2XX: Rename S5pc2XX to exynos4
As per new conventions Samsung SoC's are named as Exynos.
Cortex-A9 based Soc's are named as exynos4. s5pc2xx is cortex-A9
based, hence renamed to exynos4. This is done as per kernel
naming convetions.
Similerly s5pc210 is now exynos4210. Hence S5PC210/s5pc210
suffix/prefix has been renamed to exynos4210/EXYNOS4210
Signed-off-by: Chander Kashyap
---
Changes for v2:
- Removed renaming of s5p-common to exynos4-common
- Renamed s5pc210 prefixes to exynos4210
Rebased on following commit.
19cdfd3e84bff108febb127b598ac3f1634c768c
"Ethernut 5 board support"
MAINTAINERS|6 +-
Makefile |2 +-
arch/arm/cpu/armv7/{s5pc2xx => exynos4}/Makefile |0
arch/arm/cpu/armv7/{s5pc2xx => exynos4}/clock.c| 50
arch/arm/cpu/armv7/{s5pc2xx => exynos4}/soc.c |0
.../asm/{arch-s5pc2xx => arch-exynos4}/adc.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/clk.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/clock.h |2 +-
.../asm/{arch-s5pc2xx => arch-exynos4}/cpu.h | 62 ++--
.../asm/{arch-s5pc2xx => arch-exynos4}/gpio.h | 28 +-
.../asm/{arch-s5pc2xx => arch-exynos4}/mmc.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/pwm.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/sromc.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/sys_proto.h |0
.../asm/{arch-s5pc2xx => arch-exynos4}/uart.h |0
board/samsung/origen/lowlevel_init.S | 26
board/samsung/origen/mem_setup.S | 12 ++--
board/samsung/origen/origen.c |8 +-
board/samsung/origen/origen_setup.h|8 +-
board/samsung/smdkv310/lowlevel_init.S | 22
board/samsung/smdkv310/mem_setup.S |8 +-
board/samsung/smdkv310/smdkv310.c |8 +-
board/samsung/universal_c210/lowlevel_init.S | 24
board/samsung/universal_c210/universal.c |8 +-
boards.cfg |6 +-
include/configs/origen.h |6 +-
include/configs/s5pc210_universal.h| 10 ++--
include/configs/smdkv310.h |6 +-
28 files changed, 151 insertions(+), 151 deletions(-)
rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/Makefile (100%)
rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/clock.c (80%)
rename arch/arm/cpu/armv7/{s5pc2xx => exynos4}/soc.c (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/adc.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/clk.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/clock.h (99%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/cpu.h (64%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/gpio.h (83%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/mmc.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/pwm.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/sromc.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/sys_proto.h (100%)
rename arch/arm/include/asm/{arch-s5pc2xx => arch-exynos4}/uart.h (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 37bbb34..d493e4e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -691,12 +691,12 @@ Minkyu Kang
SMDKC100ARM ARMV7 (S5PC100 SoC)
s5p_goniARM ARMV7 (S5PC110 SoC)
- s5pc210_universal ARM ARMV7 (S5PC210 SoC)
+ s5pc210_universal ARM ARMV7 (EXYNOS4210 SoC)
Chander Kashyap
- origen ARM ARMV7 (S5PC210 SoC)
- SMDKV310ARM ARMV7 (S5PC210 SoC)
+ origen ARM ARMV7 (EXYNOS4210 SoC)
+ SMDKV310ARM ARMV7 (EXYNOS4210 SoC)
Torsten Koschorrek
scb9328 ARM920T (i.MXL)
diff --git a/Makefile b/Makefile
index fb658f4..646b105 100644
--- a/Makefile
+++ b/Makefile
@@ -296,7 +296,7 @@ endif
ifeq ($(SOC),s5pc1xx)
LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
endif
-ifeq ($(SOC),s5pc2xx)
+ifeq ($(SOC),exynos4)
LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
endif
diff --git a/arch/arm/cpu/armv7/s5pc2xx/Makefile
b/arch/arm/cpu/armv7/exynos4/Makefile
similarity index 100%
rename from arch/arm/cpu/armv7/s5pc2xx/Makefile
rename to arch/arm/cpu/armv7/exynos4/Makefile
diff --git a/arch/arm/cpu/armv7/s5pc2xx/clock.c
b/arch/arm/cpu/armv7/exynos4/clock.c
similarity index 80%
rename from arch/arm/cpu/armv7/s5pc2xx/clock.c
rename to arch/arm/cpu/armv7/exynos4/clock.c
index 5ecd475..668166a 100644
--- a/arch/arm/cpu/armv7/s5pc2xx/clock.c
+++ b/arch/arm/cpu/armv7/exynos4/clock.c
@@ -30,11 +30,11 @@
#define CONFIG_SYS_CLK_FREQ_C210 2400
#endif
-/* s5pc210: return pll clock frequency */
-static unsigned long s5pc210_get_pll_clk(int pllre
Re: [U-Boot] M5282EVB undefined reference to `environment'
Dear James Steward, In message <4eced2f2.8040...@inchipdesign.com.au> you wrote: > > I guess the variable environment is not defined, but where should it be > defined? There are a lot of hits when I search. When embedding the environment, you must set up a specific memory mep. This is done in the linker script, so this definition is usually found there. > After building a multitude of open source projects for x86 and cross > compiling for ARM, including cross compiling the Linux kernel and > writing some simple kernel drivers, and writing bare metal code for the > likes of the STM32 and including CanFestival, for example, U-boot has > been the most frustrating and difficult project for me to build and make > work of all. Is it because there are too many board ports contributed > but not maintained? Out-of-tree code is always a pain. But the real problem comes from the complexity of the hardware we have to deal with in the boot loader. After all, we have to do all the low-level initializations all higher software levels (including Linux) just take for granted. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de \|/ \|/ \|/ \|/ @~/ ,. \~@ @~/ ,. \~@ /_( \__/ )_\ /_( \__/ )_\ \__U_/ \__U_/ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
