Dear Stefano Babic, In message <1322149442-16555-1-git-send-email-sba...@denx.de> you wrote: > The TAM3517 is a SOM module that can be used on custom boards. > The patch add a common configuration file that is included > by the boards using this module. ... > diff --git a/include/configs/tam3517-common.h > b/include/configs/tam3517-common.h > new file mode 100644 > index 0000000..f972592 ... > + "hostname=" xstr(CONFIG_HOSTNAME) "\0" \ > + "bootfile=" xstr(CONFIG_HOSTNAME) "/uImage\0" \
Here you rely on xstr() being defined in some higher level header file. That's not a good idea. Please mode the definitions into this common header, and drop it in the other file(s). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Premature optimization is the root of all evil. -- D.E. Knuth _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
