On Mon, 4 Nov 2024 22:54:55 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature/extended-window >> - macOS: dynamically adapt toolbar style to headerbar height >> - fix header bar height flicker >> - NPE >> - fix peer access outside of synchronizer >> - improve title text documentation >> - macOS: hide window title >> - better documentation >> - set minHeight to native height of title bar >> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/WindowControlsOverlay.java > line 104: > >> 102: * </thead> >> 103: * <tbody><tr> >> 104: * >> <th>-fx-button-order</th><td><integer></td><td>0/1/2</td> > > what happens when CSS sets all buttons to the same value? > should this be something that user has control over vs. defined by the > platform? The buttons are sorted with `List.sort`, so that will dictate what happens in this scenario. Note that this class is not API, and neither users nor the platform will have any control over it. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828595321
