On Mon, 4 Nov 2024 20:55:41 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature/extended-window >> - macOS: dynamically adapt toolbar style to headerbar height >> - fix header bar height flicker >> - NPE >> - fix peer access outside of synchronizer >> - improve title text documentation >> - macOS: hide window title >> - better documentation >> - set minHeight to native height of title bar >> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/WindowControlsOverlay.java > line 78: > >> 76: * >> 77: * <table style="white-space: nowrap"> >> 78: * <caption>CSS properties of {@code >> window-button-container}</caption> > > The new CSS properties need to be included in `cssref.html`, along with the > description of platform availability. > > Should this be done as part of this PR? (that would be my preference) `WindowControlsOverlay` is not API, it's an implementation detail and as such must not be documented in `cssref.html`. This is by design: currently, this feature has a minimal API with just three new API elements: `StageStyle.EXTENDED`, `HeaderBar`, and `HeaderBarBase`. If we allowed app developers to customize window buttons, the API would explode in size and the specification burden would be immense. Let's not go there. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828591915
