On Mon, 4 Nov 2024 23:56:00 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature/extended-window >> - macOS: dynamically adapt toolbar style to headerbar height >> - fix header bar height flicker >> - NPE >> - fix peer access outside of synchronizer >> - improve title text documentation >> - macOS: hide window title >> - better documentation >> - set minHeight to native height of title bar >> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinWindow.java > line 390: > >> 388: * @param y the Y coordinate in physical pixels >> 389: */ >> 390: @SuppressWarnings("unused") > > tangentially related conversation starter: > > should we have a couple of annotations for code called from JNI/native and > reflection? That may be a good idea, see my other comment. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828604481
