On Tue, 5 Nov 2024 00:00:48 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature/extended-window >> - macOS: dynamically adapt toolbar style to headerbar height >> - fix header bar height flicker >> - NPE >> - fix peer access outside of synchronizer >> - improve title text documentation >> - macOS: hide window title >> - better documentation >> - set minHeight to native height of title bar >> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/ViewScene.java > line 206: > >> 204: @Override public String toString() { >> 205: View view = getPlatformView(); >> 206: return (" scene: " + hashCode() + " @ (" + view.getWidth() + >> "," + view.getHeight() + ")"); > > leading space in `toString()` might be a _bad idea_ > > suggestion (JSON-like): > > `return "ViewScene" + hashCode() + "{width=" + view.getWidth() + ", height=" > + view.getHeight() + "}";` Yep, but this is existing code. The GitHub diff viewer makes it seem like it was changed, but it isn't. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828762290
