On Mon, 4 Nov 2024 23:33:34 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature/extended-window >> - macOS: dynamically adapt toolbar style to headerbar height >> - fix header bar height flicker >> - NPE >> - fix peer access outside of synchronizer >> - improve title text documentation >> - macOS: hide window title >> - better documentation >> - set minHeight to native height of title bar >> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/WindowControlsOverlay.java > line 360: > >> 358: >> 359: private void onFocusedChanged(boolean focused) { >> 360: for (var node : new Node[] {minimizeButton, maximizeButton, >> closeButton}) { > > how is this better than > > minimizeButton.pseudoClassStateChanged(ACTIVE_PSEUDOCLASS, focused); > maximizeButton.pseudoClassStateChanged(ACTIVE_PSEUDOCLASS, focused); > closeButton.pseudoClassStateChanged(ACTIVE_PSEUDOCLASS, focused); > > ? I don't really care one way or the other, so I changed it to your suggestion. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828607779
