On Tue, 5 Nov 2024 16:09:24 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Yes, but if we do that, then we should do it everywhere it matters. The >> native toolkits are not multi-threaded, so all native upcalls happen on the >> JavaFX application thread. We should probably do this in another PR, and >> discuss how to do it uniformly (javadoc, annotation, etc). > > I think it would make sense to start doing this in the new code, as this > helps to show the connection. Only if as a courtesy to the developers who > have to read the code years later. Maybe so, but let's not discuss this in this PR. It's probably best to have a discussion on the mailing list first, and come up with a consistent way of documenting native upcalls. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1829649238
