On Mon, 4 Nov 2024 20:13:23 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> There is, however, one problem in RTL mode on Win11: something is wrong with
> the hover area of the native close ([x]) button. If I click on the center of
> the X, nothing happens, and it does not show the hover status. If I move the
> mouse pointer closer to the edge of the [x] button, the hover decoration
> comes on and the window can be closed.
>
> Can you check please?
Thanks for discovering this, there was a problem with mirrored coordinates in
RTL windows. Should be fixed now.
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Window.java line 170:
>
>> 168: * Indicates that the window is modal which affects whether the
>> window is minimizable.
>> 169: */
>> 170: @Native public static final int MODAL = 1 << 10;
>
> minor: would it be better to add EXTENDED after the MODAL to minimize the
> change? Do the actual values matter?
The values don't matter, as they are referred to with their constant name in
native code. We could minimize the diff here, but then the "visual kind" flags
wouldn't be grouped together...
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Window.java line 267:
>
>> 265: if ((styleMask & UNIFIED) != 0 && (styleMask & EXTENDED) != 0) {
>> 266: throw new RuntimeException("UNIFIED and EXTENDED cannot be
>> combined");
>> 267: }
>
> is it even possible to create a window with both `UNIFIED` and `EXTENDED` set?
No, this is just a sanity check.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2456006455
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828589537
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828589780
