On Tue, 5 Nov 2024 16:04:24 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> The purpose is to allow JavaFX developers (that is us, not users of JavaFX) >> to define the entire appearance of `WindowControlsOverlay` with a CSS file. >> This should make it easier to maintain it, since we won't have to keep >> looking in two places to change the appearance. > > I don't understand: why the orientation of EXTENDED window be different from > that of the platform (unless explicitly configured with > Scene.nodeOrientation)? When `-fx-allow-rtl` is set and the node orientation is RTL, the window buttons move to the other side of the window. This is a bit of a stylistic decision that may depend on OS and window manager. Maybe some window managers don't do that, and instead always keep the window buttons on the same side. This if kind of future-proofing the `WindowControlsOverlay` control. Let's say that in the future, a popular Linux window manager emerges that has a very distinct look and always keeps the window buttons on the same side. Then supporting this window manager will be as easy as providing an appropriate CSS file for its look-and-feel, all without changing the `WindowControlsOverlay` control. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1829634347
