On Tue, 5 Nov 2024 00:05:43 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature/extended-window >> - macOS: dynamically adapt toolbar style to headerbar height >> - fix header bar height flicker >> - NPE >> - fix peer access outside of synchronizer >> - improve title text documentation >> - macOS: hide window title >> - better documentation >> - set minHeight to native height of title bar >> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d > > modules/javafx.graphics/src/main/java/javafx/application/ConditionalFeature.java > line 156: > >> 154: * Indicates that a system supports {@link >> javafx.stage.StageStyle#EXTENDED}. >> 155: * <p> >> 156: * This feature is currently supported on Windows, Linux, and macOS. > > would it make sense to add more information similarly to UNIFIED_WINDOW on > L151? > maybe pointing to different levels of support? > > I don't know whether it makes sense to bring the whole table from the JEP > here, but maybe somewhere (HeaderBar)? It links directly to `StageStyle.EXTENDED`, which contains lots of information. I don't think we need it here. By the way, there are no support levels. The feature is supported in its entirety, as specified, on all desktop platforms. The table in the JEP is just informational to help OpenJFX developers understand what we're talking about. It's not a specification, and it can't be a specification because we either don't control things (for example, we have no influence on rounded corners, this could be changed with any future OS version) or because we'd be specifying us into a corner. There's no point prescribing every minute detail, and then being responsible to keep it working _exactly_ as described, even though the semantics are unchanged. The relevant parts are specified in `StageStyle.EXTENDED` and `HeaderBar`, and I wouldn't go further than this. We don't specify the details of `StageStyle.DECORATED` for each OS; why should we do it for `StageStyle.EXTENDED`? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1828772282
