wgzhao commented on PR #12355: URL: https://github.com/apache/seatunnel/pull/12355#issuecomment-5793734230
@SEZ9 - all five points from your review are addressed in `4f6663a9f` (the reply with the per-item breakdown is just above), so this is ready for another look whenever you have a moment: the `SET` / `ENUM` column length is now derived from the option list in `MySqlTypeUtils`, the two Javadocs are aligned, and the regression test pins the multi-character, embedded-comma, escaped-quote and `CHARACTER SET` shapes. Nothing else is pending on the code side - `DanielLeens` re-approved the new head, and the only red job on it is `unit-test (11, windows-latest)` (`PayPalClientTest` timing), which is unrelated. Once you are happy with the head, an approving review from a write-access account is the last thing this needs to move; I will keep the branch frozen until then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
