wgzhao commented on PR #12355: URL: https://github.com/apache/seatunnel/pull/12355#issuecomment-5846468753
@nzw921rx (cc @davidzollo) - would one of you be able to take this one over? It is code-complete and its `Build` is green on the current head `4f6663a9f`; every point raised in review has been addressed and answered in-thread (the SET/ENUM length derivation in `MySqlTypeUtils`, the `getColumnLength()` assertions, and the two Javadoc references), and @DanielLeens has approved it on this head. The only thing outstanding is an approving review from a write-access account - contributor approvals do not satisfy the `dev` ruleset - and since the author has no write access to the repository, a merge once you are satisfied. @SEZ9 started the review but has been away for a couple of days, so rather than keep waiting I wanted to ask directly. Context for the sequencing: #12373 is end-to-end coverage that is red on purpose until this fix lands, and #12333 / #10453 are code-complete behind it - all three have been reviewed and are waiting on the same gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
