wgzhao commented on PR #12355: URL: https://github.com/apache/seatunnel/pull/12355#issuecomment-5726183681
cc @davidzollo @nzw921rx - this one is code-complete and was approved by @DanielLeens on source review; it is now waiting only on the merge gates, so a committer look would unblock a chain of work. Where it stands: - Head is `adb4c2654` after syncing `dev`. The approval was recorded on the previous head and `dismiss_stale_reviews_on_push` cleared it, so it needs an approving review on the current commit - and, per the `dev` ruleset, one from someone with write access. - Nothing is outstanding in code: `CustomMySqlAntlrDdlParserTest` covers `ADD`, `MODIFY` and `CHANGE` parsing of the option list, and the reviewer's one follow-up item was end-to-end coverage, which is tracked in #12371 and drafted as #12373. - The red jobs on the latest `Build` are unrelated connectors (openGauss/Postgres CDC E2E timeouts, hudi/paimon, Windows timing), not `connector-cdc-mysql`. The sequencing matters here: #12373 drives the sink DDL end to end and is deliberately red until this fix lands - the reviewer asked for it to be merged first, then rebased and confirmed green. So merging this one also clears the way for #12333 and #10453, which are in the same area and likewise code-complete. If there is anything you would like changed before it goes in, or a reviewer you would rather have take it, say so and I will follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
