Re: [PR] [SPARK-50795][SQL] Store timestamp as `long` type in `describe` LinkedHashMap [spark]

2025-01-16 Thread via GitHub
MaxGekk commented on code in PR #49513: URL: https://github.com/apache/spark/pull/49513#discussion_r1918015476 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala: ## @@ -80,20 +82,18 @@ trait MetadataMapSupport { .mkString("[", ", "

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
wbo4958 commented on code in PR #49503: URL: https://github.com/apache/spark/pull/49503#discussion_r1918027559 ## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala: ## @@ -269,8 +293,9 @@ private[ml] object MLUtils { * @return * the ML ins

Re: [PR] [SPARK-50830] [SQL] Return single-pass result as the dual run analysis result [spark]

2025-01-16 Thread via GitHub
MaxGekk commented on code in PR #49509: URL: https://github.com/apache/spark/pull/49509#discussion_r1918032701 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -276,6 +276,17 @@ object SQLConf { .booleanConf .createWithDefault(false

[PR] [SPARK-50847] [SQL] Deny ApplyCharTypePadding from applying on specific In expressions [spark]

2025-01-16 Thread via GitHub
mihailoale-db opened a new pull request, #49526: URL: https://github.com/apache/spark/pull/49526 ### What changes were proposed in this pull request? `ApplyCharTypePadding` rule shouldn't be applied to `In` expressions where elements of the `In.list` are not `StringType`s and in this PR w

Re: [PR] [SPARK-50806][SQL] Support InputRDDCodegen interruption on task cancellation [spark]

2025-01-16 Thread via GitHub
Ngone51 commented on PR #49501: URL: https://github.com/apache/spark/pull/49501#issuecomment-2595245623 @cloud-fan is there a way to configure the parallelize for `Range`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer from `build_coverage.yml` to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
panbingkun commented on code in PR #49507: URL: https://github.com/apache/spark/pull/49507#discussion_r1917902450 ## .github/workflows/build_and_test.yml: ## @@ -623,7 +628,7 @@ jobs: if: fromJSON(inputs.envs).PYSPARK_CODECOV == 'true' uses: codecov/codecov-action@

Re: [PR] [SPARK-50825][ML][PYTHON][CONNECT] Support Tree Classifiers in ML Connect [spark]

2025-01-16 Thread via GitHub
zhengruifeng closed pull request #49525: [SPARK-50825][ML][PYTHON][CONNECT] Support Tree Classifiers in ML Connect URL: https://github.com/apache/spark/pull/49525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [SPARK-49907][ML][CONNECT][FOLLOW-UP] Move pyspark.ml.remote to pyspark.ml.connect [spark]

2025-01-16 Thread via GitHub
wbo4958 commented on PR #49524: URL: https://github.com/apache/spark/pull/49524#issuecomment-2595092951 brilliant solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [SPARK-50825][ML][PYTHON][CONNECT] Support Tree Classifiers in ML Connect [spark]

2025-01-16 Thread via GitHub
zhengruifeng commented on PR #49525: URL: https://github.com/apache/spark/pull/49525#issuecomment-2595059891 thanks, merged to master/4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [SPARK-50831][SQL] Enable trimming collation by default [spark]

2025-01-16 Thread via GitHub
stevomitric commented on code in PR #49510: URL: https://github.com/apache/spark/pull/49510#discussion_r1918164942 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -880,7 +880,7 @@ object SQLConf { ) .version("4.0.0") .boolea

Re: [PR] [SPARK-49907][ML][CONNECT][FOLLOW-UP] Move pyspark.ml.remote to pyspark.ml.connect [spark]

2025-01-16 Thread via GitHub
zhengruifeng commented on PR #49524: URL: https://github.com/apache/spark/pull/49524#issuecomment-2595076654 nice refactor, btw, is it also merged in 4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [SPARK-49872][HISTORYSERVER] allow unlimited json size again [spark]

2025-01-16 Thread via GitHub
steven-aerts commented on code in PR #49163: URL: https://github.com/apache/spark/pull/49163#discussion_r1918197712 ## core/src/main/scala/org/apache/spark/util/JsonProtocol.scala: ## @@ -69,6 +69,11 @@ private[spark] object JsonProtocol extends JsonUtils { private[util] v

Re: [PR] [SPARK-50830] [SQL] Return single-pass result as the dual run analysis result [spark]

2025-01-16 Thread via GitHub
vladimirg-db commented on PR #49509: URL: https://github.com/apache/spark/pull/49509#issuecomment-2595125771 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [SPARK-50793][SQL] Fix MySQL cast function for DOUBLE, LONGTEXT, BIGINT and BLOB types [spark]

2025-01-16 Thread via GitHub
sunxiaoguang commented on code in PR #49453: URL: https://github.com/apache/spark/pull/49453#discussion_r1918230743 ## connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala: ## @@ -241,6 +241,56 @@ class MySQLIntegrationSuite

Re: [PR] [SPARK-50793][SQL] Fix MySQL cast function for DOUBLE, LONGTEXT, BIGINT and BLOB types [spark]

2025-01-16 Thread via GitHub
sunxiaoguang commented on code in PR #49453: URL: https://github.com/apache/spark/pull/49453#discussion_r1918230743 ## connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala: ## @@ -241,6 +241,56 @@ class MySQLIntegrationSuite

Re: [PR] [SPARK-50793][SQL] Fix MySQL cast function for DOUBLE, LONGTEXT, BIGINT and BLOB types [spark]

2025-01-16 Thread via GitHub
sunxiaoguang commented on code in PR #49453: URL: https://github.com/apache/spark/pull/49453#discussion_r1918230743 ## connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala: ## @@ -241,6 +241,56 @@ class MySQLIntegrationSuite

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
ericm-db commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1918068390 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ## @@ -496,6 +498,486 @@ class RocksDBStateStoreSuite extends

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
ericm-db commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1918067901 ## sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithListStateSuite.scala: ## @@ -328,4 +390,44 @@ class TransformWithListStateSuite extends StreamTe

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
ericm-db commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1918069251 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ## @@ -496,6 +498,486 @@ class RocksDBStateStoreSuite extends

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
grundprinzip commented on code in PR #49503: URL: https://github.com/apache/spark/pull/49503#discussion_r1918066708 ## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala: ## @@ -269,8 +293,9 @@ private[ml] object MLUtils { * @return * the M

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
ericm-db commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1918069934 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ## @@ -496,6 +498,486 @@ class RocksDBStateStoreSuite extends

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
ericm-db commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1918070616 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ## @@ -496,6 +498,486 @@ class RocksDBStateStoreSuite extends

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
panbingkun commented on PR #49507: URL: https://github.com/apache/spark/pull/49507#issuecomment-2594938301 - I have verified it in my own mock repo: https://github.com/user-attachments/assets/00cc0006-ee1a-4713-8dfd-229b8b0270b8"; /> https://github.com/panbingkun/github-actions/action

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
wbo4958 commented on code in PR #49503: URL: https://github.com/apache/spark/pull/49503#discussion_r1918051959 ## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala: ## @@ -228,39 +225,66 @@ private[ml] object MLUtils { instance } + /** +

Re: [PR] [SPARK-50830] [SQL] Return single-pass result as the dual run analysis result [spark]

2025-01-16 Thread via GitHub
mihailoale-db commented on code in PR #49509: URL: https://github.com/apache/spark/pull/49509#discussion_r1918084982 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -276,6 +276,17 @@ object SQLConf { .booleanConf .createWithDefault

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
LuciferYang commented on PR #49507: URL: https://github.com/apache/spark/pull/49507#issuecomment-2595303768 hmm... can we make a clean one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
LuciferYang commented on code in PR #49507: URL: https://github.com/apache/spark/pull/49507#discussion_r1918308726 ## .github/workflows/build_and_test.yml: ## @@ -49,6 +49,10 @@ on: required: false type: string default: '' +secrets: + codecov_

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
panbingkun commented on PR #49507: URL: https://github.com/apache/spark/pull/49507#issuecomment-2595310528 > hmm... can we make a clean one? Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
panbingkun commented on code in PR #49507: URL: https://github.com/apache/spark/pull/49507#discussion_r1918313556 ## .github/workflows/build_and_test.yml: ## @@ -49,6 +49,10 @@ on: required: false type: string default: '' +secrets: + codecov_t

Re: [PR] [SPARK-50633][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml [spark]

2025-01-16 Thread via GitHub
panbingkun commented on PR #49527: URL: https://github.com/apache/spark/pull/49527#issuecomment-2595322812 Contrast to https://github.com/apache/spark/pull/49507, it is a relatively clean PR. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
panbingkun commented on PR #49507: URL: https://github.com/apache/spark/pull/49507#issuecomment-2595326152 closing in favor of https://github.com/apache/spark/pull/49527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` [spark]

2025-01-16 Thread via GitHub
panbingkun closed pull request #49507: [SPARK-50633][FOLLOWUP] Let `CODECOV_TOKEN` transfer to `build_and_test.yml` URL: https://github.com/apache/spark/pull/49507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [SPARK-50633][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml [spark]

2025-01-16 Thread via GitHub
panbingkun commented on PR #49527: URL: https://github.com/apache/spark/pull/49527#issuecomment-2595327316 cc @dongjoon-hyun @HyukjinKwon @zhengruifeng @LuciferYang Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] [SPARK-50633][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml [spark]

2025-01-16 Thread via GitHub
panbingkun opened a new pull request, #49527: URL: https://github.com/apache/spark/pull/49527 ### What changes were proposed in this pull request? The pr aims to let `CODECOV_TOKEN` transfer from `build_coverage.yml`/`build_main.yml` to `build_and_test.yml`. ### Why are the cha

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
miland-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918488658 ## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala: ## @@ -63,6 +67,81 @@ case class SqlScriptingInterpreter(session: SparkSessio

Re: [PR] [SPARK-50720][CORE] Support external shuffle service enablement in local-cluster mode [spark]

2025-01-16 Thread via GitHub
LuciferYang commented on code in PR #49350: URL: https://github.com/apache/spark/pull/49350#discussion_r1918489929 ## core/src/test/scala/org/apache/spark/deploy/ExternalShuffleServiceSuite.scala: ## @@ -102,14 +77,18 @@ class ExternalShuffleServiceSuite extends ShuffleSuite wi

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
miland-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918494303 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -79,6 +81,29 @@ setStatementWithOptionalVarKeyword LEFT_PAREN query R

Re: [PR] [SPARK-50830] [SQL] Return single-pass result as the dual run analysis result [spark]

2025-01-16 Thread via GitHub
cloud-fan commented on PR #49509: URL: https://github.com/apache/spark/pull/49509#issuecomment-2595411566 The Spark Connect failure is unrelated, thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [SPARK-50795][SQL] Store timestamp as `long` type in `describe` LinkedHashMap [spark]

2025-01-16 Thread via GitHub
cloud-fan closed pull request #49513: [SPARK-50795][SQL] Store timestamp as `long` type in `describe` LinkedHashMap URL: https://github.com/apache/spark/pull/49513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [SPARK-50795][SQL] Store timestamp as `long` type in `describe` LinkedHashMap [spark]

2025-01-16 Thread via GitHub
cloud-fan commented on code in PR #49513: URL: https://github.com/apache/spark/pull/49513#discussion_r1918369632 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala: ## @@ -80,20 +82,18 @@ trait MetadataMapSupport { .mkString("[", ",

Re: [PR] [SPARK-50830] [SQL] Return single-pass result as the dual run analysis result [spark]

2025-01-16 Thread via GitHub
cloud-fan closed pull request #49509: [SPARK-50830] [SQL] Return single-pass result as the dual run analysis result URL: https://github.com/apache/spark/pull/49509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
miland-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918490407 ## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecution.scala: ## @@ -97,18 +101,52 @@ class SqlScriptingExecution( None } - privat

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
grundprinzip commented on code in PR #49503: URL: https://github.com/apache/spark/pull/49503#discussion_r1918501882 ## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala: ## @@ -269,8 +293,9 @@ private[ml] object MLUtils { * @return * the M

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
miland-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918506979 ## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecution.scala: ## @@ -97,18 +101,52 @@ class SqlScriptingExecution( None } - privat

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
grundprinzip commented on PR #49503: URL: https://github.com/apache/spark/pull/49503#issuecomment-2595600266 Will merge as soon as the CI passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
wbo4958 commented on code in PR #49503: URL: https://github.com/apache/spark/pull/49503#discussion_r1918538691 ## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala: ## @@ -214,6 +214,18 @@ object Connect { .toSequence .createWithDe

Re: [PR] [SPARK-50847] [SQL] Deny ApplyCharTypePadding from applying on specific In expressions [spark]

2025-01-16 Thread via GitHub
mihailoale-db commented on code in PR #49526: URL: https://github.com/apache/spark/pull/49526#discussion_r1918541776 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyCharTypePaddingHelper.scala: ## @@ -99,7 +99,9 @@ object ApplyCharTypePaddingHelper {

Re: [PR] [SPARK-50847] [SQL] Deny ApplyCharTypePadding from applying on specific In expressions [spark]

2025-01-16 Thread via GitHub
cloud-fan commented on code in PR #49526: URL: https://github.com/apache/spark/pull/49526#discussion_r1918566329 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyCharTypePaddingHelper.scala: ## @@ -99,7 +99,9 @@ object ApplyCharTypePaddingHelper {

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
HeartSaVioR commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1918562610 ## python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py: ## @@ -1698,6 +1876,173 @@ def init(self, handle: StatefulProcessorHandle) -> None:

Re: [PR] [SPARK-50847] [SQL] Deny ApplyCharTypePadding from applying on specific In expressions [spark]

2025-01-16 Thread via GitHub
mihailoale-db commented on code in PR #49526: URL: https://github.com/apache/spark/pull/49526#discussion_r1918580476 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyCharTypePaddingHelper.scala: ## @@ -99,7 +99,9 @@ object ApplyCharTypePaddingHelper {

Re: [PR] [SPARK-50720][CORE] Support external shuffle service enablement in local-cluster mode [spark]

2025-01-16 Thread via GitHub
Ngone51 commented on code in PR #49350: URL: https://github.com/apache/spark/pull/49350#discussion_r1918615702 ## core/src/test/scala/org/apache/spark/deploy/ExternalShuffleServiceSuite.scala: ## @@ -102,14 +77,18 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with B

Re: [PR] [SPARK-50720][CORE] Support external shuffle service enablement in local-cluster mode [spark]

2025-01-16 Thread via GitHub
Ngone51 commented on code in PR #49350: URL: https://github.com/apache/spark/pull/49350#discussion_r1918616616 ## core/src/test/scala/org/apache/spark/deploy/ExternalShuffleServiceSuite.scala: ## @@ -102,14 +77,18 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with B

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
grundprinzip commented on code in PR #49503: URL: https://github.com/apache/spark/pull/49503#discussion_r1918626378 ## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala: ## @@ -214,6 +214,18 @@ object Connect { .toSequence .createW

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
grundprinzip closed pull request #49503: [SPARK-50827][ML][CONNECT] Support plugin URL: https://github.com/apache/spark/pull/49503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
grundprinzip commented on PR #49503: URL: https://github.com/apache/spark/pull/49503#issuecomment-2595843175 Merging to master and branch-4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [WIP][SPARK-50838][SQL]Add checkRecursion to check if all the rules about recursive queries are fulfilled. Adjust optimizer with UnionLoop cases. [spark]

2025-01-16 Thread via GitHub
milanisvet commented on code in PR #49518: URL: https://github.com/apache/spark/pull/49518#discussion_r1917917583 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -1042,6 +1043,75 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-49907][ML][CONNECT][FOLLOW-UP] Move pyspark.ml.remote to pyspark.ml.connect [spark]

2025-01-16 Thread via GitHub
HyukjinKwon closed pull request #49524: [SPARK-49907][ML][CONNECT][FOLLOW-UP] Move pyspark.ml.remote to pyspark.ml.connect URL: https://github.com/apache/spark/pull/49524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [SPARK-49907][ML][CONNECT][FOLLOW-UP] Move pyspark.ml.remote to pyspark.ml.connect [spark]

2025-01-16 Thread via GitHub
HyukjinKwon commented on PR #49524: URL: https://github.com/apache/spark/pull/49524#issuecomment-2594789222 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [WIP][SPARK-50838][SQL]Add checkRecursion to check if all the rules about recursive queries are fulfilled. Adjust optimizer with UnionLoop cases. [spark]

2025-01-16 Thread via GitHub
milanisvet commented on code in PR #49518: URL: https://github.com/apache/spark/pull/49518#discussion_r1917935888 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -1042,6 +1043,75 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [WIP][SPARK-50838][SQL]Add checkRecursion to check if all the rules about recursive queries are fulfilled. Adjust optimizer with UnionLoop cases. [spark]

2025-01-16 Thread via GitHub
milanisvet commented on code in PR #49518: URL: https://github.com/apache/spark/pull/49518#discussion_r1917935888 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -1042,6 +1043,75 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
HeartSaVioR commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1917940301 ## python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py: ## @@ -1294,6 +1307,208 @@ def test_transform_with_state_with_timers_single_partition(self)

Re: [PR] [SPARK-50825][ML][PYTHON][CONNECT] Support Tree Classifiers in ML Connect [spark]

2025-01-16 Thread via GitHub
wbo4958 commented on PR #49525: URL: https://github.com/apache/spark/pull/49525#issuecomment-2594812892 LGTM. Thx @zhengruifeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
HeartSaVioR commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1917947186 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala: ## @@ -496,6 +498,486 @@ class RocksDBStateStoreSuite extend

Re: [PR] [SPARK-50827][ML][CONNECT] Support plugin [spark]

2025-01-16 Thread via GitHub
wbo4958 commented on code in PR #49503: URL: https://github.com/apache/spark/pull/49503#discussion_r1917988503 ## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala: ## @@ -269,8 +293,9 @@ private[ml] object MLUtils { * @return * the ML ins

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
davidm-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918149708 ## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala: ## @@ -63,6 +67,81 @@ case class SqlScriptingInterpreter(session: SparkSessio

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
davidm-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918154394 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -159,15 +159,99 @@ class AstBuilder extends DataTypeAstBuilder script

Re: [PR] [SPARK-50806][SQL] Support InputRDDCodegen interruption on task cancellation [spark]

2025-01-16 Thread via GitHub
dongjoon-hyun commented on PR #49501: URL: https://github.com/apache/spark/pull/49501#issuecomment-2596065184 Do you mean `spark.range(..)` in your test case? Then, `numPartitions` of `spark.range(start: Long, end: Long, step: Long, numPartitions: Int)` wasn't enough? > is there a way to

Re: [PR] [SPARK-48530][SQL] Support for local variables in SQL Scripting [spark]

2025-01-16 Thread via GitHub
miland-db commented on code in PR #49445: URL: https://github.com/apache/spark/pull/49445#discussion_r1918841157 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -251,9 +251,19 @@ trait ColumnResolutionHelper extends Loggi

Re: [PR] [SPARK-48530][SQL] Support for local variables in SQL Scripting [spark]

2025-01-16 Thread via GitHub
davidm-db commented on code in PR #49445: URL: https://github.com/apache/spark/pull/49445#discussion_r1918845297 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -251,9 +251,19 @@ trait ColumnResolutionHelper extends Loggi

[PR] [SPARK-50852][INFRA] Add Java 21 Maven Daily GitHub Action job for `branch-4.0` [spark]

2025-01-16 Thread via GitHub
dongjoon-hyun opened a new pull request, #49530: URL: https://github.com/apache/spark/pull/49530 … ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

Re: [PR] [SPARK-48530][SQL] Support for local variables in SQL Scripting [spark]

2025-01-16 Thread via GitHub
davidm-db commented on code in PR #49445: URL: https://github.com/apache/spark/pull/49445#discussion_r1918853693 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ## @@ -1613,7 +1616,12 @@ case class DropVariable( */ case class SetVa

Re: [PR] [SPARK-48530][SQL] Support for local variables in SQL Scripting [spark]

2025-01-16 Thread via GitHub
davidm-db commented on code in PR #49445: URL: https://github.com/apache/spark/pull/49445#discussion_r1918845297 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -251,9 +251,19 @@ trait ColumnResolutionHelper extends Loggi

Re: [PR] [SPARK-50829][SQL] Add flag to disable session collation by default [spark]

2025-01-16 Thread via GitHub
MaxGekk commented on PR #49505: URL: https://github.com/apache/spark/pull/49505#issuecomment-2596289832 +1, LGTM. Merging to master/4.x. Thank you, @stefankandic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-50829][SQL] Add flag to disable session collation by default [spark]

2025-01-16 Thread via GitHub
MaxGekk closed pull request #49505: [SPARK-50829][SQL] Add flag to disable session collation by default URL: https://github.com/apache/spark/pull/49505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [SPARK-50852][INFRA] Add Java 21 Daily GitHub Action job for `branch-4.0` [spark]

2025-01-16 Thread via GitHub
dongjoon-hyun commented on PR #49530: URL: https://github.com/apache/spark/pull/49530#issuecomment-2596376332 Could you review this PR to help Apache Spark 4.0 Java 21 test coverage, @huaxingao ? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [SPARK-50639][SQL] Improve warning logging in CacheManager [spark]

2025-01-16 Thread via GitHub
vrozov commented on PR #49276: URL: https://github.com/apache/spark/pull/49276#issuecomment-2596383483 @gengliangwang Please check my reply. To clarify why I think #45990 and #49276 are related but do not overlap: changes in #45990 log (trace by default) messages when the cache is mod

Re: [PR] [SPARK-50633][INFRA][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml [spark]

2025-01-16 Thread via GitHub
dongjoon-hyun commented on PR #49527: URL: https://github.com/apache/spark/pull/49527#issuecomment-2596208403 Thank you for keeping tracking this. I hope this could help the situation become better. Thank you, @panbingkun and @LuciferYang . Merged to master. -- This is an au

Re: [PR] [SPARK-50633][INFRA][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml [spark]

2025-01-16 Thread via GitHub
dongjoon-hyun commented on PR #49527: URL: https://github.com/apache/spark/pull/49527#issuecomment-2596210342 When we are sure that everything is clean, you can do backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
dusantism-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918904043 ## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecution.scala: ## @@ -97,18 +101,52 @@ class SqlScriptingExecution( None } - pri

[PR] [SPARK-50853][CORE] - Close temp shuffle file writable channel [spark]

2025-01-16 Thread via GitHub
ChenMichael opened a new pull request, #49531: URL: https://github.com/apache/spark/pull/49531 ### What changes were proposed in this pull request? Currently, there are two implementations of DownloadFileWritableChannel (which is used for writing data fetched to disk), SimpleD

Re: [PR] [SPARK-50633][INFRA][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml [spark]

2025-01-16 Thread via GitHub
dongjoon-hyun closed pull request #49527: [SPARK-50633][INFRA][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml URL: https://github.com/apache/spark/pull/49527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-48530][SQL] Support for local variables in SQL Scripting [spark]

2025-01-16 Thread via GitHub
dusantism-db commented on code in PR #49445: URL: https://github.com/apache/spark/pull/49445#discussion_r1918889021 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -251,9 +251,19 @@ trait ColumnResolutionHelper extends Lo

Re: [PR] [SPARK-50714][SQL][SS] Enable schema evolution for TransformWithState when Avro encoding is used [spark]

2025-01-16 Thread via GitHub
bogao007 commented on code in PR #49277: URL: https://github.com/apache/spark/pull/49277#discussion_r1918936950 ## python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py: ## @@ -1698,6 +1876,173 @@ def init(self, handle: StatefulProcessorHandle) -> None: se

[PR] [SPARK-50511][PYTHON][FOLLOWUP] Avoid wrapping streaming Python data source error messages [spark]

2025-01-16 Thread via GitHub
allisonwang-db opened a new pull request, #49532: URL: https://github.com/apache/spark/pull/49532 ### What changes were proposed in this pull request? This PR is a follow up for https://github.com/apache/spark/pull/49092. It removes the extra try catch during streaming Python

Re: [PR] [SPARK-50511][PYTHON][FOLLOWUP] Avoid wrapping streaming Python data source error messages [spark]

2025-01-16 Thread via GitHub
allisonwang-db commented on PR #49532: URL: https://github.com/apache/spark/pull/49532#issuecomment-2596442752 cc @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SPARK-43415][CONNECT][SQL] Implement `KVGDS.agg` with custom `mapValues` function [spark]

2025-01-16 Thread via GitHub
xupefei commented on code in PR #49111: URL: https://github.com/apache/spark/pull/49111#discussion_r1918667270 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/KeyValueGroupedDatasetE2ETestSuite.scala: ## @@ -454,12 +455,43 @@ class KeyValueGroupedDatasetE2ETe

Re: [PR] [SPARK-19335][SPARK-38200][SQL] Add upserts for writing to JDBC [spark]

2025-01-16 Thread via GitHub
EnricoMi commented on PR #41518: URL: https://github.com/apache/spark/pull/41518#issuecomment-2595900079 Reopened as #49528. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [MINOR][INFRA] Do not upload docker build record [spark]

2025-01-16 Thread via GitHub
EnricoMi commented on PR #48012: URL: https://github.com/apache/spark/pull/48012#issuecomment-2595921627 @Yikun moved the env from step to workflow level so it applies to all steps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] [SPARK-50851][ML][CONNECT][PYTHON] Express ML params with `proto.Expression` [spark]

2025-01-16 Thread via GitHub
zhengruifeng opened a new pull request, #49529: URL: https://github.com/apache/spark/pull/49529 ### What changes were proposed in this pull request? Express ML params with `proto.Expression`: 1, introduce `Literal.SpecializedArray` for large primitive literal arrays ``` messag

Re: [PR] [SPARK-50831][SQL] Enable trimming collation by default [spark]

2025-01-16 Thread via GitHub
MaxGekk commented on PR #49510: URL: https://github.com/apache/spark/pull/49510#issuecomment-2595942627 +1, LGTM. Merging to master. Thank you, @stevomitric and @dongjoon-hyun @jovanpavl-db @stefankandic for review. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [SPARK-50831][SQL] Enable trimming collation by default [spark]

2025-01-16 Thread via GitHub
MaxGekk closed pull request #49510: [SPARK-50831][SQL] Enable trimming collation by default URL: https://github.com/apache/spark/pull/49510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [SPARK-43415][CONNECT][SQL] Implement `KVGDS.agg` with custom `mapValues` function [spark]

2025-01-16 Thread via GitHub
xupefei commented on code in PR #49111: URL: https://github.com/apache/spark/pull/49111#discussion_r1918712274 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/KeyValueGroupedDatasetE2ETestSuite.scala: ## @@ -454,12 +455,43 @@ class KeyValueGroupedDatasetE2ETe

Re: [PR] [SPARK-50851][ML][CONNECT][PYTHON] Express ML params with `proto.Expression` [spark]

2025-01-16 Thread via GitHub
zhengruifeng commented on PR #49529: URL: https://github.com/apache/spark/pull/49529#issuecomment-2595955106 cc @wbo4958 @HyukjinKwon @WeichenXu123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [SPARK-50847] [SQL] Deny ApplyCharTypePadding from applying on specific In expressions [spark]

2025-01-16 Thread via GitHub
mihailoale-db commented on code in PR #49526: URL: https://github.com/apache/spark/pull/49526#discussion_r1918726779 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyCharTypePaddingHelper.scala: ## @@ -99,7 +99,9 @@ object ApplyCharTypePaddingHelper {

Re: [PR] [SPARK-50795][SQL] Store timestamp as `long` type in `describe` LinkedHashMap [spark]

2025-01-16 Thread via GitHub
cloud-fan commented on PR #49513: URL: https://github.com/apache/spark/pull/49513#issuecomment-2595425751 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
miland-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918490407 ## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecution.scala: ## @@ -97,18 +101,52 @@ class SqlScriptingExecution( None } - privat

Re: [PR] [SPARK-50847] [SQL] Deny ApplyCharTypePadding from applying on specific In expressions [spark]

2025-01-16 Thread via GitHub
mihailom-db commented on code in PR #49526: URL: https://github.com/apache/spark/pull/49526#discussion_r1918519419 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyCharTypePaddingHelper.scala: ## @@ -99,7 +99,9 @@ object ApplyCharTypePaddingHelper {

Re: [PR] [SPARK-48353][SQL] Introduction of Error Handling mechanism in SQL Scripting [spark]

2025-01-16 Thread via GitHub
miland-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918494303 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -79,6 +81,29 @@ setStatementWithOptionalVarKeyword LEFT_PAREN query R

Re: [PR] [SPARK-50793][SQL] Fix MySQL cast function for DOUBLE, LONGTEXT, BIGINT and BLOB types [spark]

2025-01-16 Thread via GitHub
beliefer commented on code in PR #49453: URL: https://github.com/apache/spark/pull/49453#discussion_r1918583878 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala: ## @@ -112,6 +112,21 @@ private case class MySQLDialect() extends JdbcDialect with SQLConfHel

Re: [PR] [SPARK-50793][SQL] Fix MySQL cast function for DOUBLE, LONGTEXT, BIGINT and BLOB types [spark]

2025-01-16 Thread via GitHub
beliefer commented on code in PR #49453: URL: https://github.com/apache/spark/pull/49453#discussion_r1918583878 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala: ## @@ -112,6 +112,21 @@ private case class MySQLDialect() extends JdbcDialect with SQLConfHel

  1   2   3   >