steven-aerts commented on code in PR #49163:
URL: https://github.com/apache/spark/pull/49163#discussion_r1918197712
##########
core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:
##########
@@ -69,6 +69,11 @@ private[spark] object JsonProtocol extends JsonUtils {
private[util]
val defaultOptions: JsonProtocolOptions = new JsonProtocolOptions(new
SparkConf(false))
+ // SPARK-49872 remove limit on string lengths
+ mapper.getFactory.setStreamReadConstraints(
+ StreamReadConstraints.builder().maxStringLength(Int.MaxValue).build()
Review Comment:
@LuciferYang
I think I see a way to make a test case for it.
About making it configurable, do you have a suggestion for a default value
you feel comfortable with?
We abandoned roczei/spark#7 configurable approach for explicit disabling of
this check and go back to the behavior before jackason 2.15, which is what I
am doing here now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
