zhengruifeng opened a new pull request, #49529:
URL: https://github.com/apache/spark/pull/49529

   ### What changes were proposed in this pull request?
   Express ML params with `proto.Expression`:
   1, introduce `Literal.SpecializedArray` for large primitive literal arrays
   ```
       message SpecializedArray {
         DataType element_type = 1;
         repeated bool booleans = 2;
         repeated int32 integers = 3;
         repeated int64 longs = 4;
         repeated float floats = 5;
         repeated double doubles = 6;
         repeated string strings = 7;
       }
   ```
   2, Replace `proto.Param ` with `proto.Expression` to be consistent with SQL 
side
   For `Param[Vector]` and `Param[Matrix]`, apply 
`proto.Expression.Literal.Struct` with the underly schema of `VectorUDT` and 
`MatrixUDT`
   
   
   ### Why are the changes needed?
   1, to optimize large literal arrays, for both ML and SQL
   2, be consistent with SQL side, e.g. the parameterized SQL
   3, to minimize the protobuf change
   
   
   ### Does this PR introduce _any_ user-facing change?
   no, refactoring
   
   
   ### How was this patch tested?
   existing tests
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to