davidm-db commented on code in PR #49445: URL: https://github.com/apache/spark/pull/49445#discussion_r1918853693
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ########## @@ -1613,7 +1616,12 @@ case class DropVariable( */ case class SetVariable( targetVariables: Seq[Expression], - sourceQuery: LogicalPlan) + sourceQuery: LogicalPlan, + // When false, this node can set local variables from SQL scripting. + // When true, it can only set session variables. + sessionVariablesOnly: Boolean = false, + // Whether this node was created by EXECUTE IMMEDIATE for the INTO clause. + executeImmediateIntoClause: Boolean = false) Review Comment: `isExecuteImmediateIntoClause` maybe? ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ########## @@ -1613,7 +1616,12 @@ case class DropVariable( */ case class SetVariable( targetVariables: Seq[Expression], - sourceQuery: LogicalPlan) + sourceQuery: LogicalPlan, + // When false, this node can set local variables from SQL scripting. + // When true, it can only set session variables. + sessionVariablesOnly: Boolean = false, + // Whether this node was created by EXECUTE IMMEDIATE for the INTO clause. + executeImmediateIntoClause: Boolean = false) Review Comment: nit: `isExecuteImmediateIntoClause` maybe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org