davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1918149708
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -63,6 +67,81 @@ case class SqlScriptingInterpreter(session: SparkSession) {
case _ => None
}
+ /**
+ * Transform [[CompoundBody]] into [[CompoundBodyExec]].
+ *
+ * @param compoundBody
+ * CompoundBody to be transformed into CompoundBodyExec.
+ * @param args
+ * A map of parameter names to SQL literal expressions.
+ * @param isHandler
+ * Indicates if the body is a handler body to do additional processing
during transforming.
+ * @return
+ * Executable version of the CompoundBody .
+ */
+ private def transformBodyIntoExec(
+ compoundBody: CompoundBody,
+ args: Map[String, Expression],
+ context: SqlScriptingExecutionContext,
+ isHandler: Boolean = false): CompoundBodyExec = {
Review Comment:
Yup, good point. I made a comment earlier to change the parameter
names/types, but didn't notice that it's not used at all... Seems like we get
everything that's needed from the handler's logical plan and this param can be
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
