wbo4958 commented on code in PR #49503:
URL: https://github.com/apache/spark/pull/49503#discussion_r1917988503
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala:
##########
@@ -269,8 +293,9 @@ private[ml] object MLUtils {
* @return
* the ML instance
*/
- def load(className: String, path: String): Object = {
- val loadedMethod =
SparkClassUtils.classForName(className).getMethod("load", classOf[String])
+ def load(sessionHolder: SessionHolder, className: String, path: String):
Object = {
+ val name = replaceOperator(sessionHolder, className)
+ val loadedMethod = SparkClassUtils.classForName(name).getMethod("load",
classOf[String])
Review Comment:
Hi @grundprinzip, Let's take LogisticRegressionModel as an example, you can
see from
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala#L1062,
If we would like to add a public no-arg constructor, then we need to set the
default other parameters. but the question is what values of the parameters are
ok?
Let me file an issue to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
