miland-db commented on code in PR #49427: URL: https://github.com/apache/spark/pull/49427#discussion_r1918494303
########## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ########## @@ -79,6 +81,29 @@ setStatementWithOptionalVarKeyword LEFT_PAREN query RIGHT_PAREN #setVariableWithOptionalKeyword ; +sqlStateValue + : stringLit + ; + +declareConditionStatement + : DECLARE multipartIdentifier CONDITION (FOR SQLSTATE VALUE? sqlStateValue)? + ; + +conditionValue + : sqlStateValue + | multipartIdentifier + | SQLEXCEPTION + | NOT FOUND + ; + +conditionValues + : cvList+=conditionValue (COMMA cvList+=conditionValue)* + ; + +declareHandlerStatement + : DECLARE (CONTINUE | EXIT) HANDLER FOR conditionValues (BEGIN compoundBody END | statement | setStatementWithOptionalVarKeyword) Review Comment: I think labels should not be available here, but we maybe @srielau can confirm. Is it possible to do something like this: ``` DECLARE EXIT HANDLER FOR DIVISION_BY_ZERO lbl: BEGIN ... END; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org