[Qemu-devel] [Patch] fix /proc/self/maps output

2013-02-19 Thread Christophe Lyon
Hi, Here is a small patch for the /proc/self/maps output (Linux user mode), which adds a space after the last number in the case where there is no filename to print. This matches what the kernel does, and is expected by libsanitizer. Christophe. qemu-maps.patch Description: Binary data

Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output

2013-05-05 Thread Christophe Lyon
Ping? On 2 April 2013 14:03, Christophe Lyon wrote: > Add a space at end of line when there is no filename to print, to > conform to linux kernel format (see show_map_vma() in > fs/proc/task_mmu.c). > > Signed-off-by: Christophe Lyon > --- > > Changes v1-v2: > Addi

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-06 Thread Christophe Lyon
the license change and a global modification of the comment structure. This patch rebases our softfloat code to SoftFloat-2a in order to have a GPLv2 compatible license. Acked-by: Christophe Lyon

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc1 is now available

2013-05-10 Thread Christophe Lyon
Hi, Would it be possible to include the small patch at: https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg00530.html Thanks Christophe. On 09.05.2013 00:29, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for

[Qemu-devel] [PATCH] Add support for MAP_NORESERVE mmap flag.

2014-02-03 Thread Christophe Lyon
From: Christophe Lyon mmap_flags_tbl contains a list of mmap flags, and how to map them to the target. This patch adds MAP_NORESERVE, which was missing to the list. Signed-off-by: Christophe Lyon --- linux-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user

Re: [Qemu-devel] [PATCH] Add support for MAP_NORESERVE mmap flag.

2014-06-05 Thread Christophe Lyon
On 02/03/14 18:46, Peter Maydell wrote: On 3 February 2014 16:04, Christophe Lyon wrote: From: Christophe Lyon mmap_flags_tbl contains a list of mmap flags, and how to map them to the target. This patch adds MAP_NORESERVE, which was missing to the list. Signed-off-by: Christophe Lyon

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

2013-03-29 Thread Christophe Lyon
Hi, May I ping for this small patch? Thanks, Christophe On 19 February 2013 17:28, Christophe Lyon wrote: > Hi, > Here is a small patch for the /proc/self/maps output (Linux user > mode), which adds a space after the last number in the case where > there is no filename to print.

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

2013-03-29 Thread Christophe Lyon
here is no filename to print, to conform to linux kernel format. Signed-off-by: Christophe Lyon diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a148d9f..3b0ca86 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_e

Re: [Qemu-devel] [Patch] fix /proc/self/maps output

2013-03-29 Thread Christophe Lyon
Add a space at end of line when there is no filename to print, to conform to linux kernel format. Signed-off-by: Christophe Lyon --- linux-user/syscall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a148d9f..3b0ca86

[Qemu-devel] [Patch] v2 fix /proc/self/maps output

2013-04-02 Thread Christophe Lyon
Add a space at end of line when there is no filename to print, to conform to linux kernel format (see show_map_vma() in fs/proc/task_mmu.c). Signed-off-by: Christophe Lyon --- Changes v1-v2: Additional space is now part of the format string. linux-user/syscall.c |4 ++-- 1 file changed, 2

[Qemu-devel] [PATCH] rsqrte_f32: No need to copy sign bit.

2011-10-03 Thread Christophe Lyon
Indeed, the result is known to be always positive. Signed-off-by: Christophe Lyon --- target-arm/helper.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d3a3ba2..ff5456c 100644 --- a/target-arm/helper.c +++ b/target-arm

Re: [Qemu-devel] [PATCH] rsqrte_f32: No need to copy sign bit.

2011-10-10 Thread Christophe Lyon
On 09.10.2011 00:57, Peter Maydell wrote: On 3 October 2011 15:28, Christophe Lyon wrote: Indeed, the result is known to be always positive. -val = ((val64>> 63)& 0x8000) -| ((result_exp& 0xff)<< 23) +val = ((result_exp& 0xff)<<

[Qemu-devel] [Bug 1590336] [NEW] qemu-arm does not reject vrintz on non-v8 cpu

2016-06-08 Thread Christophe Lyon
Public bug reported: Hello, It seems that qemu-arm does not reject some v8-only instructions as it should, but executes them "correctly". For instance, while compiling/running some of the GCC ARM instrinsics tests, we noticed that vrintz should be rejected on cortex-a9 for instance, while it is

Re: [Qemu-devel] [PATCH] target-arm: Don't permit ARMv8-only Neon insns on ARMv7

2016-06-09 Thread Christophe Lyon
ll the other new-in-v8 insns, but forgot > it for these Neon 2-reg-misc ops.) > > Reported-by: Christophe Lyon > Signed-off-by: Peter Maydell > --- > Christophe: I'd appreciate it if you could give this a quick test > and confirm that it fixes the bug for you. > I

[Qemu-devel] [Bug 1590336] Re: qemu-arm does not reject vrintz on non-v8 cpu

2016-06-09 Thread Christophe Lyon
I confirm your patch does fix the problem. You may still want to fix the disassembler such that it dumps the right instruction, but that would be a separate fix. Thanks for your quick support. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH] ARM: semi-hosting support for stderr

2010-11-15 Thread Christophe Lyon
On 14.11.2010 18:50, Peter Maydell wrote: > Although newlib/libgloss use different modes for opening stdout > and stderr, the ARM C library implementation does not, for > instance; so your patch is relying on a detail of implementation of > a particular semihosting user. So I don't think we can app

[Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
Fix garbage collection of temporaries in Neon emulation. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 57664bc..363351e 100644 --- a

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
On 18.01.2011 16:26, Peter Maydell wrote: > On 18 January 2011 14:34, Christophe Lyon wrote: >> + >> +/* gen_helper_neon_mull_[su]{8|16} do not free their parameters. >> + Don't forget to clean them now. */ >> +switch ((size << 1) | u) { >&g

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
On 18.01.2011 16:36, Peter Maydell wrote: > Incidentally there are some correctness fixes for the multiply-by-scalar > neon insns from the qemu-meego tree which are on my list to push > upstream. So you probably aren't getting the right results even if > you've managed to shut up qemu's warnings :-

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-19 Thread Christophe Lyon
Here is an updated patch which will hopefully not be mangled by my mailer. Fix garbage collection of temporaries in Neon emulation. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/target-arm

[Qemu-devel] [PATCH] Support saturation with shift=0.

2011-01-19 Thread Christophe Lyon
This patch fixes corner-case saturations, when the target range is zero. It merely removes the guard against (sh == 0), and makes: __ssat(0x87654321, 1) return 0x and set the saturation flag __usat(0x87654321, 0) return 0 and set the saturation flag Signed-off-by: Christophe Lyon

Re: [Qemu-devel] [PATCH] Support saturation with shift=0.

2011-01-20 Thread Christophe Lyon
On 19.01.2011 17:51, Peter Maydell wrote: > On 19 January 2011 16:10, Christophe Lyon wrote: >> >> This patch fixes corner-case saturations, when the target range is >> zero. It merely removes the guard against (sh == 0), and makes: >> __ssat(0x87654321, 1) re

[Qemu-devel] Re: [PATCH] target-arm: Fix loading of scalar value for Neon multiply-by-scalar

2011-01-20 Thread Christophe Lyon
On 19.01.2011 20:29, Peter Maydell wrote: > Fix the register and part of register we get the scalar from in > the various "multiply vector by scalar" ops (VMUL by scalar > and friends). > I do confirm that with this patch, I can see many improvements in my tests. Thanks.

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-20 Thread Christophe Lyon
on of temporaries in Neon emulation". > OK, so here is the same patch with an updated description: target-arm: Fix garbage collection of temporaries in Neon emulation of MULL and friends (VMLAL, VQDMLAL, VMLSL, VQDMLSL, VMULL, VQDMULL) as well as (VSHRN, VRSHRN, VQSHRN, VQRSHRN). Si

[Qemu-devel] [PATCH] target-arm: Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-01-20 Thread Christophe Lyon
and adds the 64 bits case. Signed-off-by: Christophe Lyon Signed-off-by: Peter Maydell --- target-arm/helpers.h | 12 -- target-arm/neon_helper.c | 89 ++ target-arm/op_helper.c | 49 - target-arm/translate.c

[Qemu-devel] [ARM] Contributing tests for Neon

2011-01-21 Thread Christophe Lyon
Hi all, I have developed some tests for ARM-Neon in the form of C sources files calling ARM Neon intrinsics, and comparing the results of the resulting program with a known reference (eg execution on actual CPU) shows if the execution engine is follows the spec. These tests currently represent

Re: [Qemu-devel] [ARM] Contributing tests for Neon

2011-01-24 Thread Christophe Lyon
>> How about you make it available somewhere (tarball via http, git >> repository on gitorious, or other method of your choice) for the >> moment? Then we can take a look at it and proceed from there. > > I agree, this is a good first step. If possible, its good if you > can publish source and bi

Re: [Qemu-devel] [PATCH] target-arm: Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-01-24 Thread Christophe Lyon
Oops. What is the "official" emacs configuration to get the right qemu style? > You can check for this sort of thing by running scripts/checkpatch.pl, Thanks for the pointer. Here is an updated patch with these minor fixes. Christophe. Signed-off-by: Christophe Lyon --- t

Re: [Qemu-devel] [ARM] Contributing tests for Neon

2011-01-24 Thread Christophe Lyon
On 24.01.2011 11:23, Christophe Lyon wrote: > OK, I am going to have a look at gitorious. In the mean time, I have a bit of > cleanup and minimal documentation to perform. > Hi, You can have a look at http://gitorious.org/arm-neon-tests/arm-neon-tests. For sure it will need some polis

[Qemu-devel] ARM/system mode/stdin

2010-06-14 Thread Christophe LYON
Hello, I am trying to use qemu-system-arm (0.12.3) to execute an ARM bare machine program (not a Linux kernel), and I have some trouble when the program in question tries to read from stdin. The program does use ARM semihosting to communicate with the host. Here is the sample code: =

Re: [Qemu-devel] ARM/system mode/stdin

2010-06-16 Thread Christophe LYON
Hi all, After more investigation, I am wondering whether there is a conflict between 2 entities reading for stdin: - one is initialized by qemu_chr_open_stdio() (in qemu-char.c) - the 2nd one is the handling of SYS_READ in arm-semi.c After some debug/tracing, I have noticed that a few chars a

[Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.

2011-01-25 Thread Christophe Lyon
This patch fixes the errors reported by my tests in VSRA. Signed-off-by: Christophe Lyon --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 7cb48c0..4cf2ecd 100644 --- a/target-arm

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-01-31 Thread Christophe Lyon
On 31.01.2011 09:20, Aurelien Jarno wrote: > On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote: >> From: Christophe Lyon >> >> Handle corner cases where the addition of the rounding constant could >> cause overflows. > > After applying th

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-01-31 Thread Christophe Lyon
On 31.01.2011 10:44, Aurelien Jarno wrote: > On Mon, Jan 31, 2011 at 10:35:30AM +0100, Christophe Lyon wrote: >> On 31.01.2011 09:20, Aurelien Jarno wrote: >>> On Fri, Jan 28, 2011 at 04:50:59PM +0100, christophe.l...@st.com wrote: >>>> From: Christophe Lyon >&

Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.

2011-01-31 Thread Christophe Lyon
On 25.01.2011 18:18, Christophe Lyon wrote: > This patch fixes the errors reported by my tests in VSRA. > ping?

Re: [Qemu-devel] [PATCH] target-arm: Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-01-31 Thread Christophe Lyon
On 24.01.2011 13:41, Christophe Lyon wrote: > Here is an updated patch with these minor fixes. > ping?

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-01-31 Thread Christophe Lyon
On 31.01.2011 17:46, Peter Maydell wrote: > On 31 January 2011 15:59, Aurelien Jarno wrote: >> It seems the problems come from here, if I add --enable-debug, I am not >> able to reproduce the problem anymore. I don't understand why though. > > --enable-debug turns off optimisation (ie does not pa

[Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return floatxx_default_nan when the corresponding target status flag is set.

2011-02-04 Thread Christophe Lyon
. This patch only modifies the commonNaNToFloat32 and commonNaNToFloat64 conversion functions, as ARM only uses these. Signed-off-by: Christophe Lyon --- checkpatch complains in this patch, but I have kept the style already present in the involved files. fpu/softfloat-specialize.h | 15

[Qemu-devel] [PATCH v3] Set the right overflow bit for neon 32 and 64 bit saturating add/sub.

2011-02-04 Thread Christophe Lyon
Signed-off-by: Christophe Lyon --- target-arm/helpers.h | 12 -- target-arm/neon_helper.c | 89 ++ target-arm/op_helper.c | 49 - target-arm/translate.c | 18 - 4 files changed, 105 insertions(+), 63

[Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-07 Thread Christophe Lyon
Some CPUs have a status flag imposing to return floatxx_default_nan whatever the input value, when converting from one FP format to another. Implement this, using the already existing default_nan_mode status flag (currently used on ARM and SH4 at the moment). Signed-off-by: Christophe Lyon

Re: [Qemu-devel] [PATCH] Softfloat: Add support to softfloat to return floatxx_default_nan when the corresponding target status flag is set.

2011-02-07 Thread Christophe Lyon
On 04.02.2011 20:47, Aurelien Jarno wrote: > On Fri, Feb 04, 2011 at 02:44:48PM +, Peter Maydell wrote: >> On 4 February 2011 14:01, Christophe Lyon wrote: >> >> The target-specific #ifdef is pretty ugly. I wanted to be safe (not breaking other targets), and as there are

[Qemu-devel] [PATCH v2] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-07 Thread Christophe Lyon
Some CPUs have a status flag imposing to return floatxx_default_nan whatever the input value, when converting from one FP format to another. Implement this, using the already existing default_nan_mode status flag (currently used on ARM and SH4 at the moment). Signed-off-by: Christophe Lyon

Re: [Qemu-devel] [PATCH 6/8] target-arm: Fix Neon VQ(R)SHRN instructions.

2011-02-07 Thread Christophe Lyon
On 07.02.2011 17:08, Peter Maydell wrote: > On 31 January 2011 18:06, wrote: >> From: Christophe Lyon >> >> Handle unsigned variant of VQ(R)SHRN instructions. > > This patch appears to be modifying a section of code > that was already patched by 2/8 in this ser

[Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64

2011-02-08 Thread Christophe Lyon
Signed-off-by: Christophe Lyon --- Submitted as a standalone patch as suggested by Peter, along with his corrections. target-arm/translate.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index e4649e6

Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to return floatxx_default_nan when, the corresponding target status flag is set.

2011-02-08 Thread Christophe Lyon
On 08.02.2011 16:59, Peter Maydell wrote: > Your subject is a bit long, which can make it wrap annoyingly in git logs. > I'd suggest something like: OK. > This is float32_to_float16() but it looks like you've missed > float16_to_float32() ? Well, actually I somewhat managed to persuade myself

Re: [Qemu-devel] [PATCH 1/8] target-arm: Fixes for several shift instructions: VRSHL, VRSHR, VRSHRN, VSHLL, VRSRA.

2011-02-09 Thread Christophe Lyon
On 07.02.2011 16:57, Peter Maydell wrote: > On 31 January 2011 18:06, wrote: >> For variants with rounding, fix cases where adding the rounding >> constant could overflow. >> >> For VSHLL, fix bit mask. > > These two things are completely distinct -- please put them > in separate patches. > OK

[Qemu-devel] [PATCH v2] target-arm: fix VSHLL Neon instruction.

2011-02-09 Thread Christophe Lyon
Fix bit mask used when widening the result of shift on narrow input. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index b694eed..16c61f1

[Qemu-devel] [PATCH] target-arm: fix VQMOVUN Neon instruction.

2011-02-09 Thread Christophe Lyon
Create and use neon_unarrow_sat* helpers. Signed-off-by: Christophe Lyon --- target-arm/helpers.h |3 ++ target-arm/neon_helper.c | 63 ++ target-arm/translate.c | 28 3 files changed, 88 insertions(+), 6 deletions

[Qemu-devel] [PATCH] target-arm: fix support for vrecpe.

2011-02-14 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 72 ++ 1 files changed, 60 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7f63a28

Re: [Qemu-devel] [PATCH] target-arm: fix support for vrecpe.

2011-02-14 Thread Christophe Lyon
On 14.02.2011 10:46, Christophe Lyon wrote: > > Now use the same algorithm as described in the ARM ARM. > oops sorry, I have sent the wrong patch. Please ignore this version. Christophe.

[Qemu-devel] [PATCH] softfloat: export float32_nan and float32_infinity.

2011-02-14 Thread Christophe Lyon
These two special values are needed to implement some helper functions, which return these values in some cases. Signed-off-by: Christophe Lyon --- fpu/softfloat-specialize.h |9 + fpu/softfloat.h|2 ++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/6] target-arm: Fix rounding constant addition for Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 14.02.2011 19:12, Peter Maydell wrote: > On 11 February 2011 15:10, wrote: >> +uint32_t HELPER(neon_rshl_s32)(uint32_t valop, uint32_t shiftop) >> +{ >> +int32_t dest; >> +int32_t val = (int32_t)valop; >> +int8_t shift = (int8_t)shiftop; >> +if (shift >= 32) { >> +dest

Re: [Qemu-devel] [PATCH 2/6] target-arm: fix Neon right shifts with shift amount == input width.

2011-02-15 Thread Christophe Lyon
>> -dest = src1 >> (tmp - 1); \ >> +dest = src1 >> (-tmp - 1); \ >> dest++; \ >> dest >>= 1; \ > > Again, these three lines have the same effect as dest = 0, > so we can fold into the previous if(). > >> } else if (tmp < 0) { \ >> @@ -594,7 +594,7 @@ uint64_t

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 14.02.2011 19:18, Peter Maydell wrote: > On 11 February 2011 15:10, wrote: >> From: Christophe Lyon >> >> This patch series provides fixes such that ARM Neon instructions >> VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now >> pass all my

Re: [Qemu-devel] [PATCH 4/6] target-arm: fix saturated values for Neon right shifts.

2011-02-15 Thread Christophe Lyon
>> @@ -924,7 +924,11 @@ uint32_t HELPER(neon_qrshl_s32)(CPUState *env, uint32_t >> valop, uint32_t shiftop) >> dest = val << shift; >> if ((dest >> shift) != val) { >> SET_QC(); >> -dest = (uint32_t)(1 << (sizeof(val) * 8 - 1)) - (val > 0 ? 1 : >> 0); >> +

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 15.02.2011 15:21, Peter Maydell wrote: > On 15 February 2011 14:03, Christophe Lyon wrote: >> It also seems that the neon_shl_s* helpers don't handle correctly large >> negative shift amounts. > > They look OK to me (large -ve shift is a huge right shift, > w

[Qemu-devel] Re: [PATCH 00/10] Fix Neon shift instructions

2011-02-15 Thread Christophe Lyon
On 15.02.2011 14:44, Peter Maydell wrote: > This patch series fixes bugs in the Neon shift instructions > VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN, > VRSHL, and VQRSHL. It is based on the v3 patchset Christophe > sent recently, with some fixes for minor nits in those patches,

Re: [Qemu-devel] [PATCH] softfloat: export float32_nan and float32_infinity.

2011-02-16 Thread Christophe Lyon
On 16.02.2011 12:53, Peter Maydell wrote: > On 14 February 2011 16:47, Christophe Lyon wrote: >> >> These two special values are needed to implement some helper functions, >> which return these values in some cases. > > I assume this is for vrecpe, right? I think i

Re: [Qemu-devel] [PATCH 1/2] softfloat: export float32_nan and float32_infinity.

2011-02-16 Thread Christophe Lyon
On 16.02.2011 17:54, Peter Maydell wrote: > On 16 February 2011 14:51, wrote: >> From: Christophe Lyon >> >> These two special values are needed to implement some helper >> functions, which return these values in some cases. >> >> This patch also moves th

Re: [Qemu-devel] [PATCH 2/3] target-arm: fix support for vrecpe.

2011-02-17 Thread Christophe Lyon
>> +float_status *s = &env->vfp.standard_fp_status; >> +float64 one = int64_to_float64(1, s); > You don't need to create a variable for this, float64_one > will do what you want. OK >> +/* q = (int)(a * 512.0) */ >> +float64 x512 = int64_to_float64(512, s); >> +float64 q = f

[Qemu-devel] [PATCH v4 0/4] ARM: fix Neon VRECPE and VRSQRTE instructions.

2011-02-18 Thread Christophe Lyon
, float64_256 and float64_512. Patch #3 uses these newly exported values and uses the VRECPE algorithm described in the ARM ARM. Patch #4 uses these newly exported values and uses the VRSQRTE algorithm described in the ARM ARM. Thanks to Peter for his careful reviews. Christophe Lyon (4): softfloat

[Qemu-devel] [PATCH 2/4] softfloat: add float32_set_sign(), float32_infinity, float64_half, float64_256 and float64_512.

2011-02-18 Thread Christophe Lyon
These constants and utility function are needed to implement some helpers. Defining constants avoids the need to re-compute them at runtime. Signed-off-by: Christophe Lyon --- fpu/softfloat.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/fpu/softfloat.h b/fpu

[Qemu-devel] [PATCH 4/4] target-arm: fix support for VRSQRTE.

2011-02-18 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 121 ++ 1 files changed, 111 insertions(+), 10 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index af8b067

[Qemu-devel] [PATCH 3/4] target-arm: fix support for VRECPE.

2011-02-18 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 83 +++--- 1 files changed, 71 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7f63a28

[Qemu-devel] [PATCH 1/4] softfloat: move all default NaN definitions to softfloat.h.

2011-02-18 Thread Christophe Lyon
These special values are needed to implement some helper functions, which return/use these values in some cases. Signed-off-by: Christophe Lyon --- fpu/softfloat-specialize.h | 68 --- fpu/softfloat.h| 69

[Qemu-devel] [PATCH] target-arm: return the right exit code when using semi-hosting.

2011-02-18 Thread Christophe Lyon
On ARM, the SYS_EXIT semi-hosting call has no room for application exit code, hence exiting a program from qemu always returns 0. This patch catches to argument passed to exit() and uses it as the return code when processing SYS_EXIT. Signed-off-by: Christophe Lyon --- arm-semi.c

Re: [Qemu-devel] [PATCH] target-arm: return the right exit code when using semi-hosting.

2011-02-18 Thread Christophe Lyon
On 18.02.2011 17:13, Peter Maydell wrote: > > I'm afraid you've just run into the limitations of semihosting > as an API again: it doesn't provide a way for programs to pass Indeed. > out an exit code, and trying to shoehorn back doors for this > into qemu just results in ugly code in qemu. The q

Re: [Qemu-devel] [PATCH 2/4] softfloat: add float32_set_sign(), float32_infinity, float64_half, float64_256 and float64_512.

2011-02-21 Thread Christophe Lyon
On 20.02.2011 23:20, Aurelien Jarno wrote: > On Sun, Feb 20, 2011 at 10:09:46PM +, Peter Maydell wrote: >> On 20 February 2011 21:52, Aurelien Jarno wrote: >>> While it's probably a good idea to define the commonly used values in >>> softfloat.h, I don't think we should have all the values use

[Qemu-devel] [PATCH 3/5] target-arm: Introduce float64_256 and float64_512 constants.

2011-02-21 Thread Christophe Lyon
These two constants will be used by helper functions such as recpe_f32 and rsqrte_f32. Signed-off-by: Christophe Lyon --- target-arm/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7f63a28..30c1809 100644

[Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.

2011-02-21 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 121 ++ 1 files changed, 111 insertions(+), 10 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7445def

[Qemu-devel] [PATCH 2/5] softfloat: add _set_sign(), _infinity and _half for 32 and 64 bits floats.

2011-02-21 Thread Christophe Lyon
These constants and utility function are needed to implement some helpers. Defining constants avoids the need to re-compute them at runtime. Signed-off-by: Christophe Lyon --- fpu/softfloat.h | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/fpu/softfloat.h

[Qemu-devel] [PATCH 4/5] target-arm: fix support for VRECPE.

2011-02-21 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 83 +++--- 1 files changed, 71 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 30c1809

[Qemu-devel] [PATCH 1/5] softfloat: move all default NaN definitions to softfloat.h.

2011-02-21 Thread Christophe Lyon
These special values are needed to implement some helper functions, which return/use these values in some cases. Signed-off-by: Christophe Lyon --- fpu/softfloat-specialize.h | 68 --- fpu/softfloat.h| 69

[Qemu-devel] [PATCH v5 0/5] ARM: fix Neon VRECPE and VRSQRTE instructions.

2011-02-21 Thread Christophe Lyon
x27;s comments into account (http://patchwork.ozlabs.org/patch/83603/): constants 256 and 512 are now defined locally in target-arm/helper.c. Christophe Lyon (5): softfloat: move all default NaN definitions to softfloat.h. softfloat: add _set_sign(), _infinity and _half for 32 and 64 bits f

[Qemu-devel] [PATCH v6 0/5] ARM: fix Neon VRECPE and VRSQRTE instructions.

2011-02-21 Thread Christophe Lyon
These 5 patches fix the ARM Neon VRECPE and VRSQRTE instructions by matching the algorithms descibed in the ARM ARM. Patches #1 to #3 are unchanged compared to v4 Patches #4 and #5 should address Peter's comments. Christophe Lyon (5): softfloat: move all default NaN definitions to softfl

[Qemu-devel] [PATCH 3/5] target-arm: Introduce float64_256 and float64_512 constants.

2011-02-21 Thread Christophe Lyon
These two constants will be used by helper functions such as recpe_f32 and rsqrte_f32. Signed-off-by: Christophe Lyon --- target-arm/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7f63a28..30c1809 100644

[Qemu-devel] [PATCH 2/5] softfloat: add _set_sign(), _infinity and _half for 32 and 64 bits floats.

2011-02-21 Thread Christophe Lyon
These constants and utility function are needed to implement some helpers. Defining constants avoids the need to re-compute them at runtime. Signed-off-by: Christophe Lyon --- fpu/softfloat.h | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/fpu/softfloat.h

[Qemu-devel] [PATCH 4/5] target-arm: fix support for VRECPE.

2011-02-21 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 83 +++--- 1 files changed, 71 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 30c1809

[Qemu-devel] [PATCH 1/5] softfloat: move all default NaN definitions to softfloat.h.

2011-02-21 Thread Christophe Lyon
These special values are needed to implement some helper functions, which return/use these values in some cases. Signed-off-by: Christophe Lyon --- fpu/softfloat-specialize.h | 68 --- fpu/softfloat.h| 69

[Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.

2011-02-21 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 123 ++ 1 files changed, 113 insertions(+), 10 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 031f2ec

Re: [Qemu-devel] ARM/system mode/stdin

2010-06-21 Thread Christophe LYON
On 18.06.2010 18:52, Paul Brook wrote: $ qemu-system-arm -semihosting -cpu cortex-a9 -nographic -kernel ./input.exe -nographic implies -monitor stdio -serial stdio. Don't do that if you want to access stdio via semihosting. Indeed, using either -monitor null -serial none -nographic or -monit

[Qemu-devel] [PATCH] ARM: semi-hosting support for stderr

2010-06-25 Thread Christophe LYON
Hello, I propose this small patch so that ARM semi-hosting handles stderr as expected when linking with Newlib/libgloss. diff --git a/arm-semi.c b/arm-semi.c index 9549e6c..6874036 100644 --- a/arm-semi.c +++ b/arm-semi.c @@ -211,8 +211,11 @@ uint32_t do_arm_semihosting(CPUState *env)

[Qemu-devel] [PATCH] make qemu.log name unique

2010-06-29 Thread Christophe LYON
Hello, I propose this small patch so that the qemu log file has a unique name, to help running several QEmu processes at once (or with different users). Is it OK? Thanks Christophe. diff --git a/exec.c b/exec.c index 5969eb2..5ba8d7e 100644 --- a/exec.c +++ b/exec.c @@ -1516,7 +1516,10 @@ v

Re: [Qemu-devel] [PATCH] make qemu.log name unique

2010-07-01 Thread Christophe LYON
Maybe adding a -logfile option would allow what you're trying to achieve without affecting other use cases? I've always thought that it's strange that you can only change the logfile location in the monitor and not on the command line. Kevin Here is patch that does what you suggest. Christo

Re: [Qemu-devel] [PATCH] make qemu.log name unique

2010-07-05 Thread Christophe LYON
latforms. I hope my mailer won't scramble everything. Signed-off-by: Christophe Lyon bsd-user/main.c| 34 -- darwin-user/main.c | 32 +++- linux-user/main.c | 32 +++- qemu-doc.texi

Re: [Qemu-devel] [PATCH] ARM: semi-hosting support for stderr

2010-08-19 Thread Christophe Lyon
Ping? On 25.06.2010 17:44, Christophe LYON wrote: Hello, I propose this small patch so that ARM semi-hosting handles stderr as expected when linking with Newlib/libgloss. diff --git a/arm-semi.c b/arm-semi.c index 9549e6c..6874036 100644 --- a/arm-semi.c +++ b/arm-semi.c @@ -211,8 +211,11

[Qemu-devel] [ARM] SYS_GET_CMDLINE handling

2010-04-09 Thread Christophe LYON
Hello, I am facing a problem when using qemu-arm, when the target code uses the SYS_GET_CMDLINE semi-hosting call. Indeed, in arm-semi.c (line ~376), args are read from ts->info->host_argv, which in turn has been initialised much earlier in linuxload.c:load_exec with the value of target_argv

[Qemu-devel] [Bug 1832353] [NEW] cpu_exec: Assertion !have_mmap_lock() failed

2019-06-11 Thread Christophe Lyon
Public bug reported: Hi, I have isolated a testcase from the GCC testsuite (actually gfortran, test proc_ptr_51.f90) which produces tons of: qemu-arm: /home/christophe.lyon/src/qemu/accel/tcg/cpu-exec.c:701: cpu_exec: Assertion `!have_mmap_lock()' failed. including with master qemu as of today.

[Qemu-devel] [Bug 1832353] Re: cpu_exec: Assertion !have_mmap_lock() failed

2019-06-13 Thread Christophe Lyon
It's fairly recent: qemu-arm version 4.0.50 (v4.0.0-1215-ga578cdf-dirty) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf Merge: 19735c8 43b3952 Author: Peter Maydell Date: Mon Jun 10 16:09:19 2019 +0100 Merge remote-t

[Bug 1721275] Re: Support more ARM CPUs

2019-10-23 Thread Christophe Lyon
It seemed "easy" to add cortex-m7 based on cortex-m4 (copy m4 description, update ID register values), but I realized that QEMU does not support FPv5 which not only supports DP, but also adds new instructions that QEMU does not handle yet (see section A2.5 of the ARMv7-M ARM). * Are there plans to

[Bug 1927530] [NEW] qemu-aarch64 MTE fails to report tag mismatch

2021-05-06 Thread Christophe Lyon
Public bug reported: Hi, While running the GCC testsuite with qemu-6.0 as simulator, I noticed several errors in the hwasan testsuite (output pattern tests). I am attaching: bitfield-2.exe ld-linux-aarch64.so.1 libc.so.6 libdl.so.2 libhwasan.so.0 libm.so.6 libpthread.so.0 librt.so.1 The testcas

[Bug 1878348] Re: --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2021-05-06 Thread Christophe Lyon
I have re-tested at commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac, and the build succeeded, so it looks like the problem has been fixed. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is sub

[Bug 1927530] Re: qemu-aarch64 MTE fails to report tag mismatch

2021-05-06 Thread Christophe Lyon
*** This bug is a duplicate of bug 1921948 *** https://bugs.launchpad.net/bugs/1921948 Sorry, I didn't think about rpath when I tried to execute what I had extracted. Here are the additional libstdc++.so.6 and libgcc_s.so.1. I am using a more recent qemu version than 6.0, almost head: d45a527

[Bug 1927530] Re: qemu-aarch64 MTE fails to report tag mismatch

2021-05-06 Thread Christophe Lyon
*** This bug is a duplicate of bug 1921948 *** https://bugs.launchpad.net/bugs/1921948 ** Attachment added: "libgcc_s.so.1" https://bugs.launchpad.net/qemu/+bug/1927530/+attachment/5495299/+files/libgcc_s.so.1 -- You received this bug notification because you are a member of qemu- devel

[Qemu-devel] [Bug 1721275] [NEW] Support more ARM CPUs

2017-10-04 Thread Christophe Lyon
Public bug reported: Hi, This is an enhancement request, rather than a bug report. After some discussions/presentations during the last Linaro Connect (SFO17), I understand that it may be easy to add support for more ARM CPUs in QEMU. I am interested in user-mode, if that matters. I'm primarily

[Qemu-devel] [Bug 1721275] Re: Support more ARM CPUs

2017-10-16 Thread Christophe Lyon
Thanks for PS, I thought QEMU was stricter than that. Regarding M7 vs M$ or A35 vs A53/A57, even though there's no functional difference, it would be convenient in Makefiles to have CPU=cortex-a53, and use $(CPU) to expand GCC and QEMU options, without having to guess which CPU I should use for QE

[Qemu-devel] [ARM/FDPIC v2 0/4] FDPIC ABI for ARM

2018-04-23 Thread Christophe Lyon
ponds to the previous patch #2, and uses TaskState instead of CPUARMState - patch #4 corresponds to the previous patch #3, and fixes guest pointer dereferencing Is this now OK? Thanks, Christophe Christophe Lyon (4): Remove CONFIG_USE_FDPIC. linux-user: ARM-FDPIC: Identify ARM FDPIC bin

[Qemu-devel] [ARM/FDPIC v2 4/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-23 Thread Christophe Lyon
uthored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/signal.c b/linux-user/signal.c index 8d9e6e8..d01b459 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -2045,13 +2045,13 @@ struct sigframe_v1 { struct target_sigcontext sc; abi_ulong

[Qemu-devel] [ARM/FDPIC v2 1/4] Remove CONFIG_USE_FDPIC.

2018-04-23 Thread Christophe Lyon
would prevent QEMU from building precisely because elf_is_fdpic is not defined. Signed-off-by: Christophe Lyon diff --git a/linux-user/elfload.c b/linux-user/elfload.c index c77ed1b..bbe93b0 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1681,7 +1681,12 @@ static void zero_bss

[Qemu-devel] [ARM/FDPIC v2 2/4] linux-user: ARM-FDPIC: Identify ARM FDPIC binaries

2018-04-23 Thread Christophe Lyon
Define an ARM-specific version of elf_is_fdpic: FDPIC ELF objects are identified with e_ident[EI_OSABI] == ELFOSABI_ARM_FDPIC. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/include/elf.h b/include/elf.h index c0dc9bb..934dbbd 100644 --- a/include/elf.h +++ b/include

  1   2   >