>> @@ -924,7 +924,11 @@ uint32_t HELPER(neon_qrshl_s32)(CPUState *env, uint32_t >> valop, uint32_t shiftop) >> dest = val << shift; >> if ((dest >> shift) != val) { >> SET_QC(); >> - dest = (uint32_t)(1 << (sizeof(val) * 8 - 1)) - (val > 0 ? 1 : >> 0); >> + if (val < 0) { >> + dest = INT32_MIN; >> + } else { >> + dest = INT32_MAX; >> + } > > Again, right answers but the way most of the rest of the code > forces a 32 bit value to signed saturation is > dest = (val >> 31) ^ ~SIGNBIT; >
Indeed; I hadn't given a close look at how saturation is performed elsewhere. Anyway I find my version more readable ;-) Quite a few times, I have wondered whether there are rules in QEmu development helping decide between performance of the code vs readability/maintainability? Christophe.