On 15.02.2011 15:21, Peter Maydell wrote: > On 15 February 2011 14:03, Christophe Lyon <christophe.l...@st.com> wrote: >> It also seems that the neon_shl_s* helpers don't handle correctly large >> negative shift amounts. > > They look OK to me (large -ve shift is a huge right shift, > which for signed values should propagate the sign bit > to all bit positions, so we shift-right by typesize - 1), > and I didn't see any problems with them when I was > doing my testing. What do you think they get wrong? >
Sorry, you are right. I was confused by comparing with the shifts with rounding. Maybe we should add a few comments in a few places... :-)
