On 04.02.2011 20:47, Aurelien Jarno wrote: > On Fri, Feb 04, 2011 at 02:44:48PM +0000, Peter Maydell wrote: >> On 4 February 2011 14:01, Christophe Lyon <christophe.l...@st.com> wrote: >> >> The target-specific #ifdef is pretty ugly. I wanted to be safe (not breaking other targets), and as there are already some #ifdef in the same file, it seemed acceptable ;-)
> > I confirm that the same bug is present on SH4 (tested on real hardware), > so the same fix is needed there. Thanks for catching that. Can you > please resend your patch without the #ifdef? > OK >> (cc'ing Aurelien to check since he's the SH4 maintainer.) >> >> I also think the change is simple enough that we ought to do >> it consistently for the floatx80 and float128 functions even if >> neither ARM nor sh4 use them. >> > > Agreed. > OK. I was also wondering about the float16 case? The ARM ARM describes it uses default_nan too, but I couldn't find that right piece of code to patch in softfloat. Any idea? It seems to behave a bit differently from other FP formats. Christophe.
