Re: [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-11-03 Thread Fam Zheng
On Tue, 11/04 07:47, Markus Armbruster wrote: > Fam Zheng writes: > > > On Mon, 11/03 15:32, Kevin Wolf wrote: > >> Am 03.11.2014 um 02:46 hat Fam Zheng geschrieben: > >> > On Fri, 10/31 10:01, Kevin Wolf wrote: > >> > > Am 11.09.2014 um 07:05 hat Fam Zheng geschrieben: > >> > > > Similar to driv

[Qemu-devel] [PATCH v2] smbios: changed for "smbios_build_type_17_table()" to take 'uint64_t'

2014-11-03 Thread SeokYeon Hwang
"smbios_build_type_17_table()" should take 'uint64_t' instead of 'ram_addr_t' because it should be able to handle (16ll * GiB). Otherwise, clang (>= 3.4) produces compilation warning in "smbios_get_tables()". Signed-off-by: SeokYeon Hwang --- hw/i386/smbios.c | 2 +- 1 file changed, 1 insertion

[Qemu-devel] [PATCH v2] qdev: modify func qdev_build_hotpluggable_device_list

2014-11-03 Thread Jun Li
Currently when *obj is not a TYPE_DEVICE, qemu will abort. This patch just fixed it. When *obj is not a TYPE_DEVICE, just do not add it to hotpluggable device list. This patch also fixed the following issue: 1, boot qemu using cli: $ /opt/qemu-git-arm/bin/qemu-system-x86_64 -monitor stdio -enable-

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >> >> "Michael S. Tsirkin" writes: >> >> >> >> > tcp_get_fds API discards fds if there's

Re: [Qemu-devel] [PATCH] smbios: fixed compiler warning on clang > 3.4

2014-11-03 Thread SeokYeon Hwang
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, November 04, 2014 1:16 AM > To: SeokYeon Hwang; qemu-devel@nongnu.org > Cc: arm...@redhat.com; alex.william...@hp.com > Subject: Re: [PATCH] smbios: fixed compiler warni

Re: [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-11-03 Thread Markus Armbruster
Fam Zheng writes: > On Mon, 11/03 15:32, Kevin Wolf wrote: >> Am 03.11.2014 um 02:46 hat Fam Zheng geschrieben: >> > On Fri, 10/31 10:01, Kevin Wolf wrote: >> > > Am 11.09.2014 um 07:05 hat Fam Zheng geschrieben: >> > > > Similar to drive-backup, but this command uses a device id as target >> > >

Re: [Qemu-devel] using qemu arm bring up 2 cpus on x86, hang up on guest file system

2014-11-03 Thread Wangkai (Kevin,C)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, November 01, 2014 1:07 AM > To: Wangkai (Kevin,C) > Cc: qemu-devel@nongnu.org; Lee yang > Subject: Re: [Qemu-devel] using qemu arm bring up 2 cpus on x86, hang > up on guest file system > > On

Re: [Qemu-devel] Improved shared folders support

2014-11-03 Thread Michael Tokarev
03.11.2014 22:46, Peter Wu wrote: > On Monday 03 November 2014 15:58:35 Michael Tokarev wrote: >> 03.11.2014 15:22, Peter Wu wrote: >> [] >>> As an aside, would it be possible to override the samba binary at runtime, >>> without compiling? Either an envvar (SMBD) or an option (-net >>> user,smb=...

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-03 Thread Wu, Feng
I still see this error in the latest QEMU. I find that this patch is not merged in. Anybody knows why? Thanks, Feng > -Original Message- > From: qemu-devel-bounces+feng.wu=intel@nongnu.org > [mailto:qemu-devel-bounces+feng.wu=intel@nongnu.org] On Behalf Of > Igor Mammedov > Sent:

Re: [Qemu-devel] [PATCH v4 29/47] Postcopy page-map-incoming (PMI) structure

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:35PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The PMI holds the state of each page on the incoming side, > so that we can tell if the page is missing, already received > or there is a request outstanding for it. > > Signed-off-

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread zhanghailiang
On 2014/11/3 23:33, Markus Armbruster wrote: zhanghailiang writes: On 2014/11/3 18:03, Michael Tokarev wrote: 03.11.2014 12:44, zhanghailiang wrote: Patch 1~3 fix wrong check about in-parameter. The last two patches convert some open functions to use Error API. v2: - don't use error_setg wh

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread zhanghailiang
On 2014/11/3 22:10, Michael Tokarev wrote: 03.11.2014 14:39, zhanghailiang wrote: On 2014/11/3 18:03, Michael Tokarev wrote: 03.11.2014 12:44, zhanghailiang wrote: Patch 1~3 fix wrong check about in-parameter. The last two patches convert some open functions to use Error API. v2: - don't use

Re: [Qemu-devel] [PATCH v4 28/47] qemu_savevm_state_complete: Postcopy changes

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:34PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When postcopy calls qemu_savevm_state_complete it's not really > the end of migration, so skip: >a) Finishing postcopiable iterative devices - they'll carry on >b) The termin

Re: [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-11-03 Thread Fam Zheng
On Mon, 11/03 15:32, Kevin Wolf wrote: > Am 03.11.2014 um 02:46 hat Fam Zheng geschrieben: > > On Fri, 10/31 10:01, Kevin Wolf wrote: > > > Am 11.09.2014 um 07:05 hat Fam Zheng geschrieben: > > > > Similar to drive-backup, but this command uses a device id as target > > > > instead of creating/open

Re: [Qemu-devel] [PATCH v4 27/47] MIG_STATE_POSTCOPY_ACTIVE: Add new migration state

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:33PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > 'MIG_STATE_POSTCOPY_ACTIVE' is entered after migrate_start_postcopy > > 'migration_postcopy_phase' is provided for other sections to know if > they're in postcopy. > > Signed-off-b

Re: [Qemu-devel] [PATCH v4 26/47] migrate_start_postcopy: Command to trigger transition to postcopy

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:32PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Once postcopy is enabled (with migrate_set_capability), the migration > will still start on precopy mode. To cause a transition into postcopy > the: > > migrate_start_postcopy >

Re: [Qemu-devel] [PATCH v4 24/47] Allow savevm handlers to state whether they could go into postcopy

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:30PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Use that to split the qemu_savevm_state_pending counts into postcopiable > and non-postcopiable amounts > > Signed-off-by: Dr. David Alan Gilbert > --- > arch_init.c

Re: [Qemu-devel] [PATCH v4 25/47] postcopy: OS support test

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:31PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Provide a check to see if the OS we're running on has all the bits > needed for postcopy. > > Creates postcopy-ram.c which will get most of the other helpers we need. > > Signed-of

Re: [Qemu-devel] [PATCH v4 22/47] QEMU_VM_CMD_PACKAGED: Send a packaged chunk of migration stream

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:28PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > QEMU_VM_CMD_PACKAGED is a migration command that allows a chunk > of migration stream to be sent in one go, and be received by > a separate instance of the loadvm loop while not inte

Re: [Qemu-devel] [PATCH v4 23/47] migrate_init: Call from savevm

2014-11-03 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:29PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Suspend to file is very much like a migrate, and it makes life > easier if we have the Migration state available, so initialise it > in the savevm.c code for suspending. > > Signed-

Re: [Qemu-devel] hardfreeze probably going to slip a day or so

2014-11-03 Thread Peter Maydell
On 4 November 2014 00:35, Peter Maydell wrote: > Hi; just a note to say that I still have the mips pullreq > to process, plus I'm expecting a late ppc pullreq from Alex > (who has had more important things to attend to recently ;-)) > and I need to send out my own arm pullreq with a few last > pat

[Qemu-devel] [PULL] OpenBIOS updates for 2.2

2014-11-03 Thread Mark Cave-Ayland
Hi Peter, Apologies for the last minute nature of the pull request (I've been away), however this is an OpenBIOS update in preparation for the 2.2 release. Please pull. ATB, Mark. The following changes since commit 47e8acb45feddcbc340583781b53935459330db2: Merge remote-tracking branch 'r

Re: [Qemu-devel] [PATCH 5/5] target-arm/translate.c: Don't pass CPUARMState * to disas_arm_insn()

2014-11-03 Thread Peter Maydell
On 31 October 2014 13:47, Alex Bennée wrote: > > Peter Maydell writes: > >> Refactor to avoid passing a CPUARMState * to disas_arm_insn(). To do this >> we move the "read insn from memory" code to the callsite and pass the >> insn to the function instead. >> > >> >> -static void disas_arm_insn(C

Re: [Qemu-devel] [PATCH 3/5] target-arm/translate.c: Don't use IS_M()

2014-11-03 Thread Peter Maydell
On 31 October 2014 13:42, Alex Bennée wrote: > > Peter Maydell writes: > >> Instead of using IS_M(), use arm_dc_feature(s, ARM_FEATURE_M), so we >> don't need to pass CPUARMState pointers around the decoder. >> >> Signed-off-by: Peter Maydell > > I almost wondered if it was killing of the IS_M m

[Qemu-devel] hardfreeze probably going to slip a day or so

2014-11-03 Thread Peter Maydell
Hi; just a note to say that I still have the mips pullreq to process, plus I'm expecting a late ppc pullreq from Alex (who has had more important things to attend to recently ;-)) and I need to send out my own arm pullreq with a few last patches too. So (given it's gone midnight here too) we're def

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Peter Maydell
On 3 November 2014 16:35, Michael S. Tsirkin wrote: > OK I backed that patch out and re-pushed. > As other patches are unchanged, I don't want to re-do the pull > request, it's just spam on list. > > Tag name is still for_upstream, new hash > d43f0d641e366251bd9c63005241775f672bf3ec OK, thanks; I

[Qemu-devel] [PATCH 4/5] ahci: Check cmd_fis[1] more explicitly

2014-11-03 Thread John Snow
Instead of checking for a known byte, inspect the fields of this byte explicitly to produce more meaningful error messages and improve the readability of this section. Signed-off-by: John Snow --- hw/ide/ahci.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff

[Qemu-devel] [PATCH 5/5] ahci: factor out FIS decomposition from handle_cmd

2014-11-03 Thread John Snow
In order to make handle_cmd more readable at the macro level, the details of how to decompose particular types of FIS packets are left to helper functions. In our case, the only type of FIS packet we currently expect to see is a Register H2D FIS packet, but the gory details of its decomposition ar

[Qemu-devel] [PATCH 3/5] ahci: Reorder error cases in handle_cmd

2014-11-03 Thread John Snow
Error checking in ahci's handle_cmd is re-ordered so that we initialize as few things as possible before we've done our sanity checking. This simplifies returning from this call in case of an error. A check to make sure the DMA memory map succeeds with the correct size is also added, and the debug

[Qemu-devel] [PATCH 1/5] ahci: add is_ncq predicate helper

2014-11-03 Thread John Snow
A small helper to determine which S/ATA commands are destined to be routed to the NCQ pathways. This references SATA 3.2 section 13.6, Native Command Queueing. See sections 13.6.4, 13.6.5, 13.6.6, 13.6.7 and 13.6.8 for all SATA commands considered to be part of the NCQ feature set. This is summari

[Qemu-devel] [PATCH 0/5] ahci: fis decomposition improvements

2014-11-03 Thread John Snow
This patch series may require, and is based on another AHCI series pending on-list: http://lists.gnu.org/archive/html/qemu-devel/2014-10/msg04143.html This series aims to improve the way that handle_cmd reads and behaves in interpreting the FIS packets received by the AHCI HBA. This series used to

[Qemu-devel] [PATCH 2/5] ahci: Fix FIS decomposition

2014-11-03 Thread John Snow
This patch introduces a few changes to how FIS packets are deciphered in the AHCI virtual device. The summary of changes can be grouped into two pieces: [A] Changes to how we apply a preliminary sieve to FISes, [B] Changes in how we internalize a decomposed FIS. == Changes to how we apply a preli

Re: [Qemu-devel] [PATCH v8 26/27] target-arm: make MAIR0/1 banked

2014-11-03 Thread Greg Bellows
On 31 October 2014 12:31, Peter Maydell wrote: > On 30 October 2014 21:28, Greg Bellows wrote: > > Added CP register info entries for the ARMv7 MAIR0/1 secure banks. > > > > Signed-off-by: Greg Bellows > > > > --- > > > > v5 -> v6 > > - Changed _el field variants to be array based > > --- > >

Re: [Qemu-devel] [PATCH v8 23/27] target-arm: make PAR banked

2014-11-03 Thread Greg Bellows
On 31 October 2014 12:21, Peter Maydell wrote: > On 30 October 2014 21:28, Greg Bellows wrote: > > From: Fabian Aggeler > > > > When EL3 is running in AArch32 (or ARMv7 with Security Extensions) > > PAR has a secure and a non-secure instance. > > > > Signed-off-by: Fabian Aggeler > > Signed-of

Re: [Qemu-devel] [PATCH v8 22/27] target-arm: make IFAR/DFAR banked

2014-11-03 Thread Greg Bellows
On 31 October 2014 11:24, Peter Maydell wrote: > On 30 October 2014 21:28, Greg Bellows wrote: > > From: Fabian Aggeler > > > > When EL3 is running in AArch32 (or ARMv7 with Security Extensions) > > IFAR and DFAR have a secure and a non-secure instance. > > > > Signed-off-by: Fabian Aggeler >

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_pci.c: Avoid functions not in glib 2.12 (g_hash_table_iter_*)

2014-11-03 Thread Alexey Kardashevskiy
On 11/03/2014 03:31 PM, Alexander Graf wrote: > > > On 30.10.14 13:33, Peter Maydell wrote: >> Ping! It would be nice to be able to get glib2.12 builds fixed... > > Thanks, applied to ppc-next. Uff. I misread the original mail and decided I have to do the patch :) I checked ppc-next, works fine

Re: [Qemu-devel] [PATCH v8 25/27] target-arm: make c13 cp regs banked (FCSEIDR, ...)

2014-11-03 Thread Greg Bellows
On 31 October 2014 12:27, Peter Maydell wrote: > On 30 October 2014 21:28, Greg Bellows wrote: > > From: Fabian Aggeler > > > > When EL3 is running in AArch32 (or ARMv7 with Security Extensions) > > FCSEIDR, CONTEXTIDR, TPIDRURW, TPIDRURO and TPIDRPRW have a secure > > and a non-secure instance

Re: [Qemu-devel] [PULL 0/3] linux-user changes for 2.2

2014-11-03 Thread Peter Maydell
On 3 November 2014 12:02, wrote: > From: Riku Voipio > > The following changes since commit 0a2923f8488498000eec54871456aa64a4391da4: > > tcg/mips: fix store softmmu slow path (2014-11-02 13:30:00 +0100) > > are available in the git repository at: > > git://git.linaro.org/people/riku.voipio/

Re: [Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked

2014-11-03 Thread Peter Maydell
On 3 November 2014 22:06, Greg Bellows wrote: > You seem to not be a fan of the fields setting moved around and Fabian > appears to have done this in a number of places. I left them as is because > I found the changes to add consistency and compactness. I particularly dislike it where it makes t

Re: [Qemu-devel] ui/gtk.c vs old gtk versions

2014-11-03 Thread Cole Robinson
On 11/03/2014 08:32 AM, Daniel P. Berrange wrote: On Mon, Nov 03, 2014 at 02:11:35PM +0100, Kevin Wolf wrote: Am 03.11.2014 um 14:06 hat Cornelia Huck geschrieben: After the latest gtk updates, master fails to build for me on a SLES11SP3 machine: /home/cohuck/git/qemu/ui/gtk.c: In function ‘gd

Re: [Qemu-devel] [PATCH v8 24/27] target-arm: make VBAR banked

2014-11-03 Thread Greg Bellows
You seem to not be a fan of the fields setting moved around and Fabian appears to have done this in a number of places. I left them as is because I found the changes to add consistency and compactness. Would you like me to undo any such changes? Greg On 31 October 2014 12:22, Peter Maydell wro

Re: [Qemu-devel] [PATCH v8 19/27] target-arm: make DACR banked

2014-11-03 Thread Greg Bellows
Added DACR32_EL2 definition and converted dacr fields to uint64_t in v9. On 31 October 2014 10:38, Peter Maydell wrote: > On 30 October 2014 21:28, Greg Bellows wrote: > > From: Fabian Aggeler > > > > When EL3 is running in AArch32 (or ARMv7 with Security Extensions) > > DACR has a secure and

Re: [Qemu-devel] [PULL 00/53] Block patches

2014-11-03 Thread Peter Maydell
On 3 November 2014 11:50, Stefan Hajnoczi wrote: > The following changes since commit 0a2923f8488498000eec54871456aa64a4391da4: > > tcg/mips: fix store softmmu slow path (2014-11-02 13:30:00 +0100) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/block-pu

[Qemu-devel] [PATCH 4/7] target-ppc: mffs. Should Set CR1 from FPSCR Bits

2014-11-03 Thread Tom Musta
Update the Move From FPSCR (mffs.) instruction to correctly set CR[1] from FPSCR[FX,FEX,VX,OX]. Signed-off-by: Tom Musta --- target-ppc/translate.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 9653ba9..0247af5 1

[Qemu-devel] [PATCH 7/7] target-ppc: Eliminate set_fprf Argument From helper_compute_fprf

2014-11-03 Thread Tom Musta
The set_fprf argument to the helper_compute_fprf helper function is no longer necessary -- the helper is only invoked when FPSCR[FPRF] is going to be set. Eliminate the unnecessary argument from the function signature and its corresponding implementation. Change the return value of the helper to

[Qemu-devel] [PATCH 5/7] target-ppc: Fully Migrate to gen_set_cr1_from_fpscr

2014-11-03 Thread Tom Musta
Eliminate the set_rc argument from the gen_compute_fprf utility and the corresponding (and incorrect) implementation. Replace it with calls to the gen_set_cr1_from_fpscr() utility. Signed-off-by: Tom Musta --- target-ppc/translate.c | 55 --- 1 file

[Qemu-devel] [PATCH 6/7] target-ppc: Eliminate set_fprf Argument From gen_compute_fprf

2014-11-03 Thread Tom Musta
The set_fprf argument to the gen_compute_fprf() utility is no longer needed -- gen_compute_fprf() is now called only when FPRF is actually computed and set. Eliminate the obsolete argument. Signed-off-by: Tom Musta --- target-ppc/translate.c | 38 +++--- 1 file

[Qemu-devel] [PATCH 3/7] target-ppc: Fix Floating Point Move Instructions That Set CR1

2014-11-03 Thread Tom Musta
The Floating Point Move instructions (fmr., fabs., fnabs., fneg., and fcpsgn.) incorrectly copy FPSCR[FPCC] instead of [FX,FEX,VX,OX]. Furthermore, the current code does this via a call to gen_compute_fprf, which is awkward since these instructions do not actually set FPRF. Change the code to use

[Qemu-devel] [PATCH 1/7] target-ppc: VXSQRT Should Not Be Set for NaNs

2014-11-03 Thread Tom Musta
The Power ISA square root instructions (fsqrt[s], frsqrte[s]) must set the FPSCR[VXSQRT] flag when operating on a negative value. However, NaNs have no sign and therefore this flag should not be set when operating on one. Change the order of the checks in the helper code. Move the SNaN-to-QNaN ma

[Qemu-devel] [PATCH 2/7] target-ppc: Introduce gen_set_cr1_from_fpscr

2014-11-03 Thread Tom Musta
The Power ISA supports a mode in many floating point instructions whereby the Condition Register field 1 (CR[1]) receives a copy of the Floating Point Status (FPSCR) bits 32:35, also known as FX, FEX VX and OX. The existing QEMU code is mostly wrong -- CR[1] is set to the Floating Point Condition

[Qemu-devel] [PATCH 0/7] target-ppc: Assorted Floating Point Bugs and Cleanup

2014-11-03 Thread Tom Musta
This patch series corrects some issues with floating point emulation on Power. Patch 1 corrects a corner case in the square root instructions, which incorrectly react to NaNs whose sign bit is a 1. Patches 2-6 correct a pervasive problem with modeling of the CR[1] field (i.e. the so-called "dot f

Re: [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes

2014-11-03 Thread John Snow
On 11/03/2014 07:35 AM, Paolo Bonzini wrote: On 31/10/2014 21:03, John Snow wrote: - Adjust the prepare_buf() callback to return, simply, the number of bytes it was able to prepare, or -1 on error. This resolves an ambiguity around the nature of its return code meaning "no sectors" or

[Qemu-devel] Improved shared folders support (was: Re: slirp-smb broken with Samba 4.1)

2014-11-03 Thread Peter Wu
On Monday 03 November 2014 15:58:35 Michael Tokarev wrote: > 03.11.2014 15:22, Peter Wu wrote: > [] > > As an aside, would it be possible to override the samba binary at runtime, > > without compiling? Either an envvar (SMBD) or an option (-net > > user,smb=...,smbd=...). > > The whole thing needs

[Qemu-devel] [PATCH] mips: Add 5KEc and 5KEf MIPS64r2 processors

2014-11-03 Thread Maciej W. Rozycki
Add the 5KEc and 5KEf processors from MIPS Technologies that are the original implementation of the MIPS64r2 ISA. Silicon for these processors has never been taped out and no soft cores were released even. They do exist though, a CP0.PRId value has been assigned and experimental RTLs produced

[Qemu-devel] [PATCH 8/11] fixup! pc: align DIMM's address/size by backend's alignment value

2014-11-03 Thread Igor Mammedov
Performance wise it's better to align GVA by the backend's page size. Also do not allow to create DIMM device with suboptimal size (i.e. not aligned to backends page size) to aviod memory loss. Do above only for 2.2 and newer machine types to avoid breaking working configs with 2.1 machine type.

Re: [Qemu-devel] the need for if=none for -drive?

2014-11-03 Thread John Snow
On 11/02/2014 02:21 AM, Michael Tokarev wrote: All "modern" 2-way drive/device specifications need to explicitly specify if=none for the drive for it to not be used in the default ide bus implicitly. Which behave like this? I am reasonably sheltered in the IDE and S/ATA lands. But how abo

Re: [Qemu-devel] [PATCH 03/11] pc: check if KVM has enough memory slots for DIMM devices

2014-11-03 Thread Igor Mammedov
On Mon, 03 Nov 2014 18:32:51 +0100 Paolo Bonzini wrote: > > > On 03/11/2014 18:00, Igor Mammedov wrote: > >> > This will always be off by 4 or so due to system RAM and ROM > >> > slots. I think patch 1 is enough. > > The goal of this patch is to prevent starting guest with not > > supported am

[Qemu-devel] [PATCH] mips: Respect CP0.Status.CU1 for microMIPS FP branches

2014-11-03 Thread Maciej W. Rozycki
Make microMIPS FP branches respect CP0.Status.CU1 and trap with a Coprocessor Unusable exception if COP1 has been disabled; also trap if no FPU is present at all. Standard MIPS FP instruction encodings have a more regular structure and branches are covered with a single umbrella along other ins

Re: [Qemu-devel] [PATCH v4 10/47] Return path: Open a return path on QEMUFile for sockets

2014-11-03 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:16PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Postcopy needs a method to send messages from the destination back to > > the source, this is the 'return path'. > > > >

Re: [Qemu-devel] [PATCH v4 11/47] Return path: socket_writev_buffer: Block even on non-blocking fd's

2014-11-03 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:17PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The return path uses a non-blocking fd so as not to block waiting > > for the (possibly broken) destination to finish retu

[Qemu-devel] [PATCH] mips/gdbstub: Make CP1.FIR read-only here too

2014-11-03 Thread Maciej W. Rozycki
CP1.FIR is read-only in hardware so gdbstub must respect it. We already respect it for CTC1 instructions, so do it here too. Signed-off-by: Maciej W. Rozycki --- Not much to say about it here. Please apply. Maciej qemu-mips-fir.diff Index: qemu-git-trunk/target-mips/gdbstub.c =

[Qemu-devel] [PATCH] mips/gdbstub: Correct the handling of register #72 on writes

2014-11-03 Thread Maciej W. Rozycki
Fix an off-by-one error in `mips_cpu_gdb_write_register' for register #72 that is handled further down in that function rather than here, matching how `mips_cpu_gdb_read_register' handles it. This register slot is a fake anyway, there's nothing in hardware that corresponds to it. Signed-off-b

Re: [Qemu-devel] State of ARM FIQ in Qemu

2014-11-03 Thread Greg Bellows
On 3 November 2014 10:22, Tim Sander wrote: > Hi Greg > > Thanks for your fast reply. > > I am still in the process of getting the security extension portion of > the > > GIC patches fully up and running. By the sounds of your use, it sounds > > like you just want FIQ support not necessarily sec

Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2014-11-03 Thread John Snow
PING for this refactor series, which will allow me to check in more AHCI tests. To assist review, I'll annotate this cover letter a little bit with some additional information. The hardest/ugliest patch to review is the first one, but it is primarily just variable name/location changes and not

[Qemu-devel] [PATCH] mips: Remove CONFIG_VT82C686 from non-Fulong configs

2014-11-03 Thread Maciej W. Rozycki
Fix the regression introduced with commit 47934d0aadc075b05ce2d9e8a44fa6a46edd1afa [hw: move ISA bridges and devices to hw/isa/, configure with default-configs/], by removing CONFIG_VT82C686 from configurations that previously did not enable it. That southbridge is only available on Fulong pla

Re: [Qemu-devel] [PULL 0/8] target-xtensa queue 2014-11-03

2014-11-03 Thread Peter Maydell
are available in the git repository at: > > git://github.com/OSLL/qemu-xtensa.git tags/20141103-xtensa > > for you to fetch changes up to 437a8c11c06f53ed3bcdcc3e5abc5d20b2d439bd: > > MAINTAINERS: update xtensa boards (2014-11-03 01:00:37 +0300) > > -

Re: [Qemu-devel] [PATCH 08/11] pc: align DIMM's address/size by backend's alignment value

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 09:48:20PM +0400, Andrey Korolyov wrote: > On Fri, Oct 31, 2014 at 7:38 PM, Igor Mammedov wrote: > > Performance wise it's better to align GVA by the backend's > > page size. > > > > Also do not allow to create DIMM device with suboptimal > > size (i.e. not aligned to backe

[Qemu-devel] [PATCH 02/12] qcow2: Pull up overlap check option evaluation

2014-11-03 Thread Max Reitz
Pull up the absorption of the qcow2-relevant command line options and the evaluation of the overlap check options in qcow2_open(). Signed-off-by: Max Reitz --- block/qcow2.c | 96 +-- 1 file changed, 48 insertions(+), 48 deletions(-) diff

Re: [Qemu-devel] [PATCH 00/12] qcow2: Add new overlap check functions

2014-11-03 Thread Max Reitz
On 2014-11-03 at 18:04, Max Reitz wrote: As has been requested, this series adds new overlap check functions to the qcow2 code. My local branch is called "qcow2-improved-overlap-v1", but I am not so sure whether it is actually an improvement; that is left for you to decide, dear reviewers. See p

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/smbd: disable printer in smb config

2014-11-03 Thread Peter Wu
On Monday 03 November 2014 17:15:24 Michael Tokarev wrote: > BTW, I'm not sure `socket address' paraameter is relevant in this context > at all, -- smbd should not use it in inetd mode. It'd be interesting to > know why this option is here to start with, and whenever we really need > the new inter

Re: [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes

2014-11-03 Thread Alexander Graf
On 31.10.14 17:06, Tom Musta wrote: > Correct the opcodes for the vrfim, vrfin and vrfiz instructions. > > Signed-off-by: Tom Musta Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH] target-ppc: Fix Altivec Shifts

2014-11-03 Thread Alexander Graf
On 29.10.14 16:02, Tom Musta wrote: > Fix the implementation of the Altivec shift left and shift right > instructions (vsl, vsr) which erroneously inverts shift direction > on big endian hosts. > > Signed-off-by: Tom Musta Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH] target-ppc: Fix vcmpbfp. Unordered Case

2014-11-03 Thread Alexander Graf
On 31.10.14 17:39, Tom Musta wrote: > Fix the implementation of Vector Compare Bounds Single Precision. > Specifically, fix the case where the operands are unordered -- since > the result is non-zero, the CR[6] field should be set to zero. > > Signed-off-by: Tom Musta Thanks, applied to ppc-ne

Re: [Qemu-devel] [PATCH 08/11] pc: align DIMM's address/size by backend's alignment value

2014-11-03 Thread Andrey Korolyov
On Fri, Oct 31, 2014 at 7:38 PM, Igor Mammedov wrote: > Performance wise it's better to align GVA by the backend's > page size. > > Also do not allow to create DIMM device with suboptimal > size (i.e. not aligned to backends page size) to aviod > memory loss. > > Do above only for 2.2 and newer ma

[Qemu-devel] [PATCH] kvmclock: Add comment explaining why we need cpu_clean_all_dirty()

2014-11-03 Thread Eduardo Habkost
Try to explain why commit 317b0a6d8ba44e9bf8f9c3dbd776c4536843d82c needed a cpu_clean_all_dirty() call just after calling cpu_synchronize_all_states(). Signed-off-by: Eduardo Habkost Cc: Andrey Korolyov Cc: Marcin Gibuła Cc: Marcelo Tosatti Cc: Paolo Bonzini --- hw/i386/kvm/clock.c | 14

Re: [Qemu-devel] [PATCH for-2.1 2/2] acpi: mark ACPI tables ROM blob as extend-able on migration

2014-11-03 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > It fixes migration failure for machine type pc-i440fx-1.7 from > QEMU 1.7/2.0 to QEMU 2.1 > > Migration fails due to ACPI tables size grows across 1.7-2.1 > versions. That causes ACPI tables ROM blob to change its size > differently for the same confi

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 1/2] vhost: add VHOST_VRING_F_BYTESWAP flag

2014-11-03 Thread Greg Kurz
On Mon, 3 Nov 2014 16:29:31 +0100 Cornelia Huck wrote: > On Wed, 29 Oct 2014 09:42:09 +0100 > Cédric Le Goater wrote: > > > When the guest and the host have a different endian order, the data > > being accessed in the vring queues needs to be byteswapped. > > > > This patch adds a VHOST_VRING_

Re: [Qemu-devel] [PATCH 03/11] pc: check if KVM has enough memory slots for DIMM devices

2014-11-03 Thread Paolo Bonzini
On 03/11/2014 18:00, Igor Mammedov wrote: >> > This will always be off by 4 or so due to system RAM and ROM slots. I >> > think patch 1 is enough. > The goal of this patch is to prevent starting guest with not supported > amount of lots requested on CLI with -m slots=too_much, patch 1 won't > pr

[Qemu-devel] [PATCH 12/12] qcow2: Use new metadata overlap check function

2014-11-03 Thread Max Reitz
Make the static new overlap check function global and drop the old function. Signed-off-by: Max Reitz --- block/qcow2-overlap.c | 8 +--- block/qcow2-refcount.c | 120 - 2 files changed, 2 insertions(+), 126 deletions(-) diff --git a/block/qcow

[Qemu-devel] [PATCH 11/12] qcow2/overlaps: Protect inactive L2 tables

2014-11-03 Thread Max Reitz
Keep track of the inactive L2 tables in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 20 block/qcow2-snapshot.c | 41 +++-- 2 files changed, 59 insertions(+), 2 d

[Qemu-devel] [PATCH 09/12] qcow2/overlaps: Protect snapshot table

2014-11-03 Thread Max Reitz
Keep track of the snapshot table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-snapshot.c | 10 ++ block/qcow2.c | 6 ++ 2 files changed, 16 insertions(+) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snap

[Qemu-devel] [PATCH 06/12] qcow2/overlaps: Protect refcount blocks

2014-11-03 Thread Max Reitz
Keep track of the refcount blocks in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/qcow2-refcount.c b/block/q

[Qemu-devel] [PATCH 10/12] qcow2/overlaps: Protect inactive L1 tables

2014-11-03 Thread Max Reitz
Keep track of the inactive L1 tables in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-snapshot.c | 25 + 1 file changed, 25 insertions(+) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index c32

[Qemu-devel] [PATCH 07/12] qcow2/overlaps: Protect active L1 table

2014-11-03 Thread Max Reitz
Keep track of the active L1 table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 11 +++ block/qcow2-snapshot.c | 10 ++ block/qcow2.c | 4 3 files changed, 25 insertions(+) diff --git a/b

[Qemu-devel] [PATCH 08/12] qcow2/overlaps: Protect active L2 tables

2014-11-03 Thread Max Reitz
Keep track of the active L2 tables in the metadata list to protect them against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 2 ++ block/qcow2-refcount.c | 6 ++ block/qcow2-snapshot.c | 21 + block/qcow2.c | 8 +++- 4 fi

[Qemu-devel] [PATCH 05/12] qcow2/overlaps: Protect refcount table

2014-11-03 Thread Max Reitz
Keep track of the refcount table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 18 ++ block/qcow2.c | 4 2 files changed, 22 insertions(+) diff --git a/block/qcow2-refcount.c b/block/qcow

[Qemu-devel] [PATCH 03/12] qcow2: Create metadata list

2014-11-03 Thread Max Reitz
Create and destroy the metadata list on creation and destruction of a qcow2 BDS, respectively. Skip creation if no overlap checks should be performed. Signed-off-by: Max Reitz --- block/qcow2.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index ed

[Qemu-devel] [PATCH 00/12] qcow2: Add new overlap check functions

2014-11-03 Thread Max Reitz
As has been requested, this series adds new overlap check functions to the qcow2 code. My local branch is called "qcow2-improved-overlap-v1", but I am not so sure whether it is actually an improvement; that is left for you to decide, dear reviewers. See patch 1 for an explanation of why this serie

[Qemu-devel] [PATCH 01/12] qcow2: Add new overlap check functions

2014-11-03 Thread Max Reitz
The existing qcow2 metadata overlap detection function used existing structures to determine the location of the image metadata, from plain fields such as l1_table_offset and l1_size in the BDRVQcowState, over image structures in memory such as the L1 table for the L2 tables' positions, or it even

[Qemu-devel] [PATCH 04/12] qcow2/overlaps: Protect image header

2014-11-03 Thread Max Reitz
Enter the image header into the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz --- block/qcow2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index f80f9ed..19ac2df 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -7

Re: [Qemu-devel] [PATCH 03/11] pc: check if KVM has enough memory slots for DIMM devices

2014-11-03 Thread Igor Mammedov
On Mon, 03 Nov 2014 12:51:50 +0100 Paolo Bonzini wrote: > On 31/10/2014 17:38, Igor Mammedov wrote: > > check amount of available KVM memory slots after all > > devices were initialized and exit with error if > > there isn't enough free memory slots for DIMMs. > > > > Signed-off-by: Igor Mammedo

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 04:22:57PM +, Peter Maydell wrote: > On 3 November 2014 16:13, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writes: > >>> > >>> > tcp_get_fds API discar

Re: [Qemu-devel] [PULL 00/23] Trivial patches for 2014-11-02

2014-11-03 Thread Peter Maydell
On 2 November 2014 11:57, Michael Tokarev wrote: > Here's an almost 3-week trivial patches pull request. > Lots of small things here and there, many small bugfixes > too. This is also a first pull request for which a > signature should finally be known to others. > > Please consider applying/pull

Re: [Qemu-devel] [PATCH] vdi: wrapped uuid_unparse() in #ifdef

2014-11-03 Thread Paolo Bonzini
On 31/10/2014 09:02, SeokYeon Hwang wrote: > Wrapped uuid_unparse() in #ifdef to avoid "-Wunused-function" on clang 3.4 or > later. > > Signed-off-by: SeokYeon Hwang > --- > block/vdi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/vdi.c b/block/vdi.c > index 19701ee..e1d2

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > tcp_get_fds API discards fds if there's more than 1 of these. > >> > >> s/tcp

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > tcp_get_fds API discards fds if there's more than 1 of these. >> >> s/tcp_get_fds/tcp_get_msgfds/ (subject as well) > > Right. Too late as I sent this upstr

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 04:22:57PM +, Peter Maydell wrote: > On 3 November 2014 16:13, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writes: > >>> > >>> > tcp_get_fds API discar

[Qemu-devel] [PULL 33/34] disas/mips.c: disassemble MSA instructions

2014-11-03 Thread Leon Alrae
From: Yongbok Kim disassemble MIPS SIMD Architecture instructions Signed-off-by: Yongbok Kim Signed-off-by: Leon Alrae --- disas/mips.c | 716 ++- 1 file changed, 714 insertions(+), 2 deletions(-) diff --git a/disas/mips.c b/disas/mips.

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Peter Maydell
On 3 November 2014 16:13, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >>> "Michael S. Tsirkin" writes: >>> >>> > tcp_get_fds API discards fds if there's more than 1 of these. >>> >>> s/tcp_get_fds/tcp_get_msgfds/

[Qemu-devel] [PULL 34/34] target-mips: add MSA support to mips32r5-generic

2014-11-03 Thread Leon Alrae
From: Yongbok Kim add MSA support to mips32r5-generic core definition Signed-off-by: Yongbok Kim Reviewed-by: Leon Alrae Signed-off-by: Leon Alrae --- target-mips/translate_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate_init.c b/target-mi

  1   2   3   4   >