On 31 October 2014 13:47, Alex Bennée <alex.ben...@linaro.org> wrote: > > Peter Maydell <peter.mayd...@linaro.org> writes: > >> Refactor to avoid passing a CPUARMState * to disas_arm_insn(). To do this >> we move the "read insn from memory" code to the callsite and pass the >> insn to the function instead. >> > <snip> >> >> -static void disas_arm_insn(CPUARMState * env, DisasContext *s) >> +static void disas_arm_insn(DisasContext *s, unsigned int insn) > > I note that in the aarch64 code we used the unambiguous uint32_t for the > insn type. I'm hard pressed to imagine it actually breaking anything > though.
Yeah, we already strongly assume int to be 32 bits, and I wanted to make this patch not mess with the type of the existing variable. thanks -- PMM
