On Mon, Feb 03, 2025 at 02:34:29PM +0300, Nazir Bilal Yavuz wrote:
> On Mon, 3 Feb 2025 at 11:50, Bertrand Drouvot
> wrote:
>> === 1
>>
>> + pgstat_count_io_op_time(IOOBJECT_WAL, IOCONTEXT_INIT, IOOP_WRITE,
>> + io_start, 1,
>> wal_segm
hi.
This attached patch solves problems mentioned in [1].
so pg_restore --file restoring multiple databases will have the
```\connect dbname``` command in it.
the output plain text file can be used in psql.
pg_restore --file output will be:
--
-- Database "template1" dump
--
-- Dumped from data
On Mon, Feb 03, 2025 at 10:37:54AM +, Bertrand Drouvot wrote:
> Based on those results the patch does not show a noticable impact when IO
> timing
> tracking is/are enabled.
I have spent a good portion of my day doing benchmarking with your
scenarios as much as Nazir's scenarios posted at [1]
On Tue, Feb 4, 2025 at 12:05 PM vignesh C wrote:
>
> On Tue, 4 Feb 2025 at 11:52, Nisha Moond wrote:
> >
> > Here is the v2 patch with above change and other comments from [1] and
> > [2] incorporated.
>
> One small suggestion:
> Since we will not be retaining inactive time for invalid slots afte
> On 4 Feb 2025, at 06:50, Tom Lane wrote:
>
> Peter Eisentraut writes:
>> During the developer meeting at FOSDEM last Thursday,
>
> BTW, are there minutes available from that meeting? In past years
> some notes have been posted on the wiki, but I'm failing to find
> anything right now.
They
Hello,
Here is a new patch version.
I tried to use perl 'version' instead of 'api_versionstring' to sync
with configure script.
--
Roman ZharkovFrom: Zharkov Roman
Date: Thu, 17 Oct 2024 13:09:51 +0700
Subject: [PATCH] Show plperl version in the meson setup summary.
Use perl 'version' instea
On Tue, 4 Feb 2025 at 11:52, Nisha Moond wrote:
>
> Here is the v2 patch with above change and other comments from [1] and
> [2] incorporated.
One small suggestion:
Since we will not be retaining inactive time for invalid slots after
server restart, the inactive time will be lost in this case, sh
On Mon, Feb 3, 2025 at 6:19 PM Dmitry Koterov wrote:
>
> What's also suspicious is that on the destination node, after copying
> finishes,
>
> # explain select 1 from mytable;
> Seq Scan on mytable (cost=0.00..6821514.12 rows=250410012 width=4)
>
> # SELECT relname, n_live_tup FROM pg_stat_user_
On Mon, Feb 3, 2025 at 5:51 PM Dmitry Koterov wrote:
>
> Here is the list of tmp files:
>
> postgres@pg-101a:~/17/main/base/pgsql_tmp$ ls -la
> total 5422297
> drwx-- 2 postgres postgres 9 Feb 3 04:08 .
> drwx-- 8 postgres postgres 8 Jan 29 01:27 ..
> -rw--- 1 postgr
Hi,
In
"Re: Make COPY format extendable: Extract COPY TO format implementations" on
Mon, 03 Feb 2025 13:38:04 +0700,
Vladlen Popolitov wrote:
> I would like to inform about the security breach in your design of
> COPY TO/FROM.
Thanks! I didn't notice it.
> You use FORMAT option to add ne
On Tue, Feb 4, 2025 at 9:33 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Monday, February 3, 2025 8:03 PM Nisha Moond
> wrote:
> >
> > Hi Hackers,
> > (CC people involved in the earlier discussion)
> >
> > Right now, it is possible for the 'inactive_since' value of an invalid
> > replication
> > slot
Inlined the hex encode/decode functions in "src/include/utils/builtins.h"
similar to pg_popcount() in pg_bitutils.h.
---
Chiranmoy
v3-0001-SVE-support-for-hex-encode-and-hex-decode.patch
Description: v3-0001-SVE-support-for-hex-encode-and-hex-decode.patch
Peter Eisentraut writes:
> During the developer meeting at FOSDEM last Thursday,
BTW, are there minutes available from that meeting? In past years
some notes have been posted on the wiki, but I'm failing to find
anything right now.
regards, tom lane
On Tue, 2025-02-04 at 12:50 +0900, Michael Paquier wrote:
> On Tue, Feb 04, 2025 at 09:21:49AM +0900, Michael Paquier wrote:
> > Being able to pass down some runtime states to a callback is
> > something
> > I've drafted a patch for, as of:
> > https://www.postgresql.org/message-id/z23zce4w1djuk...
On Tue, 2024-01-23 at 12:32 +0900, Michael Paquier wrote:
> Slightly off topic and while I don't forget about it.. Please find
> attached a copy of the patch posted around [1] to be able to define
> injection points with input arguments, so as it is possible to
> execute
> callbacks with values co
On Mon, Feb 3, 2025 at 6:35 PM Shlok Kyal wrote:
>
> I reviewed the v66 patch. I have few comments:
>
> 1. I also feel the default value should be set to '0' as suggested by
> Vignesh in 1st point of [1].
>
+1. This will ensure that the idle slots won't be invalidated by
default, the same as HEAD
On Tue, Feb 4, 2025 at 4:02 AM Peter Smith wrote:
>
> On Mon, Feb 3, 2025 at 5:34 PM Amit Kapila wrote:
> >
> > On Mon, Feb 3, 2025 at 6:16 AM Peter Smith wrote:
> > >
> > >
> > > 2.
> > > + appendStringInfo(&err_hint, "You might need to increase \"%s\".",
> > > + "max_slot_wal_keep_size");
> >
On Mon, Feb 3, 2025 at 5:55 PM Alvaro Herrera wrote:
>
> On 2025-Feb-03, Ashutosh Bapat wrote:
>
> > ```
> > If the
> > constraint is NOT ENFORCED, the database system
> > will
> > not check the constraint. It is then up to the application code to
> > ensure that the cons
Dmitrii Bondar писал(а) 2025-01-29 16:53:
Hi, Hackers!
I was testing a connection pooler with `make installcheck` and noticed
that `check_foreign_key()` from the `refint` library reuses the same
cached plan for cascade `UPDATE`/`DELETE` operations. As a result, a
cascade `DELETE` is applied a
On Monday, February 3, 2025 8:03 PM Nisha Moond
wrote:
>
> Hi Hackers,
> (CC people involved in the earlier discussion)
>
> Right now, it is possible for the 'inactive_since' value of an invalid
> replication
> slot to be updated multiple times, which is unexpected behavior.
> As suggested in
On Tue, Feb 4, 2025 at 8:37 AM Peter Smith wrote:
>
> Some review comments for patch v1-0001
>
> ==
> GENERAL - Missing Test case?
>
> 1.
> Should there be some before/after test case for 'active_since' value
> with invalid slots to verify that the patch is doing what it says?
>
I think the e
On Tue, Feb 04, 2025 at 09:21:49AM +0900, Michael Paquier wrote:
> Being able to pass down some runtime states to a callback is something
> I've drafted a patch for, as of:
> https://www.postgresql.org/message-id/z23zce4w1djuk...@paquier.xyz
Oops. I've posted an incorrect link here, I meant this
On Friday, January 31, 2025 9:43 PM Kuroda, Hayato/黒田 隼人
>
> Dear Ajin, Hou,
>
> > - Snapshot construction
>
> I understand the approach that we do not try to filter for all the workloads;
> do
> just best-effort.
>
> 3.
> Both ReorderBuffer and RelFileLocatorFilterCache have the same lifeti
On Tue, 28 Jan 2025 at 08:40, Ajin Cherian wrote:
>
> Here's a patch-set created based on the design changes proposed by Hou-san.
Few comments:
1) Shouldn't we do the same thing for other DecodeXXX functions?
@@ -915,6 +915,11 @@ DecodeInsert(LogicalDecodingContext *ctx,
XLogRecordBuffer *buf)
Hi Nisha.
Some review comments for patch v1-0001
==
GENERAL - Missing Test case?
1.
Should there be some before/after test case for 'active_since' value
with invalid slots to verify that the patch is doing what it says?
==
src/backend/replication/slot.c
ReplicationSlotAcquire:
2.
I sa
Hi Nikita,
On Wed, Dec 18, 2024 at 12:11 AM Nikita Malakhov wrote:
>
> Hi hackers!
>
> This thread is further work continued in [1], where Amit Langote
> suggested starting discussion on the remaining SQL/JSON feature
> 'PLAN clause for JSON_TABLE' anew.
>
> We'd like to help with merging SQL/JSO
Hi,
On 2025-01-29 14:12:52 -0500, Melanie Plageman wrote:
> From 71f32189aad510b73d221fb0478ffd916e5e5dde Mon Sep 17 00:00:00 2001
> From: Melanie Plageman
> Date: Mon, 27 Jan 2025 12:23:00 -0500
> Subject: [PATCH v14] Eagerly scan all-visible pages to amortize aggressive
> vacuum
>
> Amortize
hi.
just a quick response for v15.
the pg_restore man page says option --list as "List the table of
contents of the archive".
but
$BIN10/pg_restore --format=directory --list --file=1.sql dir10
also output the contents of "global.dat", we should not output it.
in restoreAllDatabases, we can do th
HI Nathan
> I had the opportunity to bring this patch up for discussion at the
> developer meeting at FOSDEM PGDay last week [0]. We discussed a subset
> of the topics folks have already written about in this thread, and AFAICT
> there was general approval among the attendees for proceeding with t
Hi,
Zhang Mingli
www.hashdata.xyz
On Feb 4, 2025 at 04:18 +0800, Sami Imseih , wrote:
>
> This really does not make sense as this
> optimization cannot be applied to a remote table and it
> can give a user a false impression that it was.
+1,
```
+ /*
+ * Raise an error on foreign tables as it's
Greg Sabino Mullane writes:
> ... For this
> particular item, I'm still of the opinion that leaving it as "List of
> relations" is a pretty good default for some future somebody who forgets to
> update the lists of relation types. New types are certainly not going to
> happen often. Better "List o
Peter Smith writes:
> I noticed today that there is no 'errhint_internal' function partner
> for the 'errhint' function.
> Now, it might seem that hints are always intended for user output so
> of course, you'll always want them translated...
Yeah, I think that was the reasoning. If it needs a
On Mon, Feb 3, 2025 at 5:38 PM Tom Lane wrote:
> One problem with it is that while we can leave "List of ???" out of the
> set of translatable strings easily, we can't currently do that for the
> argument of pg_log_error because it's automatically a gettext trigger. I'd
> rather not burden trans
On Mon, Feb 03, 2025 at 12:17:27PM +0100, Daniel Gustafsson wrote:
> The numbers are quite outdated but the gist of it holds. If we speed it up
> serverside we need to counter that with a higher iteration count, and for a
> rogue client it's unlikely to matter since it wont use our code anyways.
>
On Sun, Feb 02, 2025 at 10:38:32PM -0500, Tom Lane wrote:
> If I complain about it I gotta fix it, huh? Okay, done.
Thanks. :D
--
Michael
signature.asc
Description: PGP signature
Hi,
For each of the logging functions (see elog.c) there is an associated
XXX_internal function which is equivalent to its partner, but doesn't
translate the fmt message parameter.
errmsg
errmsg_internal - same as errmsg, but doesn't translate the fmt string
errdetail
errdetail_internal - same b
On Mon, Feb 03, 2025 at 12:45:24PM -0800, Jeff Davis wrote:
> A couple questions on the injection points framework:
>
> * The patch allows forcing the partition fan-out to one. I could
> imagine forcing it to a specific value, is there a way to do that?
>
> * The injection_points extension offers
On Mon, 2025-02-03 at 12:45 -0800, Jeff Davis wrote:
> * The patch allows forcing the partition fan-out to one. I could
> imagine forcing it to a specific value, is there a way to do that?
I hit "send" too quickly and this caused test failures in CI. Attaching
v2.
Changes:
* a new injection po
Hi Nisha.
Some review comments for patch v67-0001.
==
src/backend/replication/slot.c
ReportSlotInvalidation:
Please see my previous post [1] where I gave some reasons why I think
the _() macro should be used only for the *common* part of the hint
messages. If you agree, then the following c
Greg Sabino Mullane writes:
> I like the ntypes idea: please find attached version 3 which implements it.
> I wrote it slightly differently as I did not want to leave any chance of it
> escaping the if else blocks without a match.
Hmm, I was envisioning being a little more in-your-face about the
On Mon, Feb 3, 2025 at 5:34 PM Amit Kapila wrote:
>
> On Mon, Feb 3, 2025 at 6:16 AM Peter Smith wrote:
> >
> >
> > 2.
> > + appendStringInfo(&err_hint, "You might need to increase \"%s\".",
> > + "max_slot_wal_keep_size");
> > break;
> > 2a.
> > In this case, shouldn't you really be using macr
I wrote:
> But wait: HEAD takes
> Time: 6632.709 ms (00:06.633)
> to do the same thing. So somehow the new-style SQL function
> stuff is very materially slower in this use-case, with or
> without this patch. I do not understand why.
"perf" tells me that in the fx3 test, a full third of the runti
I like the ntypes idea: please find attached version 3 which implements it.
I wrote it slightly differently as I did not want to leave any chance of it
escaping the if else blocks without a match.
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & T
On Mon, Feb 03, 2025 at 03:12:57PM -0500, Tom Lane wrote:
> Greg Sabino Mullane writes:
>> I toyed with that for a bit, but as you say, without generating a ton of
>> combinations to translate, we'd have to fall back on run-time
>> constructions. Neither is ideal. I also realized that I almost nev
> Unless there's some existing way to specify a FREEZE option in the FDW API
> (I assume there isn't), I agree with this.
I am not aware of any way to do this either as postgres_fdw is simply
using libpq.
> > I was also looking at why we block a parent from COPY FREEZE[1], but
> Commit 5c9a551 a
On Mon, Feb 03, 2025 at 02:18:21PM -0600, Sami Imseih wrote:
> I think we should just block Foreign tables as we do with
> partition tables. Attached patch does that.
Unless there's some existing way to specify a FREEZE option in the FDW API
(I assume there isn't), I agree with this.
> I was also
Attached is a patch that adds a few injection points for hash
aggregation.
A couple questions on the injection points framework:
* The patch allows forcing the partition fan-out to one. I could
imagine forcing it to a specific value, is there a way to do that?
* The injection_points extension of
On Sun, Feb 2, 2025 at 9:50 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Sawada-san,
>
> > I think it's a good idea to support it at least on HEAD. I've attached
> > a patch for that.
>
> +1. I've confirmed that pg_rewind and -R can't output dbname for now,
> and your patch allows to do it.
>
> Few
Hi Peter,
> prefix= should only be set when running the "install" target, not when
> building (make all).
I see. I confirm that works. Still, don’t all the other parameters work when
passed to any/all targets? Should this one have an extension-specific name?
>> So I suspect the issue is that,
At this point I am planning on withdrawing this patch
from the March commitfest. I don't think fixing the REINDEX
debug1 output makes a whole lot of sense. I still think more logging
for (CREATE|ALTER) (INDEX|TABLE) will be a good to have but there
needs to be more discussion about the best approac
On Thu, Jan 30, 2025 at 04:29:35PM +0100, Alvaro Herrera wrote:
> A bunch of people discussed this patch in today's developer meeting in
> Brussels. There's pretty much a consensus on using the verb REPACK
> CONCURRENTLY for this new command -- where unadorned REPACK would be
> VACUUM FULL, and we
On Fri, Jan 31, 2025 at 03:23:56PM +0100, Jelte Fennema-Nio wrote:
> At the FOSDEM dev meeting we discussed potential improvements to the
> commitfest app and how to handle deploying future changes with minimal
> disruption to existing workflows. We're going to try a new approach:
> announcing a ne
Hi,
I was looking at COPY FREEZE and I found that it's
possible to run this command on a foreign table,
This really does not make sense as this
optimization cannot be applied to a remote table and it
can give a user a false impression that it was.
"""
postgres=# begin;
BEGIN
postgres=*# create fo
Greg Sabino Mullane writes:
> I toyed with that for a bit, but as you say, without generating a ton of
> combinations to translate, we'd have to fall back on run-time
> constructions. Neither is ideal. I also realized that I almost never type
> "\dti". Very common for me are \d and \dt and \dv etc
Barring objections, I am planning to commit this one soon. I might move
the addition of analyze_delay_point() to its own patch, but otherwise I
think it looks good to go.
--
nathan
Pavel Stehule writes:
> I did multiple benchmarking, and still looks so the proposed patch doesn't
> help and has significant overhead
Yeah, your fx() test case is clearly worse. For me,
HEAD:
regression=# do $$
begin
for i in 1..100 loop
perform fx((random()*100)::int); -- or fx2
I had the opportunity to bring this patch up for discussion at the
developer meeting at FOSDEM PGDay last week [0]. We discussed a subset
of the topics folks have already written about in this thread, and AFAICT
there was general approval among the attendees for proceeding with the
"hard cap" appr
On Mon, Feb 3, 2025 at 1:07 PM Tom Lane wrote:
> As presented, I think this fails the translatability guideline
Thanks, good point. Please find attached a slightly more verbose version
that should be better for translations.
For myself, if we were going to do something like this, I'd kind of
On Sun, Feb 2, 2025 at 10:00 PM Peter Smith wrote:
>
> On Mon, Feb 3, 2025 at 4:50 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Sawada-san,
> >
> > > I think it's a good idea to support it at least on HEAD. I've attached
> > > a patch for that.
> >
> > +1. I've confirmed that pg_rewind and -R
> On 3 Feb 2025, at 23:18, Tom Lane wrote:
>
> But I don't want to think of
> EEOP_PARAM_CALLBACK as being specifically tied to PL/pgSQL.
I've found 1 users on Github [0]. And a lot of copied code like [1]. And there
might be some unindexed cases.
Let's keep paramarg2.
Best regards, Andrey
On Mon, Feb 3, 2025 at 11:29 AM Alex Friedman wrote:
>
> Hi Sami,
>
> Thanks for the feedback.
>
> > 1/ Remove this as
> > "(50% of the maximum, which is about 20GB),"
> >
> > [1] tried to avoid explaining this level of detail, and I
> > agree with that.
>
> I feel it is critical for users to know
On Thu, Jan 30, 2025 at 7:07 PM Peter Smith wrote:
>
> On Fri, Jan 31, 2025 at 11:04 AM Masahiko Sawada
> wrote:
> >
> > On Wed, Jan 29, 2025 at 9:32 PM Peter Smith wrote:
> > >
> > > ==
> > > .../replication/logical/reorderbuffer.c
> > >
> > > ReorderBufferCheckAndTruncateAbortedTXN:
> > >
I wrote:
> Admittedly this is all moot unless some other extension starts
> using EEOP_PARAM_CALLBACK, and I didn't find any evidence of that
> using Debian Code Search. But I don't want to think of
> EEOP_PARAM_CALLBACK as being specifically tied to PL/pgSQL.
However ... given that I failed to f
On Wed, Jan 29, 2025 at 11:12 PM Peter Smith wrote:
>
> On Tue, Jan 28, 2025 at 9:26 PM Masahiko Sawada wrote:
> >
> > On Mon, Jan 27, 2025 at 7:01 PM Peter Smith wrote:
> > >
> ...
>
> > > To be honest, I didn't understand the "CLEAR" part of that name. It
> > > seems more like it should've bee
Andrey Borodin writes:
>> On 3 Feb 2025, at 22:36, Tom Lane wrote:
>> I'm not wedded to that name; do you have a better idea?
> I'd propose something like attached. But feel free to ignore my suggestion: I
> do not understand context of these structure members.
Hmm, you're suggesting naming th
Greg Sabino Mullane writes:
> Please find attached a patch to enable more intuitive titles when using
> psql and doing the following actions:
> \dt \di \dv \dm \ds \dE
> In other words, everything in listTables()
> We still default to "List or relations", but if we know that the user has
> request
On Mon, 3 Feb 2025 at 14:23, Srinath Reddy wrote:
>
> Hi,
> I found a bug ,while using "./pg_restore pdd -f -" actually it has to copy
> everything(global sql commands + remaining dump ) into stdout as per the "-f,
> --file=FILENAME output file name (- for stdout)" but it is copying
> glob
Hi Ian,
On Thu, Dec 12, 2024 at 12:23 PM Ilyasov Ian wrote:
> SIGSEGV was caused by two places in pg_controldata.c where there
> is a work with localtime(&time_tmp));. So I added a check for not NULL.
>
>
>
> Where casting second operand in % (XLogSegmentsPerXLogId(wal_segsz_bytes)) to
> un
> On 3 Feb 2025, at 22:36, Tom Lane wrote:
>
> I'm not wedded to that name; do you have a better idea?
I'd propose something like attached. But feel free to ignore my suggestion: I
do not understand context of these structure members.
Best regards, Andrey Borodin.
rename.diff
Description:
Hi
I did multiple benchmarking, and still looks so the proposed patch doesn't
help and has significant overhead
testcase:
create or replace function fx(int) returns int as $$ select $1 + $1; $$
language sql immutable;
create or replace function fx2(int) returns int as $$ select 2 * $1; $$
langua
Pavel Borisov writes:
> Minor notes on the patches:
> If dump_* functions could use the newly added walker, the code would
> look better. I suppose the main complication is that dump_* functions
> contain a lot of per-statement prints/formatting. So maybe a way to
> implement this is to put these
Please find attached a patch to enable more intuitive titles when using
psql and doing the following actions:
\dt \di \dv \dm \ds \dE
In other words, everything in listTables()
We still default to "List or relations", but if we know that the user has
requested exactly one specific type of relati
Andrey Borodin writes:
> (Well, maybe paramarg2 resonates a bit, just from similarity with varchar2)
I'm not wedded to that name; do you have a better idea?
Another idea could be to make it an array:
-void *paramarg;/* private data for same */
+void *para
Hi Sami,
Thanks for the feedback.
> 1/ Remove this as
> "(50% of the maximum, which is about 20GB),"
>
> [1] tried to avoid explaining this level of detail, and I
> agree with that.
I feel it is critical for users to know what is the hard limit of
multixact members. As PG doesn't (yet) expose ho
Thanks for the patch!
This does look like a documentation bug indeed.
I have a few comments:
1/ Remove this as
"(50% of the maximum, which is about 20GB),"
[1] tried to avoid explaining this level of detail, and I
agree with that.
2/ c/"about 10GB"/"10GB" the "about" does not seem necessary he
Hello!
I think it is a good idea to sent notification (at least once) to the
authors of entries. Because it is easy to miss that thread.
Best regards,
Mikhail.
On 03/02/2025 13:05, Yura Sokolov wrote:
Investigating some performance issues of a client, our engineers found
msgnumLock to be contended.
Looking closer it is obvious it is not needed at all: it used only as
memory barrier. It is even stated in comment at file start:
* We deal with that by ha
> --- a/src/backend/catalog/heap.c
> +++ b/src/backend/catalog/heap.c
> @@ -101,9 +101,6 @@ static ObjectAddress AddNewRelationType(const char
> *typeName,
>
> Oid new_row_type,
>
po 3. 2. 2025 v 17:00 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > Did you do some performance checks?
>
> This is a good question to ask ...
>
> > I tried some worst case
>
> > CREATE OR REPLACE FUNCTION fx(int)
> > RETURNS int AS $$
> > SELECT $1 + $1
> > $$ LANGUAGE SQL IMMUTABLE;
On Mon, 3 Feb 2025 at 13:56, Aleksander Alekseev
wrote:
> > """
> > The status of this patch cannot be changed in this commitfest. You
> > must modify it in the one where it's open!
> > """
>
> Ooops, never mind.
I also thought that error was pretty silly. So it will be changed in
the next releas
Pavel Stehule writes:
> Did you do some performance checks?
This is a good question to ask ...
> I tried some worst case
> CREATE OR REPLACE FUNCTION fx(int)
> RETURNS int AS $$
> SELECT $1 + $1
> $$ LANGUAGE SQL IMMUTABLE;
... but I don't think tests like this will give helpful answers.
That
On Mon, Feb 3, 2025 at 12:04 PM Amit Kapila wrote:
>
> On Mon, Feb 3, 2025 at 6:16 AM Peter Smith wrote:
> >
> >
> > 2.
> > + appendStringInfo(&err_hint, "You might need to increase \"%s\".",
> > + "max_slot_wal_keep_size");
> > break;
> > 2a.
> > In this case, shouldn't you really be using mac
Xuneng Zhou 于2025年1月8日周三 13:35写道：
> Hi Tender,
>
> I’ve looked through the patch, and I believe there is a potential issue.
> The default size for BufferDescriptors appears to be 16,384. Passing and
> casting a negative buffer ID to a large unsigned integer in
> GetBufferDescriptor, and then usin
Hi,
When a hot standby is restarted in a state where subtransactions have
overflowed, it may become inaccessible:
$ psql: error: connection to server at "localhost" (::1), port 5433
failed: FATAL: the database system is not yet accepting connections
DETAIL: Consistent recovery
Antonin Houska wrote:
> Alvaro Herrera wrote:
>
> >
> >
> > > From bf2ec8c5d753de340140839f1b061044ec4c1149 Mon Sep 17 00:00:00 2001
> > > From: Antonin Houska
> > > Date: Mon, 13 Jan 2025 14:29:54 +0100
> > > Subject: [PATCH 4/8] Add CONCURRENTLY option to both VACUUM FULL and
> > > CLUSTE
On Fri, 31 Jan 2025 at 17:50, Nisha Moond wrote:
>
> On Fri, Jan 31, 2025 at 2:32 PM Amit Kapila wrote:
> >
> > On Fri, Jan 31, 2025 at 10:40 AM Peter Smith wrote:
> > >
> > > ==
> > > src/backend/replication/slot.c
> > >
> > > ReportSlotInvalidation:
> > >
> > > 1.
> > > +
> > > + case RS_I
Hi,
> This doesn't work unfortunately.
>
> When I try to move my patches from CF 2025-01 to CF 2025-03 I get an error:
>
> """
> The status of this patch cannot be changed in this commitfest. You
> must modify it in the one where it's open!
> """
Ooops, never mind. The application asked me to log
Hi Peter,
> CF 2025-01 has just ended, so I suggest that everyone try this now. We
> can check in perhaps two weeks whether this results in lots of stuff
> falling through the cracks or still too much stuff with unclear status
> being moved forward, and then see what that might mean going forward
On Mon, Feb 3, 2025 at 5:14 PM jian he wrote:
>
> there is some corner like num_db_restore == 0, num_db_restore >= 100
> in that scarenio, the execute_global_sql_commands already executed,
> which is not ideal, since you have pg_fatal and some sql commands
> already executed.
> maybe we can be if
What's also suspicious is that on the destination node, after copying
finishes,
# explain select 1 from mytable;
Seq Scan on mytable (cost=0.00..6821514.12 rows=250410012 width=4)
# SELECT relname, n_live_tup FROM pg_stat_user_tables WHERE relname =
'mytable';
relname | estimated_rows
-
Hi,
Rebased the patch since it couldn't be applied anymore.
--
Regards,
--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.From 3f580c17214595eb8d6013674f5f054ec352ab7a Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi
Date: Mon, 3 Feb 2025 21:22:40 +0900
Subject: [PAT
Hi,
> >
> > Just idea; as an another option, how about blocking new requests to
> > the target process (e.g., causing them to fail with an error or
> > returning NULL with a warning) if a previous request is still
> pending?
> > Users can simply retry the request if it fails. IMO
On 9/21/24 8:24 PM, Nitin Jadhav wrote:
I reviewed the discussion and took a look at the patch sets. It seems
like many things are combined here. Based on the subject, I initially
thought it aimed to provide the infrastructure to easily extend
storage managers. This would allow anyone to create t
Hi
čt 30. 1. 2025 v 9:50 odesílatel Alexander Pyhalov
napsal:
> Alexander Pyhalov писал(а) 2025-01-29 17:35:
> > Tom Lane писал(а) 2025-01-17 21:27:
> >> Alexander Pyhalov writes:
> >>> I've rebased patch on master. Tests pass here.
> >>
> >> The cfbot still doesn't like it; my guess is that yo
Thank you for your comment. Sorry for being late.
SELECT FOR UPDATE SKIP LOCKED might skip a large number of rows,
leading to
a high volume of log messages from log_lock_failure in your current
patch.
Could this be considered unintended behavior? Would it be better to limit
the number of log
On 2025-Feb-03, Ashutosh Bapat wrote:
> ```
> If the
> constraint is NOT ENFORCED, the database system will
> not check the constraint. It is then up to the application code to
> ensure that the constraints are satisfied. The database system might
> still assume tha
03.02.2025 14:57, Álvaro Herrera пишет:
On 2025-Feb-03, Sergey Tatarintsev wrote:
Thanks for the note. I changed the query in the patch (v2 patch attached)
Btw, an additional benefit from the patch is that we can use foreign tables
(for example, to test postgres_fdw optimizations)
Good though
Here is the list of tmp files:
postgres@pg-101a:~/17/main/base/pgsql_tmp$ ls -la
total 5422297
drwx-- 2 postgres postgres 9 Feb 3 04:08 .
drwx-- 8 postgres postgres 8 Jan 29 01:27 ..
-rw--- 1 postgres postgres 1073741824 Feb 3 04:05 pgsql_tmp196534.0
-rw--- 1 po
On Mon, 3 Feb 2025 at 15:54, Alena Rybakina wrote:
>
>
> On 03.02.2025 14:32, Alexander Korotkov wrote:
>
> On Mon, Feb 3, 2025 at 12:22 PM Alena Rybakina
> wrote:
>
> Thank you for updated version! I agree for your version of the code.
>
> On 02.02.2025 21:00, Alexander Korotkov wrote:
>
> On Fr
Good day,
Investigating some performance issues of a client, our engineers found
msgnumLock to be contended.
Looking closer it is obvious it is not needed at all: it used only as
memory barrier. It is even stated in comment at file start:
* We deal with that by having a spinlock that readers mus
1 - 100 of 125 matches
Mail list logo
